Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147967
---


Ship it!




Master (19866b5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 7, 2016, 3:29 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Sept. 7, 2016, 3:29 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 
> f4f8d0037751c9c2096747264c19f6292461b308 
>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
> e5228ae9baadb8cad1e5ce143df09426d6107583 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/update.py 
> d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> a40830fd668aa650c22a48cbc757b45aef27e961 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  a7d1f74acdfe5f58eb822a4d826e920cad53dced 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 
>   src/test/python/apache/aurora/client/cli/util.py 
> aac9f9c802e4ad1f06cee8cf3f56749760b33af5 
> 
> Diff: https://reviews.apache.org/r/51384/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./pants test src/test/python/apache/aurora/client/cli:cli
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-09-06 Thread Santhosh Kumar Shanmugham 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/
---

(Updated Sept. 6, 2016, 8:29 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
Khutornenko.


Changes
---

Address comments from Maxim.
- Use sub-selects inplace of joins
- Add benchmark for job update metadata retrieval
- style fixes


Bugs: AURORA-1711
https://issues.apache.org/jira/browse/AURORA-1711


Repository: aurora


Description
---

Allow custom metadata to be stored with the job updates. This feature
is to help case the reconciliation on job update request on the clients.

Today when a client's requests are proxied via a middle-man,
if the middle-man times out before the scheduler responds with success,
the client is left the only option of retry. In the case of updates,
since multiple updates are not allowed in parallel, the retries fail,
with INVALID_REQUEST. Although the original update is already accepted
by the scheduler and is in-progress.

With this feature, clients can reconcile the job updates,
- by marking updates them with a unique id in the metadata field
- scheduler returns the in-progress job update in its response
- client can match the client-generated ids to reconcile its state.


Diffs (updated)
-

  RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 
f4f8d0037751c9c2096747264c19f6292461b308 
  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
e5228ae9baadb8cad1e5ce143df09426d6107583 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
  
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
 a3b04949f1726f110638e4f93ef45947cdb9e7f8 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
929d021a336c6a3438613c9340c84a1096dc9069 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
594bb6219294dcc77d48dcad14e2a6f9caa0c534 
  
src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
 PRE-CREATION 
  src/main/python/apache/aurora/client/api/__init__.py 
9149c3018ae58d405f284fcbd4076d251ccc8192 
  src/main/python/apache/aurora/client/cli/update.py 
d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
542f165add0f1d01a782fe6d6089bff3e736fb82 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
a40830fd668aa650c22a48cbc757b45aef27e961 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
08530397ff75081bde6f07f9d53317b5486e0da4 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
a7d1f74acdfe5f58eb822a4d826e920cad53dced 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 779dc302602ae8842084807ca868a491ea99b676 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
04551f17999d742c53dfb1b36286b119b448550e 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 
  src/test/python/apache/aurora/client/cli/util.py 
aac9f9c802e4ad1f06cee8cf3f56749760b33af5 

Diff: https://reviews.apache.org/r/51384/diff/


Testing
---

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./pants test src/test/python/apache/aurora/client/cli:cli


Thanks,

Santhosh Kumar Shanmugham

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review147957
---


Ship it!




Master (19866b5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 11:34 p.m., Karthik Anantha Padmanabhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> ---
> 
> (Updated Sept. 6, 2016, 11:34 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 3275d72a0a74909e635bce615e2036ec72aa38ee 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   src/main/python/apache/aurora/admin/admin.py 
> 76009b9c1c7a130c25abad544a176dc590dafb12 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 394deb57af9ad8832a02ceab15f33b3c1e5c902b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  b9317dc20456f90057ec2bf4d10619a5ae986187 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py 
> eb193c4a33f5275f05a995338446bec0e19bc1cf 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> afac2500551af2fce406bb906aa4e33f353e90a1 
> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> ---
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review147953
---



@ReviewBot retry

- Karthik Anantha Padmanabhan


On Sept. 6, 2016, 11:34 p.m., Karthik Anantha Padmanabhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> ---
> 
> (Updated Sept. 6, 2016, 11:34 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 3275d72a0a74909e635bce615e2036ec72aa38ee 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   src/main/python/apache/aurora/admin/admin.py 
> 76009b9c1c7a130c25abad544a176dc590dafb12 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 394deb57af9ad8832a02ceab15f33b3c1e5c902b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  b9317dc20456f90057ec2bf4d10619a5ae986187 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py 
> eb193c4a33f5275f05a995338446bec0e19bc1cf 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> afac2500551af2fce406bb906aa4e33f353e90a1 
> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> ---
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review147950
---



Master (19866b5) is red with this patch.
  ./build-support/jenkins/build.sh

 # Create file stdout for capturing output. We 
can't use StringIO mock
 # because TestProcess is running fork.
 with open(os.path.join(td, 'sys_stdout'), 
'w+') as stdout:
   with open(os.path.join(td, 'sys_stderr'), 
'w+') as stderr:
 with mutable_sys():
   sys.stdout, sys.stderr = stdout, 
stderr
 
   p = TestProcess('process', 'echo hello 
world; echo >&2 hello stderr', 0,
   taskpath, sandbox, 
logger_destination=LoggerDestination.BOTH)
   p.start()
   rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
 
   assert rc == 0
   # Check log files were created in std 
path with correct content
 > assert_log_content(taskpath, 'stdout', 
'hello world\n')
 
 src/test/python/apache/thermos/core/test_process.py:487: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 taskpath = 
 log_name = 'stdout'
 expected_content = 'hello world\n'
 
 def assert_log_content(taskpath, log_name, 
expected_content):
   log = 
taskpath.with_filename(log_name).getpath('process_logdir')
   assert os.path.exists(log)
   with open(log, 'r') as fp:
 >   assert fp.read() == expected_content
 E   assert '' == 'hello world\n'
 E + hello world
 
 src/test/python/apache/thermos/core/test_process.py:313: 
AssertionError
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 707 passed, 6 skipped, 1 warnings in 
290.28 seconds 
 
FAILURE


23:54:35 05:32   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 11:34 p.m., Karthik Anantha Padmanabhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> ---
> 
> (Updated Sept. 6, 2016, 11:34 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 3275d72a0a74909e635bce615e2036ec72aa38ee 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   src/main/python/apache/aurora/admin/admin.py 
> 76009b9c1c7a130c25abad544a176dc590dafb12 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 394deb57af9ad8832a02ceab15f33b3c1e5c902b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  b9317dc20456f90057ec2bf4d10619a5ae986187 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py 
> eb193c4a33f5275f05a995338446bec0e19bc1cf 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> afac2500551af2fce406bb906aa4e33f353e90a1 
> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> ---
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/
---

(Updated Sept. 6, 2016, 11:34 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
---

Updated Testing done.


Repository: aurora


Description
---

AURORA-1602 Aurora admin commands for reconcilation


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
3275d72a0a74909e635bce615e2036ec72aa38ee 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
929d021a336c6a3438613c9340c84a1096dc9069 
  src/main/python/apache/aurora/admin/admin.py 
76009b9c1c7a130c25abad544a176dc590dafb12 
  src/main/python/apache/aurora/admin/admin_util.py 
394deb57af9ad8832a02ceab15f33b3c1e5c902b 
  src/main/python/apache/aurora/client/api/__init__.py 
9149c3018ae58d405f284fcbd4076d251ccc8192 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 b9317dc20456f90057ec2bf4d10619a5ae986187 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 779dc302602ae8842084807ca868a491ea99b676 
  src/test/python/apache/aurora/admin/test_admin.py 
eb193c4a33f5275f05a995338446bec0e19bc1cf 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
afac2500551af2fce406bb906aa4e33f353e90a1 

Diff: https://reviews.apache.org/r/51662/diff/


Testing (updated)
---

* Manually tested on my local vagrant installation
* ./build-support/jenkins/build.sh


Thanks,

Karthik Anantha Padmanabhan

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/
---

(Updated Sept. 6, 2016, 11:18 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Repository: aurora


Description
---

AURORA-1602 Aurora admin commands for reconcilation


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
3275d72a0a74909e635bce615e2036ec72aa38ee 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
929d021a336c6a3438613c9340c84a1096dc9069 
  src/main/python/apache/aurora/admin/admin.py 
76009b9c1c7a130c25abad544a176dc590dafb12 
  src/main/python/apache/aurora/admin/admin_util.py 
394deb57af9ad8832a02ceab15f33b3c1e5c902b 
  src/main/python/apache/aurora/client/api/__init__.py 
9149c3018ae58d405f284fcbd4076d251ccc8192 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 b9317dc20456f90057ec2bf4d10619a5ae986187 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 779dc302602ae8842084807ca868a491ea99b676 
  src/test/python/apache/aurora/admin/test_admin.py 
eb193c4a33f5275f05a995338446bec0e19bc1cf 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
afac2500551af2fce406bb906aa4e33f353e90a1 

Diff: https://reviews.apache.org/r/51662/diff/


Testing
---

* Manually tested on my local vagrant installation


Thanks,

Karthik Anantha Padmanabhan

Re: Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51667/#review147937
---


Ship it!




Master (0c90c86) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 8:37 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51667/
> ---
> 
> (Updated Sept. 6, 2016, 8:37 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `HttpServletRequestParams` is dead code can be removed safely.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  e906f9458970bc01cc840ebbefeac384fe4d4cf3 
>   
> commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
>  f1479bfea90bd78cd07d451fc62ca2b4d341d654 
> 
> Diff: https://reviews.apache.org/r/51667/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang 


> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote:
> > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 
> > and also adapt the docs accordingly? That would optimize the default 
> > settings for the health check driven updates, which I think would be a good 
> > thing.
> 
> Maxim Khutornenko wrote:
> If we drop it to 0 now it will break many clients currently relying on 
> it. I think we'll have to wait until the next release if we want to set a new 
> default.

Thanks Stephan, we will release in the order of: scheduler -> executor -> 
client.


- Kai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147917
---


On Sept. 6, 2016, 6:46 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
> 
> (Updated Sept. 6, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Scheduler updater will not use watch_sec if health check is enabled.
> 
> This feature intends to improve reliability and performance of the Aurora 
> scheduler job updater by relying on health check status rather than 
> watch_secs timeout when deciding an individual instance update state. 
> 
> See this epic: https://issues.apache.org/jira/browse/AURORA-894 
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> After discussion on Aurora dev list, we decided to keep the watch_secs 
> infrastructure intact on scheduler side. Our final conclusion is that we 
> adopt the following implementation:
> 
> 1. If the users want purely health checking driven updates they can set 
> watch_secs to 0 and enable health checks.
> 
> 2. If they want to have both health checking and time driven updates they can 
> set watch_secs to the time that they care about, and doing health checks at 
> STARTING state as well.
> 
> 3. If they just want time driven updates they can disable health checking and 
> set watch_secs to the time that they care about.
> 
> In this review, there will be only one scheduler change: 
> Currently scheduler does not accept zero value for watch_secs, we need to 
> relax this constraint.
> 
> Executor change to do (in a separate review):
> The executor starts health check at STARTING, if a successful health check is 
> performed before initial_interval_sec expires, the executor will sends a 
> status message for RUNNING.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
> 
> Diff: https://reviews.apache.org/r/51536/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147922
---


Ship it!




Ship It!

- Maxim Khutornenko


On Sept. 6, 2016, 6:46 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
> 
> (Updated Sept. 6, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Scheduler updater will not use watch_sec if health check is enabled.
> 
> This feature intends to improve reliability and performance of the Aurora 
> scheduler job updater by relying on health check status rather than 
> watch_secs timeout when deciding an individual instance update state. 
> 
> See this epic: https://issues.apache.org/jira/browse/AURORA-894 
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> After discussion on Aurora dev list, we decided to keep the watch_secs 
> infrastructure intact on scheduler side. Our final conclusion is that we 
> adopt the following implementation:
> 
> 1. If the users want purely health checking driven updates they can set 
> watch_secs to 0 and enable health checks.
> 
> 2. If they want to have both health checking and time driven updates they can 
> set watch_secs to the time that they care about, and doing health checks at 
> STARTING state as well.
> 
> 3. If they just want time driven updates they can disable health checking and 
> set watch_secs to the time that they care about.
> 
> In this review, there will be only one scheduler change: 
> Currently scheduler does not accept zero value for watch_secs, we need to 
> relax this constraint.
> 
> Executor change to do (in a separate review):
> The executor starts health check at STARTING, if a successful health check is 
> performed before initial_interval_sec expires, the executor will sends a 
> status message for RUNNING.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
> 
> Diff: https://reviews.apache.org/r/51536/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko 


> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote:
> > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 
> > and also adapt the docs accordingly? That would optimize the default 
> > settings for the health check driven updates, which I think would be a good 
> > thing.

If we drop it to 0 now it will break many clients currently relying on it. I 
think we'll have to wait until the next release if we want to set a new default.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147917
---


On Sept. 6, 2016, 6:46 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
> 
> (Updated Sept. 6, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Scheduler updater will not use watch_sec if health check is enabled.
> 
> This feature intends to improve reliability and performance of the Aurora 
> scheduler job updater by relying on health check status rather than 
> watch_secs timeout when deciding an individual instance update state. 
> 
> See this epic: https://issues.apache.org/jira/browse/AURORA-894 
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> After discussion on Aurora dev list, we decided to keep the watch_secs 
> infrastructure intact on scheduler side. Our final conclusion is that we 
> adopt the following implementation:
> 
> 1. If the users want purely health checking driven updates they can set 
> watch_secs to 0 and enable health checks.
> 
> 2. If they want to have both health checking and time driven updates they can 
> set watch_secs to the time that they care about, and doing health checks at 
> STARTING state as well.
> 
> 3. If they just want time driven updates they can disable health checking and 
> set watch_secs to the time that they care about.
> 
> In this review, there will be only one scheduler change: 
> Currently scheduler does not accept zero value for watch_secs, we need to 
> relax this constraint.
> 
> Executor change to do (in a separate review):
> The executor starts health check at STARTING, if a successful health check is 
> performed before initial_interval_sec expires, the executor will sends a 
> status message for RUNNING.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
> 
> Diff: https://reviews.apache.org/r/51536/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51667/#review147919
---


Ship it!




Ship It!

- Stephan Erb


On Sept. 6, 2016, 10:37 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51667/
> ---
> 
> (Updated Sept. 6, 2016, 10:37 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> `HttpServletRequestParams` is dead code can be removed safely.
> 
> 
> Diffs
> -
> 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
>  e906f9458970bc01cc840ebbefeac384fe4d4cf3 
>   
> commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
>  f1479bfea90bd78cd07d451fc62ca2b4d341d654 
> 
> Diff: https://reviews.apache.org/r/51667/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147917
---



The current default of `watch_secs` is 45 seconds. Should we drop that to 0 and 
also adapt the docs accordingly? That would optimize the default settings for 
the health check driven updates, which I think would be a good thing.

- Stephan Erb


On Sept. 6, 2016, 8:46 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
> 
> (Updated Sept. 6, 2016, 8:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Scheduler updater will not use watch_sec if health check is enabled.
> 
> This feature intends to improve reliability and performance of the Aurora 
> scheduler job updater by relying on health check status rather than 
> watch_secs timeout when deciding an individual instance update state. 
> 
> See this epic: https://issues.apache.org/jira/browse/AURORA-894 
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> After discussion on Aurora dev list, we decided to keep the watch_secs 
> infrastructure intact on scheduler side. Our final conclusion is that we 
> adopt the following implementation:
> 
> 1. If the users want purely health checking driven updates they can set 
> watch_secs to 0 and enable health checks.
> 
> 2. If they want to have both health checking and time driven updates they can 
> set watch_secs to the time that they care about, and doing health checks at 
> STARTING state as well.
> 
> 3. If they just want time driven updates they can disable health checking and 
> set watch_secs to the time that they care about.
> 
> In this review, there will be only one scheduler change: 
> Currently scheduler does not accept zero value for watch_secs, we need to 
> relax this constraint.
> 
> Executor change to do (in a separate review):
> The executor starts health check at STARTING, if a successful health check is 
> performed before initial_interval_sec expires, the executor will sends a 
> status message for RUNNING.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
> 
> Diff: https://reviews.apache.org/r/51536/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147914
---


Ship it!




Master (0c90c86) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 51667: Remove HttpServletRequestParams

2016-09-06 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51667/
---

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
---

`HttpServletRequestParams` is dead code can be removed safely.


Diffs
-

  
commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java
 e906f9458970bc01cc840ebbefeac384fe4d4cf3 
  
commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java
 f1479bfea90bd78cd07d451fc62ca2b4d341d654 

Diff: https://reviews.apache.org/r/51667/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147908
---




docs/features/containers.md (lines 55 - 56)


Add a sentence to indicate that:

`Otherwise, this user and its primary group has to exist in the image with 
matching uid/gip`


- Zhitao Li


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Zhitao Li 


> On Sept. 6, 2016, 8 p.m., Zhitao Li wrote:
> > docs/features/containers.md, lines 55-56
> > 
> >
> > Add a sentence to indicate that:
> > 
> > `Otherwise, this user and its primary group has to exist in the image 
> > with matching uid/gip`

Sorry for typo, should be `uid/gid.`


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147908
---


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147900
---



This change is now on master at `0c90c862a14c3a5efe0fdf0f30ee41c01b96b434`.

- Zameer Manji


On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 11:56 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147899
---


Ship it!




Ship It!

- Zameer Manji


On Sept. 5, 2016, 11:56 a.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 11:56 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147898
---




docs/operations/configuration.md (line 34)


This is unrelated to the rest of the changeset. I noticed we are missing 
this crucial option in our docs which can cause peroblems if left unspecified.



examples/vagrant/aurorabuild.sh 


This line has no effect as we are already using Java 8.


- Stephan Erb


On Sept. 6, 2016, 9:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 9:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 51664: Document the Mesos containerizer

2016-09-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/
---

Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1640
https://issues.apache.org/jira/browse/AURORA-1640


Repository: aurora


Description
---

Included changes:

* enabled Docker support in our vagrant box
* consistent example jobs for both containerizers
* short enduser and operator  documentation
* shuffled the reference documentation so that it is clear certain limitations 
apply only to the Docker containerizer


Diffs
-

  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
  docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
  examples/jobs/docker/hello_docker.aurora 
d5611e6b78cb613c04e2fc3df54397ee4401a62e 
  examples/jobs/hello_docker_image.aurora PRE-CREATION 
  examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
  examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
7168c0ca4a81e0a1ce2320534015c6692b804b54 
  examples/vagrant/mesos_config/etc_mesos-slave/isolation 
c36223028513ace26040620b813022accaf0edf3 

Diff: https://reviews.apache.org/r/51664/diff/


Testing
---

Rendered version available at 
https://github.com/StephanErb/aurora/tree/containerizer-docs/docs


Thanks,

Stephan Erb

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review147894
---



Master (5d3f945) is red with this patch.
  ./build-support/jenkins/build.sh

@Forward({
^
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:46:
 error: File contains a sequence of empty lines.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:54:
 error: File contains a sequence of empty lines.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:82:
 error: File contains a sequence of empty lines.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:165:
 error: File contains a sequence of empty lines.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:244:7:
 error: 'if' is not followed by whitespace.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:209:58:
 error: Empty statement.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 19.553 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 7:02 p.m., Karthik Anantha Padmanabhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> ---
> 
> (Updated Sept. 6, 2016, 7:02 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 3275d72a0a74909e635bce615e2036ec72aa38ee 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   src/main/python/apache/aurora/admin/admin.py 
> 76009b9c1c7a130c25abad544a176dc590dafb12 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 394deb57af9ad8832a02ceab15f33b3c1e5c902b 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  b9317dc20456f90057ec2bf4d10619a5ae986187 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> ---
> 
> * Manually tested on my local vagrant installation
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147893
---


Ship it!




Master (5d3f945) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 6:46 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
> 
> (Updated Sept. 6, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Scheduler updater will not use watch_sec if health check is enabled.
> 
> This feature intends to improve reliability and performance of the Aurora 
> scheduler job updater by relying on health check status rather than 
> watch_secs timeout when deciding an individual instance update state. 
> 
> See this epic: https://issues.apache.org/jira/browse/AURORA-894 
> and the design doc: 
> https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
>  for more details and background.
> 
> After discussion on Aurora dev list, we decided to keep the watch_secs 
> infrastructure intact on scheduler side. Our final conclusion is that we 
> adopt the following implementation:
> 
> 1. If the users want purely health checking driven updates they can set 
> watch_secs to 0 and enable health checks.
> 
> 2. If they want to have both health checking and time driven updates they can 
> set watch_secs to the time that they care about, and doing health checks at 
> STARTING state as well.
> 
> 3. If they just want time driven updates they can disable health checking and 
> set watch_secs to the time that they care about.
> 
> In this review, there will be only one scheduler change: 
> Currently scheduler does not accept zero value for watch_secs, we need to 
> relax this constraint.
> 
> Executor change to do (in a separate review):
> The executor starts health check at STARTING, if a successful health check is 
> performed before initial_interval_sec expires, the executor will sends a 
> status message for RUNNING.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
> 
> Diff: https://reviews.apache.org/r/51536/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/
---

(Updated Sept. 6, 2016, 6:46 p.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Changes
---

Relax the watch_secs PreCondition check constraint on scheduler.


Summary (updated)
-

Scheduler updater will not use watch_sec if health check is enabled


Bugs: AURORA-894
https://issues.apache.org/jira/browse/AURORA-894


Repository: aurora


Description (updated)
---

- Scheduler updater will not use watch_sec if health check is enabled.

This feature intends to improve reliability and performance of the Aurora 
scheduler job updater by relying on health check status rather than watch_secs 
timeout when deciding an individual instance update state. 

See this epic: https://issues.apache.org/jira/browse/AURORA-894 
and the design doc: 
https://docs.google.com/document/d/1ZdgW8S4xMhvKW7iQUX99xZm10NXSxEWR0a-21FP5d94/edit#
 for more details and background.

After discussion on Aurora dev list, we decided to keep the watch_secs 
infrastructure intact on scheduler side. Our final conclusion is that we adopt 
the following implementation:

1. If the users want purely health checking driven updates they can set 
watch_secs to 0 and enable health checks.

2. If they want to have both health checking and time driven updates they can 
set watch_secs to the time that they care about, and doing health checks at 
STARTING state as well.

3. If they just want time driven updates they can disable health checking and 
set watch_secs to the time that they care about.

In this review, there will be only one scheduler change: 
Currently scheduler does not accept zero value for watch_secs, we need to relax 
this constraint.

Executor change to do (in a separate review):
The executor starts health check at STARTING, if a successful health check is 
performed before initial_interval_sec expires, the executor will sends a status 
message for RUNNING.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
04551f17999d742c53dfb1b36286b119b448550e 

Diff: https://reviews.apache.org/r/51536/diff/


Testing (updated)
---

./gradlew build

./gradlew :test --tests "org.apache.aurora.scheduler.updater.JobUpdaterIT"

./build-support/jenkins/build.sh


Thanks,

Kai Huang

Re: Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/
---

(Updated Sept. 6, 2016, 6:42 p.m.)


Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

AURORA-1602 Aurora admin commands for reconcilation


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
3275d72a0a74909e635bce615e2036ec72aa38ee 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
929d021a336c6a3438613c9340c84a1096dc9069 
  src/main/python/apache/aurora/admin/admin.py 
76009b9c1c7a130c25abad544a176dc590dafb12 
  src/main/python/apache/aurora/admin/admin_util.py 
394deb57af9ad8832a02ceab15f33b3c1e5c902b 
  src/main/python/apache/aurora/client/api/__init__.py 
9149c3018ae58d405f284fcbd4076d251ccc8192 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 b9317dc20456f90057ec2bf4d10619a5ae986187 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 779dc302602ae8842084807ca868a491ea99b676 

Diff: https://reviews.apache.org/r/51662/diff/


Testing (updated)
---

* Manually tested on my local vagrant installation


Thanks,

Karthik Anantha Padmanabhan

Review Request 51662: AURORA-1602 Aurora admin commands for reconcilation

2016-09-06 Thread Karthik Anantha Padmanabhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

AURORA-1602 Aurora admin commands for reconcilation


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
c5765b70501c101f0535b4eed94e9948c36808f9 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
3275d72a0a74909e635bce615e2036ec72aa38ee 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
929d021a336c6a3438613c9340c84a1096dc9069 
  src/main/python/apache/aurora/admin/admin.py 
76009b9c1c7a130c25abad544a176dc590dafb12 
  src/main/python/apache/aurora/admin/admin_util.py 
394deb57af9ad8832a02ceab15f33b3c1e5c902b 
  src/main/python/apache/aurora/client/api/__init__.py 
9149c3018ae58d405f284fcbd4076d251ccc8192 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 b9317dc20456f90057ec2bf4d10619a5ae986187 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 779dc302602ae8842084807ca868a491ea99b676 

Diff: https://reviews.apache.org/r/51662/diff/


Testing
---


Thanks,

Karthik Anantha Padmanabhan

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-09-06 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147856
---


Ship it!




I'm fine with trimming dead code from our commons fork and centralizing the 
stats interface with the understanding that we might re-add some of this in the 
future if/when the need arises.

- Joshua Cohen


On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> ---
> 
> (Updated Aug. 26, 2016, 10:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147855
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Re: Review Request 51580: Add MEDIAN_TIME_TO_STARTING as a new metric

2016-09-06 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147853
---


Ship it!




Ship It!

- Maxim Khutornenko


On Sept. 5, 2016, 6:56 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> ---
> 
> (Updated Sept. 5, 2016, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -
> 
>   docs/features/sla-metrics.md 932b5dceb7e356175c7e55c75c5546ecde7ad2c4 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> ./gradlew :test
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>