Re: Review Request 52640: Upgrade to pants 1.2.0rc0.

2016-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52640/#review151917 --- Ship it! Master (09b8e58) is green with this patch.

Re: Review Request 52640: Upgrade to pants 1.2.0rc0.

2016-10-07 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52640/ --- (Updated Oct. 7, 2016, 10:34 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151870 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2016, 7:19

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151864 --- Ship it! Master (09b8e58) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 7, 2016, 12:19 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52640: Upgrade to pants 1.2.0dev12.

2016-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52640/#review151816 --- Ship it! Master (09b8e58) is green with this patch.

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151804 --- src/main/python/apache/aurora/common/cookie_auth_module.py (line

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread David McLaughlin
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151777 --- This patch does not apply cleanly against master (09b8e58), do

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 7, 2016, 10:49 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread Giulio Eulisse
> On Oct. 6, 2016, 5:40 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/client.py, line 85 > > > > > > I think we can move this import to the top with the rest of the > > imports? The only

Re: Review Request 51893: Allow cookie based authentication

2016-10-07 Thread Giulio Eulisse
> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your