Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review152992 --- This patch does not apply cleanly against master (ac8b802), do

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144 > > > > > > This split looks kind of magic. What does it do? > > Pradyumna Kaushik

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/ --- (Updated Oct. 17, 2016, 11:35 p.m.) Review request for Aurora and Joshua

Re: Review Request 52957: Handle the case where content type header is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52957/#review152979 --- Master (ac8b802) is green with this patch.

Review Request 52957: Handle the case where content type header is null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52957/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1795

Re: Review Request 52821: Fix the -enable_revocable_ram flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152972 --- Master (ac8b802) is green with this patch.

Re: Review Request 52821: Fix the -enable_revocable_ram flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152964 --- This patch does not apply cleanly against master (ac8b802), do

Re: Review Request 52821: Fix the -enable_revocable_ram flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/ --- (Updated Oct. 17, 2016, 11:24 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144 > > > > > > This split looks kind of magic. What does it do? > > Pradyumna Kaushik

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

> On Oct. 17, 2016, 11:45 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 144 > > > > > > This split looks kind of magic. What does it do? Joiner.on(...) would

Re: Review Request 52821: Fix the -enable_revocable_ram flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52821/#review152917 --- Ship it! Ship It! - Zameer Manji On Oct. 13, 2016, 2:27

Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review152894 --- Ship it! Ship It! - Joshua Cohen On Oct. 15, 2016, 10:42

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152893 --- Ship it! Ship It! - John Sirois On Oct. 16, 2016, 5:04

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

> On Oct. 17, 2016, 9:41 a.m., Joshua Cohen wrote: > > Should we also add: > > > > if (o == null) { > > return false; > > } > > > > ? > > > > Curious if we're able to see a difference in benchmarks from this change? It would be a bit of black magic if that were significantly

Re: Review Request 52921: In immutable Thrift structs, check identity before comparing fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52921/#review152889 --- Should we also add: if (o == null) { return false;

Re: Review Request 52884: Document how to create a custom CLI build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152861 --- Ship it! Master (ac8b802) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring

Re: Review Request 52884: Document how to create a custom CLI build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152857 --- @ReviewBot retry - Stephan Erb On Oct. 14, 2016, 5:03 p.m.,

Re: Review Request 52884: Document how to create a custom CLI build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52884/#review152858 --- Ship it! Ship It! - Stephan Erb On Oct. 14, 2016, 5:03

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152853 --- docs/features/containers.md (line 120)

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review152852 --- src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java