Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Joshua Cohen
> On Nov. 2, 2016, 6:06 a.m., Santhosh Kumar Shanmugham wrote: > > Note to committer: This patch changes the packer build script. > > Santhosh Kumar Shanmugham wrote: > Please do not commit - fixing flakiness in the end-to-end. Ping me tomorrow and I can walk you through the process of

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154671 --- Overall this looks good to me. I have no idea how to test this

Re: Review Request 52665: Populate curator latches with scheduler information

2016-11-02 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52665/#review154670 --- Ship it! Ship It! - John Sirois On Oct. 29, 2016, 4:05

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Stephan Erb
> On Nov. 2, 2016, 10:23 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, lines 876-881 > > > > > > The `TaskRunnerHelper.terminate_process` might generate new orphans. > > The call to

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154650 --- Master (13d4861) is red with this patch.

Re: Review Request 53408: Update h2 database to 1.4.193

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53408/#review154644 --- Ship it! Ship It! - Zameer Manji On Nov. 2, 2016, 3:17

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- (Updated Nov. 2, 2016, 3:13 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154630 --- Master (13d4861) is red with this patch.

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- (Updated Nov. 2, 2016, 1:32 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Santhosh Kumar Shanmugham
> On Nov. 1, 2016, 11:06 p.m., Santhosh Kumar Shanmugham wrote: > > Note to committer: This patch changes the packer build script. Please do not commit - fixing flakiness in the end-to-end. - Santhosh Kumar --- This is an automatically

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2016-11-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154573 --- Ups, I forgot. The following seems to be missing: * Changelog

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2016-11-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154572 --- Ship it! Ship It! - Stephan Erb On Nov. 1, 2016, 2:48 a.m.,

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review154518 --- Note to committer: This patch changes the packer build script. -

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-11-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review154517 --- Ship it! Master (13d4861) is green with this patch.