Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155039
---


Ship it!




Master (5410c22) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 5, 2016, 12:53 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
> 
> (Updated Nov. 5, 2016, 12:53 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ 
> and
> wraps the `prcl(2)` call in a try except block.
> 
> This also exposed some flakyness in
> `TestRunnerKillProcessGroup.test_pg_is_killed`. Marked the test as flaky and
> filed AURORA-1809.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py 
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
>   src/main/python/apache/thermos/core/process.py 
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802 
>   src/test/python/apache/thermos/core/test_staged_kill.py 
> 9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8 
> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---

(Updated Nov. 4, 2016, 5:53 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description (updated)
---

The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.

This also exposed some flakyness in
`TestRunnerKillProcessGroup.test_pg_is_killed`. Marked the test as flaky and
filed AURORA-1809.


Diffs
-

  RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
  src/main/python/apache/thermos/common/process_util.py 
c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
  src/main/python/apache/thermos/core/process.py 
13f9ad5711edde3a0a0d47ba6db1c199434e6802 
  src/test/python/apache/thermos/core/test_staged_kill.py 
9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8 

Diff: https://reviews.apache.org/r/53508/diff/


Testing
---

./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Zameer Manji

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---

(Updated Nov. 4, 2016, 5:53 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
---

Skip flaky test.


Repository: aurora


Description
---

The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.


Diffs (updated)
-

  RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
  src/main/python/apache/thermos/common/process_util.py 
c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
  src/main/python/apache/thermos/core/process.py 
13f9ad5711edde3a0a0d47ba6db1c199434e6802 
  src/test/python/apache/thermos/core/test_staged_kill.py 
9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8 

Diff: https://reviews.apache.org/r/53508/diff/


Testing
---

./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Zameer Manji

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155032
---



Master (5410c22) is red with this patch.
  ./build-support/jenkins/build.sh

 
   ps = ProcessProviderFactory.get()
   ps.collect_all()
   assert parent_pid in ps.pids()
   assert child_pid in ps.pids()
   assert child_pid in 
ps.children_of(parent_pid)
 
   with open(os.path.join(runner.sandbox, 
runner.task_id, 'exit.txt'), 'w') as fp:
 fp.write('go away!')
 
   while tm.task_state() is not 
TaskState.SUCCESS:
 time.sleep(0.1)
 
   state = tm.get_state()
   assert state.processes['process'][0].state == 
ProcessState.SUCCESS
 
   ps.collect_all()
   assert parent_pid not in ps.pids()
 > assert child_pid not in ps.pids()
 E assert 30475 not in set([1, 2, 3, 5, 7, 8, 
...])
 E  +  where set([1, 2, 3, 5, 7, 8, ...]) = 
>()
 E  +where > = 
.pids
 
 
src/test/python/apache/thermos/core/test_staged_kill.py:287: AssertionError
 -- Captured stderr call --
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
 WARNING:root:Could not read from checkpoint 
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 719 passed, 6 skipped, 1 warnings in 
206.00 seconds 
 
FAILURE


00:35:12 03:45   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 4, 2016, 11:54 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
> 
> (Updated Nov. 4, 2016, 11:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ 
> and
> wraps the `prcl(2)` call in a try except block.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py 
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
>   src/main/python/apache/thermos/core/process.py 
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802 
> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155027
---



@ReviewBot retry

- Zameer Manji


On Nov. 4, 2016, 4:54 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
> 
> (Updated Nov. 4, 2016, 4:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ 
> and
> wraps the `prcl(2)` call in a try except block.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py 
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
>   src/main/python/apache/thermos/core/process.py 
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802 
> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---

(Updated Nov. 4, 2016, 4:54 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Repository: aurora


Description (updated)
---

The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.


Diffs
-

  RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
  src/main/python/apache/thermos/common/process_util.py 
c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
  src/main/python/apache/thermos/core/process.py 
13f9ad5711edde3a0a0d47ba6db1c199434e6802 

Diff: https://reviews.apache.org/r/53508/diff/


Testing
---

./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Zameer Manji

Re: Review Request 53508: Fix regression in 5410c22.

2016-11-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155021
---



Master (5410c22) is red with this patch.
  ./build-support/jenkins/build.sh

---
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/http/Offers
  Test coverage missing for org/apache/aurora/scheduler/http/Mname
  Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
  Test coverage missing for org/apache/aurora/scheduler/http/Cron
  Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
  Test coverage missing for 
org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
  Test coverage missing for 
org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
  Test coverage missing for 
org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
  Test coverage missing for org/apache/aurora/scheduler/filter/AttributeFilter
  Test coverage missing for org/apache/aurora/scheduler/filter/ConstraintMatcher
  Test coverage missing for 
org/apache/aurora/scheduler/filter/SchedulingFilterImpl$1
  Test coverage missing for 
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
  Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
  Test coverage missing for 
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
  Test coverage missing for 
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
  Test coverage missing for 
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
  Test coverage missing for 
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
  Test coverage missing for org/apache/aurora/scheduler/storage/db/PruneVictim
  Test coverage missing for 
org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
  Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
  Test coverage missing for 
org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
  Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
  Test coverage missing for org/apache/aurora/scheduler/events/Webhook
  Test coverage missing for 
org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
  Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
  Test coverage missing for 
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

BUILD FAILED

Total time: 6 mins 21.609 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 4, 2016, 11:43 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
> 
> (Updated Nov. 4, 2016, 11:43 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ 
> and
> wraps the `prcl(2)` call in a try except box.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py 
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40 
>   src/main/python/apache/thermos/core/process.py 
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802 
> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" 
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 53418: Send SIGTERM to daemonized processes on shutdown.

2016-11-04 Thread Stephan Erb 


> On Nov. 4, 2016, 5:03 p.m., Stephan Erb wrote:
> > LGTM in general. I may not be around for the rest of the day and the 
> > weekend, so I mark thas 'Ship it, then fix it'.

Ahh, "Fix it, then Ship it!" :-)


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53418/#review154913
---


On Nov. 4, 2016, 12:48 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53418/
> ---
> 
> (Updated Nov. 4, 2016, 12:48 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1808
> https://issues.apache.org/jira/browse/AURORA-1808
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> # Problem
> 
> Processes can deamonize and escape the supervision of a coordinator. Using 
> the Docker Containerizer or the Mesos Containerizer with pid isolation means 
> that the processes will be come reparented to the sh process that launches 
> the executor. For example:
> 
> ```
> root@aurora:/# ps xf
>   PID TTY  STAT   TIME COMMAND
>48 ?Ss 0:00 /bin/bash
>86 ?R+ 0:00  _ ps xf
> 1 ?Ss 0:00 /bin/sh -c ${MESOS_SANDBOX=.}/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/va
> 5 ?Sl 0:02 python2.7 /mnt/mesos/sandbox/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vag
>23 ?S  0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-bde5cdc7-8685-46fd-9078-4a86bd5be152
>  --
>29 ?Ss 0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-bde5cdc7-8685-46fd-9078-4a86bd5be15
>32 ?S  0:00  |   _ /bin/bash -c  while true; do   
> echo hello world   sleep 10 done
>81 ?S  0:00  |   _ sleep 10
>31 ?Ss 0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-bde5cdc7-8685-46fd-9078-4a86bd5be15
>33 ?S  0:00  _ /bin/bash -c  while true; do   
> echo hello world   sleep 10 done
>82 ?S  0:00  _ sleep 10
>47 ?S  0:00 python ./daemon.py
> ```
> 
> # Solution
> 
> Ensure processes that escape the supervision of the coordinator reparent to 
> the runner who can send signals to them on task tear down. We do this by 
> using the `PR_SET_CHILD_SUBREAPER` flag of `prctl(2)`.
> 
> After this change the process tree looks like:
> ```
> root@aurora:/# ps xf
>   PID TTY  STAT   TIME COMMAND
>66 ?Ss 0:00 /bin/bash
>70 ?R+ 0:00  _ ps xf
> 1 ?Ss 0:00 /bin/sh -c ${MESOS_SANDBOX=.}/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/va
> 5 ?Sl 0:02 python2.7 /mnt/mesos/sandbox/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vag
>23 ?S  0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-721406db-00f5-4c0c-915e-1dbc5568b849
>  --
>33 ?Ss 0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-721406db-00f5-4c0c-915e-1dbc5568b84
>40 ?S  0:00  |   _ /bin/bash -c  while true; do   
> echo hello world   sleep 10 done
>63 ?S  0:00  |   _ sleep 10
>36 ?Ss 0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
> --task_id=www-data-devel-hello_docker_engine-0-721406db-00f5-4c0c-915e-1dbc5568b84
>37 ?S  0:00  |   _ /bin/bash -c  while true; do   
> echo hello world   sleep 10 done
>62 ?S  0:00  |   _ sleep 10
>55 ?S  0:00  _ python ./daemon.py
> 
> ```
> 
> Now the runner is aware of the reparented procesess can can tear it down 
> cleanly with a `SIGTERM`.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md d89ef2f641373ac229be693a21a2c0111e1f241a 
>   src/main/python/apache/thermos/common/process_util.py 
> abd2c0ef35858d13971319b0a7436ce2293824ce 
>   src/main/python/apache/thermos/core/helper.py 
> 68855e1e54ba1cd4456e18a36fb237ce6a468c34 
>   src/main/python/apache/thermos/core/process.py 
>

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53452/#review154905
---


Ship it!




I am not sure we really need to log both TaskConfig and AssignedTask. I fell 
like the AssignedTask is the one we really care about from the perspective of 
Aurora.

But I don't want to start a bikeshedding discussion, so the decision is up to 
you :)

- Stephan Erb


On Nov. 4, 2016, 1:52 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53452/
> ---
> 
> (Updated Nov. 4, 2016, 1:52 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1792
> https://issues.apache.org/jira/browse/AURORA-1792
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The executor logs `ExecutorInfo`, `FrameworkInfo`, `SlaveInfo` on startup. 
> This adds logging of `TaskInfo` and the Assigned Task object when it is 
> recieved.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
> 
> Diff: https://reviews.apache.org/r/53452/diff/
> 
> 
> Testing
> ---
> 
> Launched a task in vagrant and checked the logs. Example output:
> 
> I1103 09:55:40.991879 24713 executor_base.py:45] Executor [None]: TaskInfo: 
> name: "www-data/prod/hello"
> task_id {
>   value: "www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
> }
> slave_id {
>   value: "d8988ce6-c900-49a1-897d-bc141f390394-S0"
> }
> resources {
>   name: "disk"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "*"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "aurora-role"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "*"
> }
> resources {
>   name: "mem"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "aurora-role"
> }
> executor {
>   executor_id {
> value: 
> "thermos-www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
>   }
>   resources {
> name: "cpus"
> type: SCALAR
> scalar {
>   value: 0.25
> }
> role: "*"
>   }
>   resources {
> name: "mem"
> type: SCALAR
> scalar {
>   value: 128.0
> }
> role: "aurora-role"
>   }
>   command {
> uris {
>   value: "/home/vagrant/aurora/dist/thermos_executor.pex"
>   executable: true
> }
> value: "${MESOS_SANDBOX=.}/thermos_executor.pex --announcer-ensemble 
> localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json 
> --mesos-containerizer-path=/usr/libexec/mesos/mesos-containerizer"
>   }
>   framework_id {
> value: "d8988ce6-c900-49a1-897d-bc141f390394-"
>   }
>   name: "AuroraExecutor"
>   source: "www-data.prod.hello.0"
>   labels {
> labels {
>   key: "source"
>   value: "www-data.prod.hello.0"
> }
>   }
> }
> data: 
> "\013\000\001\000\000\000:www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6\013\000\002\000\000\000\'d8988ce6-c900-49a1-897d-bc141f390394-S0\013\000\003\000\000\000\014192.168.33.7\014\000\004\002\000\007\001\004\000\010?\360\000\000\000\000\000\000\n\000\t\000\000\000\000\000\000\000\200\n\000\n\000\000\000\000\000\000\000\200\010\000\013\000\000\000\000\010\000\r\000\000\000\001\014\000\021\013\000\002\000\000\000\007vagrant\000\002\000\022\000\016\000\024\014\000\000\000\000\016\000\025\013\000\000\000\000\r\000\026\013\013\000\000\000\000\014\000\031\013\000\001\000\000\000\016AuroraExecutor\013\000\002\000\000\004\021{\"environment\":
>  \"prod\", \"health_check_config\": {\"initial_interval_secs\": 15.0, 
> \"health_checker\": {\"http\": {\"expected_response_code\": 0, \"endpoint\": 
> \"/health\", \"expected_response\": \"ok\"}}, \"interval_secs\": 10.0, 
> \"timeout_secs\": 1.0, \"max_consecutive_failures\": 0}, \"name\": \"hello\", 
> \"service\": true, \"max_task_failures
 \": 1, \"cron_collision_policy\": \"KILL_EXISTING\", \"enable_hooks\": false, 
\"cluster\": \"devcluster\", \"task\": {\"processes\": [{\"daemon\": false, 
\"name\": \"hello\", \"ephemeral\": false, \"max_failures\": 1, 
\"min_duration\": 5, \"cmdline\": \"\nwhile true; do\n  echo hello 
world\n  sleep 10\ndone\n  \", \"final\": false}], \"name\": \"hello\", 
\"finalization_wait\": 30, \"max_failures\": 1, \"max_concurrency\": 0, 
\"resources\": {\"gpu\": 0, \"disk\": 134217728, \"ram\": 134217728, \"cpu\": 
1.0}, \"constraints\": [{\"order\": [\"hello\"]}]}, \"production\": false, 
\"role\": \"www-data\", \"tier\": \"preemptible\", \"lifecycle\": {\"http\": 
{\"graceful_shutdown_endpoint\": \"/quitquitquit\", \"port\": \"health\", 
\"shutdown_endpoint\":

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53452/#review154906
---



Master (35435cb) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 4, 2016, 12:52 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53452/
> ---
> 
> (Updated Nov. 4, 2016, 12:52 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1792
> https://issues.apache.org/jira/browse/AURORA-1792
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The executor logs `ExecutorInfo`, `FrameworkInfo`, `SlaveInfo` on startup. 
> This adds logging of `TaskInfo` and the Assigned Task object when it is 
> recieved.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
> 
> Diff: https://reviews.apache.org/r/53452/diff/
> 
> 
> Testing
> ---
> 
> Launched a task in vagrant and checked the logs. Example output:
> 
> I1103 09:55:40.991879 24713 executor_base.py:45] Executor [None]: TaskInfo: 
> name: "www-data/prod/hello"
> task_id {
>   value: "www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
> }
> slave_id {
>   value: "d8988ce6-c900-49a1-897d-bc141f390394-S0"
> }
> resources {
>   name: "disk"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "*"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "aurora-role"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "*"
> }
> resources {
>   name: "mem"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "aurora-role"
> }
> executor {
>   executor_id {
> value: 
> "thermos-www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
>   }
>   resources {
> name: "cpus"
> type: SCALAR
> scalar {
>   value: 0.25
> }
> role: "*"
>   }
>   resources {
> name: "mem"
> type: SCALAR
> scalar {
>   value: 128.0
> }
> role: "aurora-role"
>   }
>   command {
> uris {
>   value: "/home/vagrant/aurora/dist/thermos_executor.pex"
>   executable: true
> }
> value: "${MESOS_SANDBOX=.}/thermos_executor.pex --announcer-ensemble 
> localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json 
> --mesos-containerizer-path=/usr/libexec/mesos/mesos-containerizer"
>   }
>   framework_id {
> value: "d8988ce6-c900-49a1-897d-bc141f390394-"
>   }
>   name: "AuroraExecutor"
>   source: "www-data.prod.hello.0"
>   labels {
> labels {
>   key: "source"
>   value: "www-data.prod.hello.0"
> }
>   }
> }
> data: 
> "\013\000\001\000\000\000:www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6\013\000\002\000\000\000\'d8988ce6-c900-49a1-897d-bc141f390394-S0\013\000\003\000\000\000\014192.168.33.7\014\000\004\002\000\007\001\004\000\010?\360\000\000\000\000\000\000\n\000\t\000\000\000\000\000\000\000\200\n\000\n\000\000\000\000\000\000\000\200\010\000\013\000\000\000\000\010\000\r\000\000\000\001\014\000\021\013\000\002\000\000\000\007vagrant\000\002\000\022\000\016\000\024\014\000\000\000\000\016\000\025\013\000\000\000\000\r\000\026\013\013\000\000\000\000\014\000\031\013\000\001\000\000\000\016AuroraExecutor\013\000\002\000\000\004\021{\"environment\":
>  \"prod\", \"health_check_config\": {\"initial_interval_secs\": 15.0, 
> \"health_checker\": {\"http\": {\"expected_response_code\": 0, \"endpoint\": 
> \"/health\", \"expected_response\": \"ok\"}}, \"interval_secs\": 10.0, 
> \"timeout_secs\": 1.0, \"max_consecutive_failures\": 0}, \"name\": \"hello\", 
> \"service\": true, \"max_task_failures
 \": 1, \"cron_collision_policy\": \"KILL_EXISTING\", \"enable_hooks\": false, 
\"cluster\": \"devcluster\", \"task\": {\"processes\": [{\"daemon\": false, 
\"name\": \"hello\", \"ephemeral\": false, \"max_failures\": 1, 
\"min_duration\": 5, \"cmdline\": \"\nwhile true; do\n  echo hello 
world\n  sleep 10\ndone\n  \", \"final\": false}], \"name\": \"hello\", 
\"finalization_wait\": 30, \"max_failures\": 1, \"max_concurrency\": 0, 
\"resources\": {\"gpu\": 0, \"disk\": 134217728, \"ram\": 134217728, \"cpu\": 
1.0}, \"constraints\": [{\"order\": [\"hello\"]}]}, \"production\": false, 
\"role\": \"www-data\", \"tier\": \"preemptible\", \"lifecycle\": {\"http\": 
{\"graceful_shutdown_endpoint\": \"/quitquitquit\", \"port\": \"health\", 
\"shutdown_endpoint\": \"/abortabortabort\"}}, \"priority\":

Re: Review Request 53114: aurora job inspect should have a --write-json option

2016-11-04 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53114/#review154902
---




src/main/python/apache/aurora/client/cli/jobs.py (lines 287 - 333)


Having a manual json assembly here is brittle.  Whenever we change 
something in the pystachio schema we have to make sure we update this place as 
well. This is asking for trouble down the road.

I would propose to replace this with a single call of the existing 
pystachio json serialization method instead:

```
config.raw().json_dumps()
```

A file written using this is then also suitable for ingestion via our 
`--read-json` methods.  For example:

```
aurora job inspect --read-json devcluster/www-data/prod/hello 
hello_world.json
```


- Stephan Erb


On Oct. 25, 2016, 4:14 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53114/
> ---
> 
> (Updated Oct. 25, 2016, 4:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-1504
> https://issues.apache.org/jira/browse/AURORA-1504
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> aurora job inspect should have a --write-json option
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 87fbf13f8e5955b30436f8d871b548275f009893 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> fedc16b3d4e9fb7d6f5f0dc34ad7a1837e34baea 
> 
> Diff: https://reviews.apache.org/r/53114/diff/
> 
> 
> Testing
> ---
> 
> * For configuration for a job as:
> ```
> pkg_path = '/vagrant/hello.py'
> 
> install = Process(
> name='fetch package',
> cmdline='cp {} . && chmod u+x hello.py'.format(pkg_path))
> 
> runner = Process(
> name='hello jing',
> ephemeral = True,
> cmdline='python -u hello.py')
> 
> hello_task = SequentialTask(
> name='hello task',
> processes=[install, runner],
> resources=Resources(cpu=1, ram=1*MB, disk=8*MB))
> 
> jobs = [
> Service(cluster='devcluster',
> role='www-data',
> environment='devel',
> name='hello_jing',
> task=hello_task,
> constraints = {
>   'host':'limit:2',
>   'rack':'limit:1'
> })
> ]
> ```
> command 'aurora job inspect devcluster/www-data/devel/hello_jing 
> /vagrant/hello.aurora --write-json' returns:
> ```
> {
>   "job": {
> "name": "hello_jing",
> "role": "www-data",
> "cluster": "devcluster",
> "instances": "1",
> "constraints": [
>   {
> "host": "limit:2"
>   },
>   {
> "rack": "limit:1"
>   }
> ],
> "service": true,
> "production": false
>   },
>   "task": {
> "name": "hello task",
> "constraints": [
>   "fetch package < hello jing"
> ],
> "processes": [
>   {
> "name": "fetch package",
> "daemon": false,
> "ephemeral": false,
> "final": false,
> "cmdline": [
>   "cp /vagrant/hello.py . && chmod u+x hello.py"
> ]
>   },
>   {
> "name": "hello jing",
> "daemon": false,
> "ephemeral": true,
> "final": false,
> "cmdline": [
>   "python -u hello.py"
> ]
>   }
> ]
>   }
> }
> 
> ```
> 
> * For configuration for a cron job as:
> ```
> jobs = [
>   Job(
> cluster = 'devcluster',
> role = 'www-data',
> environment = 'devel',
> name = 'cron_hello_jing',
> cron_schedule = '*/10 * * * *',
> cron_collision_policy='CANCEL_NEW',
> task = Task(
>   name="cron_hello_jing",
>   processes=[Process(name="hello_jing",
>cmdline="echo 'cron hello jing'")],
>   resources=Resources(cpu=1, ram=1*MB, disk=8*MB)
> )
>   )
> ]
> ```
> command aurora job inspect devcluster/www-data/devel/cron_hello_jing 
> /vagrant/cron_hello_world.aurora --write-json returns:
> ```
> {
>   "job": {
> "name": "cron_hello_jing",
> "role": "www-data",
> "cluster": "devcluster",
> "instances": "1",
> "cron": {
>   "schedule": "*/10 * * * *",
>   "policy": "CANCEL_NEW"
> },
> "service": false,
> "production": false
>   },
>   "task": {
> "name": "cron_hello_jing",
> "processes": [
>   {
> "name": "hello_jing",
> "daemon": false,
> "ephemeral": false,
> "final": false,
> "cmdline": [
>   "echo 'cron hello jing'"
> ]
>   }
> ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 53452: Log TaskInfo and Assigned Task on task startup.

2016-11-04 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53452/#review154900
---



@ReviewBot retry

- Stephan Erb


On Nov. 4, 2016, 1:52 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53452/
> ---
> 
> (Updated Nov. 4, 2016, 1:52 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1792
> https://issues.apache.org/jira/browse/AURORA-1792
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The executor logs `ExecutorInfo`, `FrameworkInfo`, `SlaveInfo` on startup. 
> This adds logging of `TaskInfo` and the Assigned Task object when it is 
> recieved.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> ce5ef680f01831cd89fced8969ae3246c7f60cfd 
> 
> Diff: https://reviews.apache.org/r/53452/diff/
> 
> 
> Testing
> ---
> 
> Launched a task in vagrant and checked the logs. Example output:
> 
> I1103 09:55:40.991879 24713 executor_base.py:45] Executor [None]: TaskInfo: 
> name: "www-data/prod/hello"
> task_id {
>   value: "www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
> }
> slave_id {
>   value: "d8988ce6-c900-49a1-897d-bc141f390394-S0"
> }
> resources {
>   name: "disk"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "*"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "aurora-role"
> }
> resources {
>   name: "cpus"
>   type: SCALAR
>   scalar {
> value: 0.5
>   }
>   role: "*"
> }
> resources {
>   name: "mem"
>   type: SCALAR
>   scalar {
> value: 128.0
>   }
>   role: "aurora-role"
> }
> executor {
>   executor_id {
> value: 
> "thermos-www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6"
>   }
>   resources {
> name: "cpus"
> type: SCALAR
> scalar {
>   value: 0.25
> }
> role: "*"
>   }
>   resources {
> name: "mem"
> type: SCALAR
> scalar {
>   value: 128.0
> }
> role: "aurora-role"
>   }
>   command {
> uris {
>   value: "/home/vagrant/aurora/dist/thermos_executor.pex"
>   executable: true
> }
> value: "${MESOS_SANDBOX=.}/thermos_executor.pex --announcer-ensemble 
> localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json 
> --mesos-containerizer-path=/usr/libexec/mesos/mesos-containerizer"
>   }
>   framework_id {
> value: "d8988ce6-c900-49a1-897d-bc141f390394-"
>   }
>   name: "AuroraExecutor"
>   source: "www-data.prod.hello.0"
>   labels {
> labels {
>   key: "source"
>   value: "www-data.prod.hello.0"
> }
>   }
> }
> data: 
> "\013\000\001\000\000\000:www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6\013\000\002\000\000\000\'d8988ce6-c900-49a1-897d-bc141f390394-S0\013\000\003\000\000\000\014192.168.33.7\014\000\004\002\000\007\001\004\000\010?\360\000\000\000\000\000\000\n\000\t\000\000\000\000\000\000\000\200\n\000\n\000\000\000\000\000\000\000\200\010\000\013\000\000\000\000\010\000\r\000\000\000\001\014\000\021\013\000\002\000\000\000\007vagrant\000\002\000\022\000\016\000\024\014\000\000\000\000\016\000\025\013\000\000\000\000\r\000\026\013\013\000\000\000\000\014\000\031\013\000\001\000\000\000\016AuroraExecutor\013\000\002\000\000\004\021{\"environment\":
>  \"prod\", \"health_check_config\": {\"initial_interval_secs\": 15.0, 
> \"health_checker\": {\"http\": {\"expected_response_code\": 0, \"endpoint\": 
> \"/health\", \"expected_response\": \"ok\"}}, \"interval_secs\": 10.0, 
> \"timeout_secs\": 1.0, \"max_consecutive_failures\": 0}, \"name\": \"hello\", 
> \"service\": true, \"max_task_failures
 \": 1, \"cron_collision_policy\": \"KILL_EXISTING\", \"enable_hooks\": false, 
\"cluster\": \"devcluster\", \"task\": {\"processes\": [{\"daemon\": false, 
\"name\": \"hello\", \"ephemeral\": false, \"max_failures\": 1, 
\"min_duration\": 5, \"cmdline\": \"\nwhile true; do\n  echo hello 
world\n  sleep 10\ndone\n  \", \"final\": false}], \"name\": \"hello\", 
\"finalization_wait\": 30, \"max_failures\": 1, \"max_concurrency\": 0, 
\"resources\": {\"gpu\": 0, \"disk\": 134217728, \"ram\": 134217728, \"cpu\": 
1.0}, \"constraints\": [{\"order\": [\"hello\"]}]}, \"production\": false, 
\"role\": \"www-data\", \"tier\": \"preemptible\", \"lifecycle\": {\"http\": 
{\"graceful_shutdown_endpoint\": \"/quitquitquit\", \"port\": \"health\", 
\"shutdown_endpoint\": \"/abortabortabort\"}}, \"priority\": 
0}\000\016\000\033\014\000\000\000\000\014\000\034\013\000\001\000\000\000\010www-data\013\000\002\000\000\000\004prod\013\000\003\000\000\000\005hello\000\014\000\035\014\000\001\017\000

Re: Review Request 52884: Document how to create a custom CLI build

2016-11-04 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review154890
---



The patch looks good and got signed off by a sufficient number of committers. I 
will therefore proceeed and merge it.

- Stephan Erb


On Oct. 14, 2016, 5:03 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> ---
> 
> (Updated Oct. 14, 2016, 5:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Document how to create a custom pex that you can use to put 
> deployment-specific customizations.
> 
> I think the dependency section needs some work, but I'm not an expert on 
> pants and how it resolves dependencies. Currently we just have the forked 
> sources in the same repo, so we can point directly to the OSS build target. I 
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left 
> to the user to make that dependency available in their repo. Can anyone help 
> fill out that section?
> 
> 
> Diffs
> -
> 
>   docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 
> 
> Diff: https://reviews.apache.org/r/52884/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 53418: Send SIGTERM to daemonized processes on shutdown.

2016-11-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53418/#review154876
---



Master (171a8f7) is red with this patch.
  ./build-support/jenkins/build.sh

  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/FieldGetters$1
  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
  Test coverage missing for 
org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
  Test coverage missing for 
org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
  Test coverage missing for 
org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
  Test coverage missing for 
org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory
  Test coverage missing for 
org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl
  Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
  Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroup
  Test coverage missing for 
org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
  Test coverage missing for 
org/apache/aurora/scheduler/updater/strategy/QueueStrategy
  Test coverage missing for 
org/apache/aurora/scheduler/offers/OfferManager$OfferManagerImpl$HostOffers$1
  Test coverage missing for org/apache/aurora/scheduler/offers/OfferSettings
  Test coverage missing for 
org/apache/aurora/scheduler/offers/RandomJitterReturnDelay
  Test coverage missing for 
org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
  Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
  Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
  Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$2
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/PreemptionProposal
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
  Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache
  Test coverage missing for 
org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
  Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
  Test coverage missing for org/apache/aurora/scheduler/events/Webhook
  Test coverage missing for 
org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
  Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
  Test coverage missing for 
org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
  Test coverage missing for 
org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

BUILD FAILED

Total time: 8 mins 9.065 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 3, 2016, 11:48 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53418/
> ---
> 
> (Updated Nov. 3, 2016, 11:48 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1808
> https://issues.apache.org/jira/browse/AURORA-1808
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> # Problem
> 
> Processes can deamonize and escape the supervision of a coordinator. Using 
> the Docker Containerizer or the Mesos Containerizer with pid isolation means 
> that the processes will be come reparented to the sh process that launches 
> the executor. For example:
> 
> ```
> root@aurora:/# ps xf
>   PID TTY  STAT   TIME COMMAND
>48 ?Ss 0:00 /bin/bash
>86 ?R+ 0:00  _ ps xf
> 1 ?Ss 0:00 /bin/sh -c ${MESOS_SANDBOX=.}/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/va
> 5 ?Sl 0:02 python2.7 /mnt/mesos/sandbox/thermos_executor.pex 
> --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config 
> /home/vagrant/aurora/examples/vag
>23 ?S  0:00  _ /usr/local/bin/python2.7 
> /mnt/mesos/sandbox/thermos_runner.pex 
>