Re: Review Request 56048: Preemption performance improvement and new metrics release notes entry

2017-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56048/#review163358 --- Master (a8afa59) is red with this patch. ./build-support/jenkins

Review Request 56048: Preemption performance improvement and new metrics release notes entry

2017-01-27 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56048/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description ---

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

2017-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review163351 --- Ship it! LGTM src/main/java/org/apache/aurora/scheduler/thrif

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163347 --- Ship it! LGTM src/main/java/org/apache/aurora/scheduler/confi

Re: Review Request 54883: Move snapshots into a separate log

2017-01-27 Thread Stephan Erb
> On Dec. 27, 2016, 11:50 p.m., Joshua Cohen wrote: > > Overall this looks good to me. I think some work would be required to > > productionize it (e.g. make it optional to start). Obviously want to vet > > this in a test cluster and we would need some doc changes to go with this > > and RELEA

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163338 --- Ship it! Master (a8afa59) is green with this patch. ./build-s

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

2017-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163335 --- @ReviewBot retry - Stephan Erb On Jan. 26, 2017, 4:16 p.m., Nic

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

2017-01-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163337 --- Wow I forgot I even submitted this! - Steve Niemitz On Dec. 15,

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

2017-01-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163334 --- Ship it! Ship It! - Joshua Cohen On Dec. 15, 2016, 5:48 p.m.

Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters

2017-01-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54754/#review163332 --- Ship it! Ship It! - Stephan Erb On Dec. 15, 2016, 6:48 p.m.,