Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-03-13 Thread Zameer Manji
> On March 11, 2017, 4:28 a.m., Stephan Erb wrote: > > I need a little bit more context to understand what is going on here: > > > > * Do you plan to use this with Thermos or an alternative executor? Or both? > > * It seems like we don't need this for Thermos as we already create > >

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review168855 --- Ship it! Master (2f08d91) is green with this patch.

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-03-13 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/ --- (Updated March 13, 2017, 6:57 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-03-13 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57524/#review168835 --- Ship it! As long as the change is behind the flag this change

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-03-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review168828 --- Ship it! Ship It! - Stephan Erb On March 13, 2017, 5:46

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review168784 --- Ship it! Master (a07b9ed) is green with this patch.

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-03-13 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/ --- (Updated March 13, 2017, 4:46 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/#review168775 --- Master (a07b9ed) is red with this patch.

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

2017-03-13 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56395/ --- (Updated March 13, 2017, 3:53 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-03-13 Thread Joshua Cohen
> On March 11, 2017, 12:28 p.m., Stephan Erb wrote: > > I need a little bit more context to understand what is going on here: > > > > * Do you plan to use this with Thermos or an alternative executor? Or both? > > * It seems like we don't need this for Thermos as we already create > >

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-03-13 Thread Mehrdad Nurolahzade
> On Feb. 15, 2017, 9:40 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > > Lines 134-135 (original), 134-135 (patched) > > > > > > Can you explain the