Re: Review Request 59699: Improve task history pruning by batch deleting tasks

> On June 1, 2017, 12:53 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Line 388 (original), 411 (patched) > > > > > > I'm not sure this is the right

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

> On June 1, 2017, 12:53 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Line 388 (original), 411 (patched) > > > > > > I'm not sure this is the right

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

> On June 1, 2017, 12:57 a.m., David McLaughlin wrote: > > Can you also provide metrics showing how much time is spent in the coalesce > > method? And show before/after results using the scale test? Sure. I will add some benchmarks for the task history pruning. - Kai

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

> On June 1, 2017, 12:53 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Line 388 (original), 411 (patched) > > > > > > I'm not sure this is the right

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176569 --- Ship it! Master (e76862a) is green with this patch.

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59699/#review176568 --- Can you also provide metrics showing how much time is spent in

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59699/#review176567 ---

Re: Review Request 59698: Allow custom OfferManager ordering to be injected via Guice modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59698/#review176565 --- Master (e76862a) is green with this patch.

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59699/#review176562 --- Master (e76862a) is green with this patch.

Review Request 59699: Improve task history pruning by batch deleting tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59699/ --- Review request for Aurora, David McLaughlin and Santhosh Kumar. Bugs:

Review Request 59698: Allow custom OfferManager ordering to be injected via Guice modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59698/ --- Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/ --- (Updated June 1, 2017, 12:02 a.m.) Review request for Aurora, David

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176555 --- This patch does not apply cleanly against master (e76862a), do

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/ --- (Updated May 31, 2017, 11:44 p.m.) Review request for Aurora, David

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176552 --- I support this idea. However, I need to resign from reviewing

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

> On May 31, 2017, 10:50 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 32 (patched) > > > > > > This is now slightly out of date. Fixed. > On May 31, 2017, 10:50 p.m., Stephan Erb wrote: > >

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59480/ --- (Updated May 31, 2017, 11:28 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59480/ --- (Updated May 31, 2017, 10:36 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59480/#review176540 --- Ship it! Master (d7425aa) is green with this patch.

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176538 --- Ship it! Shipt it! Please add a short entry to the

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

> On May 31, 2017, 12:13 a.m., Stephan Erb wrote: > > Thanks for the patch! That is an interesting idea. I am wondering if it is > > safe in all cases. For example, if I reduce the resource requirements while > > increasing the number of instances, my service could potentially breach his > >

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

> On May 26, 2017, 8:23 a.m., Stephan Erb wrote: > > I have thought about this in the past as well, and I am slightly skeptical > > if a simple sort by resources is a good approach when using > > oversubscription. Especially given the goal to run almost all > > (non-production) tasks as

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

> On May 24, 2017, 7:47 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 308 (patched) > > > > > > Not sure how practical this is but it would be nice for users

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59480/ --- (Updated May 31, 2017, 9:41 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176481 --- Ship it! +1 to adding the test cases that Josh suggested. -

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176452 --- Ship it! Ship It! - David McLaughlin On May 30, 2017, 9:21