Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/ --- (Updated June 13, 2017, 11:34 p.m.) Review request for Aurora, David

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177816 --- Ship it! Master (cb86e83) is green with this patch.

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177811 --- Ship it! Add an entry to the RELEASE-NOTES. - Santhosh Kumar

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

> On June 13, 2017, 11:30 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > > Lines 103 (patched) > > > > > > private? > > > > It is not being

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/ --- (Updated June 13, 2017, 9:40 p.m.) Review request for Aurora, David

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

> On June 8, 2017, 4:07 p.m., Stephan Erb wrote: > > Thanks for the nudge, sorry for the epic delay. > > > > I agree that it is valuable to have a mode that runs Aurora containers > > similar to other Mesos containers (as least until we support PODs). I am > > therefore OK with the direction

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

> On June 8, 2017, 4:07 p.m., Stephan Erb wrote: > > Thanks for the nudge, sorry for the epic delay. > > > > I agree that it is valuable to have a mode that runs Aurora containers > > similar to other Mesos containers (as least until we support PODs). I am > > therefore OK with the direction

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177785 --- Ship it! Master (cb86e83) is green with this patch.

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177769 --- LGTM. Minor comments.

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/ --- (Updated June 13, 2017, 6:21 p.m.) Review request for Aurora, David

Re: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59733/#review10 --- Ship it! Master (40d9d4d) is green with this patch.

Re: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59733/ --- (Updated June 13, 2017, 5:58 p.m.) Review request for Aurora, David

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

> On June 13, 2017, 2:24 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > > Lines 54 (patched) > > > > > > This seems clearer: > > > >

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

> On June 13, 2017, 2:24 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java > > Lines 54 (patched) > > > > > > This seems clearer: > > > >

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177756 --- src/main/java/org/apache/aurora/scheduler/events/Webhook.java

Re: Review Request 59940: Add a whitelist for TaskStateChange events in Webhook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59940/#review177740 --- Ship it! Just a small nit, otherwise LGTM.