Re: Review Request 63685: RFC: Use new scheduler UI as landing page

2017-11-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/#review190538 --- I agree with the direction, and i agree that we should try for a

Re: Review Request 63685: RFC: Use new scheduler UI as landing page

2017-11-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/#review190533 --- In general I think the spirit of this change makes sense, but as

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-08 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review190521 --- Overall the logic seems sound to me!

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review190519 --- Master (773d2d6) is red with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-08 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 9, 2017, 12:48 a.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63688: Fix tutorial test script

2017-11-08 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63688/#review190516 --- Ship it! Ship It! - Jordan Ly On Nov. 8, 2017, 11:58 p.m.,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-08 Thread David McLaughlin
> On Nov. 7, 2017, 11:36 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 38-42 (patched) > > > > > > On the other hand, this would be consistent from the

Re: Review Request 63688: Fix tutorial test script

2017-11-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63688/#review190514 --- Ship it! Master (5dfe51c) is green with this patch.

Review Request 63688: Fix tutorial test script

2017-11-08 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63688/ --- Review request for Aurora, Jordan Ly, Stephan Erb, and Bill Farner.

Re: Review Request 63685: RFC: Use new scheduler UI as landing page

2017-11-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/#review190503 --- Master (5dfe51c) is green with this patch.

Review Request 63685: RFC: Use new scheduler UI as landing page

2017-11-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Repository:

Re: Review Request 63670: Add a test for storage durability

2017-11-08 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63670/#review190462 --- Ship it!

Re: Review Request 63670: Add a test for storage durability

2017-11-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63670/#review190452 --- Ship it! Master (5dfe51c) is green with this patch.

Review Request 63670: Add a test for storage durability

2017-11-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63670/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-11-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review190449 --- Ship it! Master (5dfe51c) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-11-08 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Nov. 8, 2017, 2:37 p.m.) Review request for Aurora, Joshua Cohen,