Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Bill Farner
> On Nov. 13, 2017, 8:05 a.m., Bill Farner wrote: > > Stephan - FYI, i reproduce the build error: > > ``` > > Exception message: Could not satisfy all requirements for > > mesos.executor==1.4.0: > > mesos.executor==1.4.0 > > ``` > > Stephan Erb wrote: > Interesting. Does it go away

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/#review190910 --- Ship it! Master (fb64df2) is green with this patch.

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/ --- (Updated Nov. 13, 2017, 11:58 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Jordan Ly
> On Nov. 13, 2017, 9:43 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > > Line 335 (original), 337 (patched) > > > > > > Can we get away with

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Bill Farner
> On Nov. 13, 2017, 1:43 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > > Line 335 (original), 337 (patched) > > > > > > Can we get away with

Re: Review Request 63744: Remove LockStore

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/#review190895 --- Ship it! Master (bd12188) is green with this patch.

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Jordan Ly
> On Nov. 13, 2017, 9:43 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > > Line 335 (original), 337 (patched) > > > > > > Can we get away with

Re: Review Request 63744: Remove LockStore

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/#review190891 --- @ReviewBot retry The 'Depends on' field is now blank, not sure

Re: Review Request 63744: Remove LockStore

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63744/#review190890 --- This patch does not apply cleanly against RB#63743 (e0624b2), do

Re: Review Request 63760: Make testTaskChangedWithOldStateError more robust

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63760/#review190889 --- Ship it! Master (e0624b2) is green with this patch.

Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/#review190886 ---

Re: Review Request 63743: Remove the internal SQL database

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190883 --- Master (e0624b2) is green with this patch.

Re: Review Request 63760: Make testTaskChangedWithOldStateError more robust

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63760/#review190882 --- @ReviewBot retry Interesting that this failed in the same spot.

Re: Review Request 63743: Remove the internal SQL database

2017-11-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190879 --- Ship it! Ship It! - David McLaughlin On Nov. 11, 2017, 4:53

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Stephan Erb
> On Nov. 13, 2017, 5:05 p.m., Bill Farner wrote: > > Stephan - FYI, i reproduce the build error: > > ``` > > Exception message: Could not satisfy all requirements for > > mesos.executor==1.4.0: > > mesos.executor==1.4.0 > > ``` Interesting. Does it go away after a `./pants clean-all`? -

Review Request 63763: Fix flaky MesosCallbackHandlerTest

2017-11-13 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review190859 --- Master (e0624b2) is red with this patch.

Re: Review Request 63746: Add a workaround for test_du_diskcollector failing on macOS

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63746/#review190857 --- Ship it! Master (e0624b2) is green with this patch.

Re: Review Request 63746: Add a workaround for test_du_diskcollector failing on macOS

2017-11-13 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63746/#review190854 --- Ship it! Ship It! - Reza Motamedi On Nov. 12, 2017, 8:14

Re: Review Request 63743: Remove the internal SQL database

2017-11-13 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63743/#review190845 --- Ship it! Ship It! - Jordan Ly On Nov. 11, 2017, 4:53 a.m.,

Re: Review Request 63760: Make testTaskChangedWithOldStateError more robust

2017-11-13 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63760/#review190844 --- Ship it! Nice fix! - Jordan Ly On Nov. 13, 2017, 4:32 p.m.,

Review Request 63760: Make testTaskChangedWithOldStateError more robust

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63760/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 63746: Add a workaround for test_du_diskcollector failing on macOS

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63746/#review190825 --- @ReviewBot retry 2/2 on failing

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review190822 --- Stephan - FYI, i reproduce the build error: ``` Exception

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review190812 --- @ReviewBot retry - Stephan Erb On Nov. 13, 2017, 11:35 a.m.,

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review190808 --- Master (e0624b2) is red with this patch.

Re: Review Request 63750: pants for high-sierra

2017-11-13 Thread se choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/ --- (Updated 11월 13, 2017, 7:35 오후) Review request for Aurora. Repository: