Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-11-16 Thread Jason Lai
> On Nov. 2, 2017, 9:38 p.m., Mohit Jaggi wrote: > > Folks, Is this going to get committed? > > Stephan Erb wrote: > I believe this breaks a few things when enabled (e.g. user creation). I > will need to take a closer look next week. > > Jason Lai wrote: > Thanks for the reply. We

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread David McLaughlin
> On Nov. 16, 2017, 10:01 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > > Lines 209 (patched) > > > > > > I suggest keeping this as a valid transition and

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191261 --- Ship it! Master (46b1112) is green with this patch.

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread David McLaughlin
> On Nov. 16, 2017, 10:22 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 90-91 (patched) > > > > > > Can this just be: > > ``` > > if

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/ --- (Updated Nov. 16, 2017, 10:30 p.m.) Review request for Aurora, Jordan Ly,

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191256 --- Fix it, then Ship it! Overall LGTM! You may want to add some

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review191229 --- Fix it, then Ship it! Looks great overall! The e2e test is

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review191237 --- Ship it! Master (46b1112) is green with this patch.

Re: Review Request 63750: pants for high-sierra

2017-11-16 Thread Bill Farner
> On Nov. 14, 2017, 4:13 p.m., Aurora ReviewBot wrote: > > Master (4fecf1f) is red with this patch. > > ./build-support/jenkins/build.sh > > > > WARN] > >

Re: Review Request 63884: Idempotent Ops and slimmed API for JobUpdateStore

2017-11-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63884/#review191206 --- Annotated the diff with some reviewer notes.

Re: Review Request 63871: Improve Vagrant setup with vagrant-hostmanager

2017-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63871/#review191167 --- Ship it! Master (46b1112) is green with this patch.

Re: Review Request 63871: Improve Vagrant setup with vagrant-hostmanager

2017-11-16 Thread Rogier Dikkes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63871/ --- (Updated Nov. 16, 2017, 10:05 a.m.) Review request for Aurora. Changes

Review Request 63871: Improve Vagrant setup with vagrant-hostmanager

2017-11-16 Thread Rogier Dikkes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63871/ --- Review request for Aurora. Repository: aurora Description --- Improve