Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191993 --- Master (21af250) is green with this patch.

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191992 --- Ship it! Ship It! - David McLaughlin On Nov. 27, 2017, 7:41

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191984 --- @ReviewBot retry - Jordan Ly On Nov. 27, 2017, 7:41 p.m.,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 12:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191956 --- Master (0f3dc93) is red with this patch.

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191940 --- @ReviewBot retry - Jordan Ly On Nov. 27, 2017, 7:41 p.m.,

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191938 --- Master (0f3dc93) is red with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 8:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 12:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review191931 --- Ship it! Sharing my own check on backwards compatibility -

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191928 --- Ship it! Ship It! - Bill Farner On Nov. 27, 2017, 11:41

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

> On Nov. 20, 2017, 7:55 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java > > Line 52 (original) > > > > > > Note for reviewers: this was causing some tests to fail

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/ --- (Updated Nov. 27, 2017, 7:41 p.m.) Review request for Aurora, David

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

> On Nov. 27, 2017, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/OfferRanker.java > > Lines 39 (patched) > > > > > > Nit with potentially far-reaching implications for naming

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191918 ---

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191913 --- Master (0f3dc93) is green with this patch.

Re: Review Request 63973: Enable custom offer scoring modules for task assignment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/ --- (Updated Nov. 27, 2017, 6:04 p.m.) Review request for Aurora, David

Re: Review Request 63973: Enable custom offer scoring modules for task assignment and injecting of custom OfferManagers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63973/#review191872 --- Master (0f3dc93) is red with this patch.