Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192446 --- Ship it! Master (de8b375) is green with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192444 --- @ReviewBot retry - Bill Farner On Nov. 30, 2017, 4:32 p.m.,

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192443 --- Master (de8b375) is red with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

> On Nov. 30, 2017, 5:17 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/TransactionRecorder.java > > Lines 55 (patched) > > > > > > seems sufficiently complex to warrant

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192438 --- Ship it! Master (de8b375) is green with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192416 --- Only had a quick look but I really like the abstractions created

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192418 --- Ship it! LGTM! This is a lot easier to reason about than the

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192415 --- Reviewer notes.

Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.

Re: Review Request 64126: Add a key-value backed StreamManager implementation

> On Nov. 30, 2017, 9:29 a.m., Bill Farner wrote: > > I have an alternative approach to pose based on learnings from this patch - > > using a DBMS as a key-value document store. This could be ~2 levels of > > abstraction higher and involve implementing `Storage` rather than > >

Re: Review Request 64126: Add a key-value backed StreamManager implementation

> On Nov. 30, 2017, 6:29 p.m., Bill Farner wrote: > > I have an alternative approach to pose based on learnings from this patch - > > using a DBMS as a key-value document store. This could be ~2 levels of > > abstraction higher and involve implementing `Storage` rather than > >

Re: Review Request 64190: Moved `HostOffer` to `offers` package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64190/#review192383 --- Ship it! Ship It! - Stephan Erb On Nov. 30, 2017, 1:59

Re: Review Request 64190: Moved `HostOffer` to `offers` package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64190/#review192354 --- Ship it! Master (284f40f) is green with this patch.

Re: Review Request 64126: Add a key-value backed StreamManager implementation

> On Nov. 30, 2017, 5:29 p.m., Bill Farner wrote: > > I have an alternative approach to pose based on learnings from this patch - > > using a DBMS as a key-value document store. This could be ~2 levels of > > abstraction higher and involve implementing `Storage` rather than > >

Re: Review Request 64126: Add a key-value backed StreamManager implementation

> On Nov. 30, 2017, 5:29 p.m., Bill Farner wrote: > > I have an alternative approach to pose based on learnings from this patch - > > using a DBMS as a key-value document store. This could be ~2 levels of > > abstraction higher and involve implementing `Storage` rather than > >

Re: Review Request 64190: Moved `HostOffer` to `offers` package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64190/#review192328 --- Ship it! Ship It! - Renan DelValle On Nov. 29, 2017, 4:59

Re: Review Request 64126: Add a key-value backed StreamManager implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64126/#review192310 --- I have an alternative approach to pose based on learnings from