Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192808 --- Ship it! Master (a0628ef) is green with this patch.

Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192756 --- Ship it! Master (a0628ef) is green with this patch.

Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/ --- (Updated Dec. 4, 2017, 12:09 p.m.) Review request for Aurora, David

Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Bill Farner
> On Dec. 4, 2017, 10:40 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistence.java > > Lines 73 (patched) > > > > > > Can this just be `DataSource dataSource` since we're

Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Bill Farner
> On Dec. 3, 2017, 6:29 p.m., David McLaughlin wrote: > > Do we have any idea how this performs at scale? I'd like to avoid repeating > > the MyBatis work, where we delayed the scale testing until after we had > > committed a bunch of patches. A fair concern! Until i can perform a more

Re: Review Request 64288: Add a SQL persistence implementation

2017-12-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64288/#review192722 --- Just took a quick peek at this, a couple of drive by questions...

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

2017-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review192699 --- Master (89338dd) is red with this patch.

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

2017-12-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 4, 2017, 8:23 a.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

2017-12-04 Thread John Sirois
> On Dec. 4, 2017, 12:51 a.m., Aurora ReviewBot wrote: > > Master (89338dd) is red with this patch. > > ./build-support/jenkins/build.sh > > > > INFO] Reached consecutive success limit. > > INFO] Reached consecutive success limit. > >