Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/#review193047 --- Ship it! Master (2754636) is green with this patch.

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/#review193043 --- @ReviewBot retry - Bill Farner On Dec. 6, 2017, 6:31 a.m.,

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/#review193004 --- Master (e74fb32) is red with this patch.

Re: Review Request 64377: Remove H2-related end-to-end test case

2017-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64377/#review193003 --- Ship it! Master (e74fb32) is green with this patch.

Re: Review Request 64382: Update Python deps incl requests and pex

2017-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64382/#review193001 --- Master (e74fb32) is green with this patch.

Review Request 64382: Update Python deps incl requests and pex

2017-12-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64382/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 64377: Remove H2-related end-to-end test case

2017-12-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64377/#review192992 --- Ship it! Ship It! - Stephan Erb On Dec. 6, 2017, 3:42 p.m.,

Review Request 64377: Remove H2-related end-to-end test case

2017-12-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64377/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/ --- (Updated Dec. 6, 2017, 6:31 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Bill Farner
> On Dec. 6, 2017, 4:22 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java > > Line 211 (original), 218 (patched) > > > > > > To fail or to pass?

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

2017-12-06 Thread Stephan Erb
> On Dec. 5, 2017, 9:46 p.m., John Sirois wrote: > > I've got the needed fix out here: > > https://github.com/pantsbuild/pants/pull/5168 > > This will be available with the Pants 1.4.0.dev23 release this Friday. Thanks a lot for looking into this! Als thanks for the many improvements you

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/#review192977 --- Ship it! Wow, pretty nice! I feel your pain. I also tried

Re: Review Request 64362: Update to guice 4.1.0, switch from jersey to resteasy

2017-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64362/#review192971 --- Ship it! Master (e74fb32) is green with this patch.