Re: Review Request 64290: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193326 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: >

Re: Review Request 64290: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 8, 2017, 10:16 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193323 --- @ReviewBot retry - John Sirois On Dec. 8, 2017, 8:47 p.m.,

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193319 --- Master (4f0299b) is red with this patch.

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193321 --- @ReviewBot retry - John Sirois On Dec. 8, 2017, 8:47 p.m.,

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

> On Dec. 8, 2017, 9:09 p.m., Aurora ReviewBot wrote: > > Master (4f0299b) is red with this patch. > > ./build-support/jenkins/build.sh > > > >SUCCESS > > > > 04:09:45 00:00 [main] > >(To run a reporting server: ./pants server) > > 04:09:45 00:00 [setup] > >

Re: Review Request 64290: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 8, 2017, 8:47 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

> On Dec. 8, 2017, 6:18 p.m., Bill Farner wrote: > > Ship It! > BEFORE MERGING: what is the rollback story for updates? If we upgrade to 0.20 > and then revert to 0.19, there will be no locks for in-progress updates. Will > this be an issue or was saving locks essentially a no-op before?

Re: Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64459/#review193313 --- Ship it! Ship It! - Bill Farner On Dec. 8, 2017, 12:08

Re: Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

> On Dec. 9, 2017, 12:13 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java > > Line 294 (original), 300 (patched) > > > > > > Did the recovery with a

Re: Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64459/#review193287 ---

Re: Review Request 64286: Recover snapshots via the Op stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64286/#review193211 ---

Re: Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64459/#review193277 --- Ship it! Master (6c897e5) is green with this patch.

Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64459/ --- Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.