Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review202718 --- Master (805a53f) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 8, 2018, 4:30 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > > Lines 110 (patched) > > > > > > I'm wondering if defaultSlaPolicy needs to be

Re: Review Request 66192: [WIP] Variable group size updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/ --- (Updated May 8, 2018, 4:26 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 8, 2018, 9:30 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceModule.java > > Lines 35 (patched) > > > > > > Missing javadoc. Done. > On May 8, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202665 --- Ship it! Master (805a53f) is green with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202652 --- Looks good, mostly minor feedback.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202657 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 8, 2018,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202651 --- Master (805a53f) is red with this patch.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 8, 2018, 8:49 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 3, 2018, 10:43 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > > Lines 144-150 (patched) > > > > > > If bound in a private module, you don't need to

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 7, 2018, 2:12 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/SlaManager.java > > Lines 124-130 (patched) > > > > > > I believe that you will want to only look at the lastest task

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

> On May 3, 2018, 3:26 p.m., Reza Motamedi wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 248 (patched) > > > > > > Should the comment be updated to match the struct in resolution? > >

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/ --- (Updated May 8, 2018, 8:28 a.m.) Review request for Aurora, David McLaughlin,