---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78109
---
@ReviewBot retry
- Kevin Sweeney
On March 27, 2015, 12:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78075
---
On March 26, 2015, 6:23 p.m., Kevin Sweeney wrote
Thanks,
Kevin Sweeney
gradle daemon in Vagrant.
Diffs
-
examples/vagrant/provision-dev-cluster.sh
ae500436e703140065e5c16fc0e38dbe3214e69f
Diff: https://reviews.apache.org/r/32554/diff/
Testing
---
Sped up Kerberos integration testing.
Thanks,
Kevin Sweeney
/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33403/#review81028
---
Ship it!
LGTM if e2e tests pass
- Kevin Sweeney
On April 21
16f2da5207ce2a3f866fa3a51c02c11d1b58a439
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
781cf5add1555187757a0254a96f201bc74a1e27
Diff: https://reviews.apache.org/r/33411/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
testfile
-rw-r--r-- 1 ksweeney staff 200 Apr 22 15:40 testfile
```
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/#review80795
---
Ship it!
Ship It!
- Kevin Sweeney
On April 20, 2015, 12:17 p.m
will behave
sanely when we flip frameworkInfo.checkpoint from false to true (as everyone
who has been using the defaults in 0.7.0 will encounter when they attempt to
upgrade to 0.8.0)?
- Kevin Sweeney
On April 29, 2015, 8:04 a.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33659/#review82043
---
Ship it!
Ship It!
- Kevin Sweeney
On April 29, 2015, 2:36 p.m
---
On April 27, 2015, 4:16 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33537/
---
(Updated April 27, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82405
---
Ship it!
Ship It!
- Kevin Sweeney
On April 30, 2015, 5:12 p.m
://reviews.apache.org/r/33537/diff/
Testing
---
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33969/#review82973
---
Ship it!
Ship It!
- Kevin Sweeney
On May 7, 2015, 8:30 p.m
key from the summary -
it's already filled into the Bugs Closed section by rbt.
- Kevin Sweeney
On May 7, 2015, 7:42 p.m., Jake Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33950/#review82902
---
Ship it!
Ship It!
- Kevin Sweeney
On May 7, 2015, 1:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33920/#review82764
---
Ship it!
Ship It!
- Kevin Sweeney
On May 6, 2015, 4:06 p.m
/33819/diff/
Testing
---
vagrant up
Waiting on results of e2e test.
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33784/#review82549
---
Ship it!
Ship It!
- Kevin Sweeney
On May 2, 2015, 11:58 a.m
(3, 'a')
f.write(100 * 'a')
f.flush()
% echo -n '' testfile
f.write(200 * 'b')
f.flush()
% ls -l testfile
-rw-r--r-- 1 ksweeney staff 200 Apr 22 15:40 testfile
```
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33455/#review83244
---
ping, Brian
- Kevin Sweeney
On April 22, 2015, 3:47 p.m., Kevin
/DbModule.java
https://reviews.apache.org/r/34046/#comment134142
Link to upstream ticket would be good here.
- Kevin Sweeney
On May 11, 2015, 10:58 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
://reviews.apache.org/r/33612/#comment134458
isSet
- Kevin Sweeney
On May 9, 2015, 10:53 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33612
/DbModule.java
https://reviews.apache.org/r/33612/#comment134494
module
- Kevin Sweeney
On May 12, 2015, 2:17 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33612
://reviews.apache.org/r/34126/#comment134511
comment is a lie now, but it seems safe to remove as the
update-alternatives line is self-explanatory
- Kevin Sweeney
On May 12, 2015, 3:54 p.m., Bill Farner wrote:
---
This is an automatically
99648e46ca755c3c8e22d90c7b682107d8dee333
Diff: https://reviews.apache.org/r/34307/diff/
Testing
---
./pants test.pytest --no-fast src/test/python:all
Thanks,
Kevin Sweeney
/pants_requirements.txt 0c20aaf60e6a5e069f5a28d9cbe8826f869e28f4
pants.ini 99648e46ca755c3c8e22d90c7b682107d8dee333
Diff: https://reviews.apache.org/r/34307/diff/
Testing (updated)
---
./pants test.pytest --no-fast src/test/python:all
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kevin
this as fixing
https://issues.apache.org/jira/browse/AURORA-1318 as well, as this patch
obseletes my work there investigating a wild guess about task deepCopy
performance.
- Kevin Sweeney
On May 15, 2015, 5:23 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33279/#review80409
---
Ship it!
Ship It!
- Kevin Sweeney
On April 16, 2015, 3 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33273/#review80412
---
Ship it!
Ship It!
- Kevin Sweeney
On April 16, 2015, 2:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33026/#review79540
---
Ship it!
Ship It!
- Kevin Sweeney
On April 9, 2015, 11:03 a.m
/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
---
On March 27, 2015, 1:50 p.m., Kevin Sweeney wrote
/aop/AopModuleTest.java
d20c9da3c4944ec8c50fe8d48b7e459ff1c7082b
Diff: https://reviews.apache.org/r/32329/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
step for developers.
Kevin Sweeney wrote:
Done, but that script appears to be broken on master.
This was transient - the script works. Reviewers please validate that the e2e
test passes in your environ,ent.
- Kevin
consider using a mock instance of AuthBase here and elsewhere in this file
- future readers might be confused as this is not a legal input type
- Kevin Sweeney
On April 1, 2015, 12:53 p.m., Maxim Khutornenko wrote
://reviews.apache.org/r/34300/#comment138805
Why set this at all? Does the scheduler read this field?
- Kevin Sweeney
On June 1, 2015, 11:05 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit
/http/api/security/shiro-malformed-no-sections.ini
PRE-CREATION
Diff: https://reviews.apache.org/r/35219/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
://reviews.apache.org/r/34566/#comment138774
Use a MediaType constant here.
- Kevin Sweeney
On June 4, 2015, 12:31 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34566
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34570/#review84837
---
On May 21, 2015, 4:28 p.m., Kevin Sweeney wrote
LIBPROCESS_PORT LIBPROCES_IP
```
packaging/rpm/aurora.sysconfig
https://reviews.apache.org/r/33778/#comment139596
Is this needed? This is the default right?
- Kevin Sweeney
On May 19, 2015, 9:19 a.m., Steve Salevan wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34661/#review87280
---
Ship it!
Ship It!
- Kevin Sweeney
On June 8, 2015, 11:40 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89257
---
On June 24, 2015, 2:52 p.m., Kevin Sweeney wrote
/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
/SchedulerThriftInterfaceTest.java
38ef412a6d29dfef7b305e00cf44522818303965
Diff: https://reviews.apache.org/r/35842/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
/MetricCalculator.java (lines 129
- 130)
https://reviews.apache.org/r/35498/#comment141980
Add getters for these fields and access them below via the getters rather
than direct field access.
- Kevin Sweeney
On June 24, 2015, 12:09 p.m., Stephan Erb wrote
)
https://reviews.apache.org/r/35847/#comment141844
Convention is to not capitalize acronyms like HTTP, but to render them as
Http (here and below).
- Kevin Sweeney
On June 24, 2015, 2:55 p.m., Brian Wickman wrote
/util/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/config/thrift.py, line 218
https://reviews.apache.org/r/34300/diff/3/?file=975774#file975774line218
Why set this at all? Does the scheduler read this field?
Brian Wickman wrote:
it is not. i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89531
---
Ship it!
Ship It!
- Kevin Sweeney
On June 26, 2015, 10:50 a.m
/35627/diff/
Testing
---
Ran kerberos e2e test and verified audit messages in UI.
Thanks,
Kevin Sweeney
/UnsecureSessionContextTest.java
0a842cb9cdd266690b2d3103126e831fe07b1735
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
4d6043a402a761fe44239e33b83c1c8872fe7068
Diff: https://reviews.apache.org/r/35627/diff/
Testing
---
Ran kerberos e2e test.
Thanks,
Kevin Sweeney
/
Testing
---
Ran kerberos e2e test.
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88464
---
Ship it!
Ship It!
- Kevin Sweeney
On June 18, 2015, 3:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/#review88465
---
Ship it!
Ship It!
- Kevin Sweeney
On June 18, 2015, 4:15 p.m
On June 23, 2015, 5:31 p.m., Brian Wickman wrote:
slightly overzealous deleting. the thermos gc stuff should still be part
of the thermos toolchain.
Maxim Khutornenko wrote:
Should not we rather rely on task reconciliation to do any cleanup
instead? Force GCing a task does not
build
Thanks,
Kevin Sweeney
Diff: https://reviews.apache.org/r/35535/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
://reviews.apache.org/r/32973/#comment140417
s/it's/its/
- Kevin Sweeney
On June 12, 2015, 4:11 a.m., Brian Brazil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35483/#review88011
---
Ship it!
Ship It!
- Kevin Sweeney
On June 15, 2015, 5:27 p.m
/TaskReconciler.java
https://reviews.apache.org/r/34733/#comment136996
Move this validation to the constructor so that it will halt injector
creation.
- Kevin Sweeney
On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34501/#review85449
---
Ship it!
Ship It!
- Kevin Sweeney
On May 22, 2015, 5:31 p.m
to use slaveID instead
of hostName as the canonical identifier for mesos slaves within aurora?
- Kevin Sweeney
On July 1, 2015, 1:01 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36220/#review90580
---
Ship it!
Ship It!
- Kevin Sweeney
On July 6, 2015, 2:37 p.m
/LeaderRedirectFilter.java (line
46)
https://reviews.apache.org/r/36064/#comment143178
Use the `HttpHeaders.LOCATION` constant here instead.
- Kevin Sweeney
On June 30, 2015, 1:44 p.m., Stephan Erb wrote:
---
This is an automatically
in the mock documentation for this
use
case](https://docs.python.org/3/library/unittest.mock-examples.html#more-complex-argument-matching).
./pants test.pytest --no-fast src/test/python::
Thanks,
Kevin Sweeney
On May 21, 2015, 4:34 p.m., Kevin Sweeney wrote:
Have you investigated using the [Console
Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we
can use the Shiro filter directly and avoid adding another mechanism to
configure security as well as avoid adding
of a config
change.
I think you need to add logic to make sure that every task has an executor
that's acceptible to the system at startup.
- Kevin Sweeney
On Aug. 17, 2015, 11:10 p.m., Renan DelValle wrote:
---
This is an automatically
Missing license header. Consider tooling to automated adding the standard
apache one and removing the twitter one.
commons-args/src/main/java/com/twitter/common/args/VerifierFor.java (line 1)
https://reviews.apache.org/r/37666/#comment151242
Missing license header
- Kevin Sweeney
On Aug. 20
On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote:
build-support/python/make-mesos-native-egg, line 119
https://reviews.apache.org/r/37379/diff/1/?file=1038066#file1038066line119
HTTPS?
Maxim Khutornenko wrote:
No htts endpoint exists. This hangs forever
reference a blob-link just reference docs/getting-started.md -
the NEWS file is in the same repo.
- Kevin Sweeney
On Aug. 17, 2015, 11:37 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
On Aug. 13, 2015, 4:53 p.m., Kevin Sweeney wrote:
src/test/sh/org/apache/aurora/e2e/Dockerfile, line 18
https://reviews.apache.org/r/37379/diff/1/?file=1038072#file1038072line18
Is this documented upstream or just because we use libcurl4-nss-dev in
the egg builder script? Either
---
Fix terminology in cron docs.
Diffs
-
docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220
Diff: https://reviews.apache.org/r/36015/diff/
Testing
---
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93731
---
On July 31, 2015, 11:03 a.m., Kevin Sweeney wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93722
---
On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote
environment for the debian package or the spec file.
Thanks,
Kevin Sweeney
checked that `thermos status` works.
I don't have a test environment for the debian package or the spec file.
Thanks,
Kevin Sweeney
---
On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972
/test_kerberos_end_to_end.sh
760997c8420e9e430912de406cef494a9118897a
Diff: https://reviews.apache.org/r/36998/diff/
Testing
---
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Kevin Sweeney
Thanks,
Kevin Sweeney
)
---
./pants test.pytest --no-fast src/test/python::
./build-support/python/make-python-sdists
E2E test gets as far as it usually does.
Manually checked that `thermos status` works.
I don't have a test environment for the debian package or the spec file.
Thanks,
Kevin Sweeney
or the spec file.
Thanks,
Kevin Sweeney
/ as appropriate.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93793
---
On July 31, 2015, 3:30 p.m., Kevin Sweeney wrote
status` works.
I don't have a test environment for the debian package or the spec file.
Documentation pushed to
https://github.com/kevints/aurora/blob/36972/docs/build-system.md
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93805
---
On July 31, 2015, 4:18 p.m., Kevin Sweeney wrote
.
Documentation pushed to
https://github.com/kevints/aurora/blob/36972/docs/build-system.md
Thanks,
Kevin Sweeney
--no-fast src/test/python::
./build-support/python/make-python-sdists
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Manually checked that `thermos status` works.
I don't have a test environment for the debian package or the spec file.
Thanks,
Kevin Sweeney
that `thermos status` works.
I don't have a test environment for the debian package or the spec file.
Thanks,
Kevin Sweeney
?) should contain aurora executor, thermos cli, thermos
observer and thermos runner.
Kevin Sweeney wrote:
I like this suggestion and would like to refactor the code to fit it into
this framework. Would you accept that in a follow-up review?
Specifically there would then be 3 top
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36945/#review93615
---
Ship it!
Ship It!
- Kevin Sweeney
On July 30, 2015, 9:13 a.m
upstream or just because we use libcurl4-nss-dev in the
egg builder script? Either way you can install just libcurl4-nss rather than
the -dev version of the package.
- Kevin Sweeney
On Aug. 11, 2015, 9:58 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95332
---
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 13, 2015, 2:25 p.m
. They're only useful for when you
install the sdists via pip or pex directly. Instead we always build pex
binaries using pants which delegates to the python_binary target.
Kevin Sweeney wrote:
I answered someone's question in IRC with a gist ~2yrs ago
https://gist.github.com/kevints
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36700/#review93209
---
Ship it!
Ship It!
- Kevin Sweeney
On July 27, 2015, 5:58 p.m
Description
---
Fix typo in scheduler deployment documentation
The command should be run on schedulers, not masters.
Diffs
-
docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d
Diff: https://reviews.apache.org/r/36874/diff/
Testing
---
Thanks,
Kevin Sweeney
://reviews.apache.org/r/36700/#comment146861
Can you delete the code these targets reference as well, as presumably
there are now source files without BUILD file owners in our tree
- Kevin Sweeney
On July 22, 2015, 11:50 a.m., Bill Farner wrote
binaries using pants which delegates to the python_binary target.
Kevin Sweeney wrote:
I answered someone's question in IRC with a gist ~2yrs ago
https://gist.github.com/kevints/8361414 so it does seem likely these are
used in practice. Okay with removing them but a NEWS entry would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36797/#review92997
---
@ReviewBot retry
- Kevin Sweeney
On July 24, 2015, 2:38 p.m
1 - 100 of 162 matches
Mail list logo
