Re: Review Request 42445: Upgrade pants to 0.0.68.

2016-01-19 Thread Joe Smith
ws.apache.org/r/42445/ > --- > > (Updated Jan. 17, 2016, 3:42 p.m.) > > > Review request for Aurora, Joe Smith and Stephan Erb. > > > Repository: aurora > > > Description > --- > > This is the regular

Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread Joe Smith
pants bootstrap script to be agnostic to sed version Diffs - pants 47097994b1044202aa0d8ce6afb8c2dee2a4c27c Diff: https://reviews.apache.org/r/40204/diff/ Testing --- Thanks, Joe Smith

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

2015-11-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105973 --- Ship it! Thanks again John! - Joe Smith On Nov. 10, 2015, 1:50

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-30 Thread Joe Smith
This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Oct. 29, 2015, 3:05 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer

Review Request 38504: Re-add Health Check to the Scheduler

2015-09-18 Thread Joe Smith
/test_end_to_end.sh 1eec20cca5340f01ec2b45ef22d7e1c33e74ca3f Diff: https://reviews.apache.org/r/38504/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh and ``` vagrant@aurora:~$ curl -sL -w '%{http_code}' localhost:8081/health -o /dev/null; echo 200 ``` Thanks, Joe

Review Request 38510: Maintain compatibility with Health Handler before javax refactor

2015-09-18 Thread Joe Smith
localhost:8081/health OK vagrant@aurora:~$ ``` Thanks, Joe Smith

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99312 ------- On Sept. 16, 2015, 2:53 p.m., Joe Smith wrote: > > --- > This is an automatically ge

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
--- `./gradlew build -Pq` Thanks, Joe Smith

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
g numeric properties into Longs? > > Shouldn't we just export all the keys as Strings into the stat system? Cool, done. It's also now `<String, String>` - Joe --- This is an automatically generated e-mail

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-16 Thread Joe Smith
build -Pq` Thanks, Joe Smith

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-16 Thread Joe Smith
> > > Revert Done - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99123 ------- On Sep

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-16 Thread Joe Smith
oger, thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99132 --- On Sept. 14, 2015, 11:46

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-14 Thread Joe Smith
build -Pq` Thanks, Joe Smith

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-14 Thread Joe Smith
> <https://reviews.apache.org/r/38280/diff/2/?file=1068931#file1068931line95> > > > > If you like the previous comment, i believe this can disappear. Done. - Joe --- This is an automatically generated e-mail

Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98516 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2015, 4:19 p.m

Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-10 Thread Joe Smith
/SnapshotStoreImplTest.java 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 Diff: https://reviews.apache.org/r/38280/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith

Re: Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6

2015-09-10 Thread Joe Smith
ep 10 && /etc/init.d/thermos-observer start'" specs/rpm/aurora.spec (line 349) <https://reviews.apache.org/r/38210/#comment154959> This should constitute a -2, right? - Joe Smith On Sept. 8, 2015, 11:56 p.m., Steve Salevan wrote: > >

Review Request 37964: Allow for slashes in metric names

2015-08-31 Thread Joe Smith
/StatsTest.java 91bbc096748952cc7dbf0cbd83a2d95456e0ce0a Diff: https://reviews.apache.org/r/37964/diff/ Testing --- ``` [tw-mbp-jsmith aurora (stats-slashes)]$ ./gradlew build -Pq # snip BUILD SUCCESSFUL ``` Thanks, Joe Smith

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
and discard this. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
-Pq Thanks, Joe Smith

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith

Re: Review Request 34020: Normalize SLA stat names

2015-07-30 Thread Joe Smith
/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith

Re: Review Request 34020: Normalize SLA stat names

2015-07-30 Thread Joe Smith
--- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015

Re: Review Request 34020: Normalize SLA stat names

2015-07-30 Thread Joe Smith
, visit: https://reviews.apache.org/r/34020/#review90933 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.

2015-07-30 Thread Joe Smith
. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-15 Thread Joe Smith
/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-15 Thread Joe Smith
--- On July 14, 2015, 5:30 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 14, 2015, 5:30

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-15 Thread Joe Smith
dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91790 --- On July 15, 2015, 11:08 a.m., Joe Smith wrote: --- This is an automatically

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-14 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91645 --- On July 13, 2015, 4:10 p.m., Joe Smith wrote

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-14 Thread Joe Smith
dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Joe Smith
you think!) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91416 --- On July 12, 2015, 11:49 a.m., Joe Smith wrote

Re: Review Request 35580: Fix symlink duplicates from MesosPathDetector.

2015-06-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/#review88278 --- Ship it! +1 on test coverage too - Joe Smith On June 17, 2015

Re: Review Request 34020: Normalize SLA stat names

2015-06-12 Thread Joe Smith
(stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-06-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86872 --- Ship it! Also LGTM pending jcohen's comment - Joe Smith On May

Re: Review Request 34827: Moving checkpoint root into the executor sandbox.

2015-06-01 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/#review86121 --- Ship it! Ship It! - Joe Smith On May 29, 2015, 12:54 p.m

Re: Review Request 34484: Daemonize all deadline calls in aurora executor.

2015-05-27 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/#review85482 --- Ship it! Ship It! - Joe Smith On May 26, 2015, 1:43 p.m., Brian

Re: Review Request 34015: Improve client update json output to consistently use last_modified

2015-05-11 Thread Joe Smith
src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Joe Smith

Re: Review Request 34015: Improve client update json output to consistently use last_modified

2015-05-11 Thread Joe Smith
. SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Joe Smith

Review Request 34015: Improve client update json output to consistently use lastModified

2015-05-09 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
: https://reviews.apache.org/r/33997/diff/ Testing --- Thanks, Joe Smith

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-31 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? Joe Smith wrote: In `src/main/python/apache