Re: Review Request 42445: Upgrade pants to 0.0.68.
> On Jan. 19, 2016, 1:06 p.m., John Sirois wrote: > > I'm going to patch this in presently, but wave hellow to Joe! /wave - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42445/#review115233 --- On Jan. 17, 2016, 3:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42445/ > --- > > (Updated Jan. 17, 2016, 3:42 p.m.) > > > Review request for Aurora, Joe Smith and Stephan Erb. > > > Repository: aurora > > > Description > --- > > This is the regular weekly release/upgrade. > The CHANGELOG can be read here: > http://pantsbuild.github.io/changelog.html > > Of interest for Aurora is graceful error handling when running > py.test with `--coverage` enabled. > > pants.ini | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > pants.ini a5fbfba81e1444ddf144db33dd3321aa06365385 > > Diff: https://reviews.apache.org/r/42445/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Review Request 40204: Update pants bootstrap script to be agnostic to sed version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/ --- Review request for Aurora. Repository: aurora Description --- Update pants bootstrap script to be agnostic to sed version Diffs - pants 47097994b1044202aa0d8ce6afb8c2dee2a4c27c Diff: https://reviews.apache.org/r/40204/diff/ Testing --- Thanks, Joe Smith
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105973 --- Ship it! Thanks again John! - Joe Smith On Nov. 10, 2015, 1:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 1:50 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.
> On Oct. 29, 2015, 3:15 p.m., Zameer Manji wrote: > > John, would you mind filing a ticket to track the followup work to use the > > built in pants checkstyle? https://issues.apache.org/jira/browse/AURORA-1532 - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104483 --- On Oct. 29, 2015, 3:05 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Oct. 29, 2015, 3:05 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7 > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > fad8da5ce4c03f25554394bc628d4fbb0fe6cd69 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Review Request 38504: Re-add Health Check to the Scheduler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38504/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1496
https://issues.apache.org/jira/browse/AURORA-1496
Repository: aurora
Description
---
Add health check validation
Diffs
-
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java
f9b06877f1d49677875d7bc1235ea1c4c9e790d7
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
1eec20cca5340f01ec2b45ef22d7e1c33e74ca3f
Diff: https://reviews.apache.org/r/38504/diff/
Testing
---
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
and
```
vagrant@aurora:~$ curl -sL -w '%{http_code}' localhost:8081/health -o
/dev/null; echo
200
```
Thanks,
Joe Smith
Review Request 38510: Maintain compatibility with Health Handler before javax refactor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38510/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1496 https://issues.apache.org/jira/browse/AURORA-1496 Repository: aurora Description --- Maintain compatibility with Health Handler before javax refactor Diffs - commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java 731151c2b14e2edc3284c56a9a9f0aa56d8b37f9 Diff: https://reviews.apache.org/r/38510/diff/ Testing --- The previous HealthHandler used `println` to get the newline. `[tw-mbp-jsmith aurora (health-newline)]$ src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` and ``` vagrant@aurora:~$ curl --silent --fail --retry 4 --retry-delay 10 localhost:8081/health OK vagrant@aurora:~$ ``` Thanks, Joe Smith
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. > > Maxim Khutornenko wrote: > I agree there are ways to improve this functionality but given this is > mostly a restore of the old (and proven) commons code can we move these > suggestions into a ticket to follow up after this change lands? > > Zameer Manji wrote: > I'm ok with this landing if Joe agrees to follow up with a patch. > > Bill Farner wrote: > FWIW i agree with Zameer that Properties->Map is the right thing to do, > and not a big request. I have no opinion on the other changes. Cool, TBH I'd rather just knock it out here vs. a two-step process if that's okay. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99312 ------- On Sept. 16, 2015, 2:53 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38280/ > --- > > (Updated Sept. 16, 2015, 2:53 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1473 > https://issues.apache.org/jira/browse/AURORA-1473 > > > Repository: aurora > > > Description > --- > > Restore build properties within Scheduler vars endpoint and snapshots > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 670ba0850987308370e3c766048ad6ba246d9e29 > build-support/generate-build-properties PRE-CREATION > build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 89c134315dfdb4c55447032171ec3be8ec73823d > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > d76596c7422786e58b5a8aa79f324911cfd29b25 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > cc9c066556385c073962903691c037b0c07cc94c > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 > > Diff: https://reviews.apache.org/r/38280/diff/ > > > Testing > --- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 17, 2015, 12:26 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes --- Zameer's suggestion Bugs: AURORA-1473 https://issues.apache.org/jira/browse/AURORA-1473 Repository: aurora Description --- Restore build properties within Scheduler vars endpoint and snapshots Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/storage.thrift 670ba0850987308370e3c766048ad6ba246d9e29 build-support/generate-build-properties PRE-CREATION build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java PRE-CREATION commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java 89c134315dfdb4c55447032171ec3be8ec73823d src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java d76596c7422786e58b5a8aa79f324911cfd29b25 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java cc9c066556385c073962903691c037b0c07cc94c src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 Diff: https://reviews.apache.org/r/38280/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java, line 40 > > <https://reviews.apache.org/r/38280/diff/3/?file=1072783#file1072783line40> > > > > Since the properties we are interested in are basically a Map<String, > > String> I suggest we instead store a Map instead of a java properties > > object (which is mutable). > > > > We can initialize it to a an empty ImmutableMap and get rid of the > > Optional. > > > > `fetchProperties()` can load the properties and transform it into a Map > > by using Guava's `fromProperties` method: > > http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/Maps.html#fromProperties%28java.util.Properties%29 Done, and indeed simpler. > On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java, > > line 123 > > <https://reviews.apache.org/r/38280/diff/3/?file=1072782#file1072782line123> > > > > A lot of the mechanics here can be removed if BuildInfo just returned a > > Map<String, String>. This means checking of the properties are there and > > checking if the properties can be turned into a string. > > > > Also what is the benefit of turning numeric properties into Longs? > > Shouldn't we just export all the keys as Strings into the stat system? Cool, done. It's also now `<String, String>` - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99312 --- On Sept. 16, 2015, 2:53 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38280/ > --- > > (Updated Sept. 16, 2015, 2:53 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1473 > https://issues.apache.org/jira/browse/AURORA-1473 > > > Repository: aurora > > > Description > --- > > Restore build properties within Scheduler vars endpoint and snapshots > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 670ba0850987308370e3c766048ad6ba246d9e29 > build-support/generate-build-properties PRE-CREATION > build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 89c134315dfdb4c55447032171ec3be8ec73823d > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > d76596c7422786e58b5a8aa79f324911cfd29b25 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > cc9c066556385c073962903691c037b0c07cc94c > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 > > Diff: https://reviews.apache.org/r/38280/diff/ > > > Testing > --- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 16, 2015, 2:53 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes --- Maxim's revert Bugs: AURORA-1473 https://issues.apache.org/jira/browse/AURORA-1473 Repository: aurora Description --- Restore build properties within Scheduler vars endpoint and snapshots Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/storage.thrift 670ba0850987308370e3c766048ad6ba246d9e29 build-support/generate-build-properties PRE-CREATION build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java PRE-CREATION commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java 89c134315dfdb4c55447032171ec3be8ec73823d src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java d76596c7422786e58b5a8aa79f324911cfd29b25 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java cc9c066556385c073962903691c037b0c07cc94c src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 Diff: https://reviews.apache.org/r/38280/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
> On Sept. 15, 2015, 4:25 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java, > > line 76 > > <https://reviews.apache.org/r/38280/diff/3/?file=1072788#file1072788line76> > > > > Revert Done - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99123 ------- On Sept. 16, 2015, 2:30 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38280/ > --- > > (Updated Sept. 16, 2015, 2:30 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1473 > https://issues.apache.org/jira/browse/AURORA-1473 > > > Repository: aurora > > > Description > --- > > Restore build properties within Scheduler vars endpoint and snapshots > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 670ba0850987308370e3c766048ad6ba246d9e29 > build-support/generate-build-properties PRE-CREATION > build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 89c134315dfdb4c55447032171ec3be8ec73823d > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > d76596c7422786e58b5a8aa79f324911cfd29b25 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > cc9c066556385c073962903691c037b0c07cc94c > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 > > Diff: https://reviews.apache.org/r/38280/diff/ > > > Testing > --- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
> On Sept. 15, 2015, 5:32 p.m., Bill Farner wrote: > > This patch is looking good to me, but i won't have time to give it a fair > > look as i head out of town. I'd like to tap out so you don't have to wait > > 3 weeks to land it :-) Roger, thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99132 --- On Sept. 14, 2015, 11:46 a.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38280/ > --- > > (Updated Sept. 14, 2015, 11:46 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1473 > https://issues.apache.org/jira/browse/AURORA-1473 > > > Repository: aurora > > > Description > --- > > Restore build properties within Scheduler vars endpoint and snapshots > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 670ba0850987308370e3c766048ad6ba246d9e29 > build-support/generate-build-properties PRE-CREATION > build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 89c134315dfdb4c55447032171ec3be8ec73823d > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > d76596c7422786e58b5a8aa79f324911cfd29b25 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > cc9c066556385c073962903691c037b0c07cc94c > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 > > Diff: https://reviews.apache.org/r/38280/diff/ > > > Testing > --- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 14, 2015, 11:46 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Bill's feedback Bugs: AURORA-1473 https://issues.apache.org/jira/browse/AURORA-1473 Repository: aurora Description --- Restore build properties within Scheduler vars endpoint and snapshots Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/storage.thrift 670ba0850987308370e3c766048ad6ba246d9e29 build-support/generate-build-properties PRE-CREATION build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java PRE-CREATION commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java 89c134315dfdb4c55447032171ec3be8ec73823d src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java d76596c7422786e58b5a8aa79f324911cfd29b25 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java cc9c066556385c073962903691c037b0c07cc94c src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 Diff: https://reviews.apache.org/r/38280/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
> On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift, lines 130-139 > > <https://reviews.apache.org/r/38280/diff/2/?file=1068927#file1068927line130> > > > > How about map<string, string> for arbitrary metadata? then you don't > > have to pluck out magic fields That'll remove policy on what fields are available while letting others put in whatever build info they want. Sold! > On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > build-support/generate-build-properties, lines 22-26 > > <https://reviews.apache.org/r/38280/diff/2/?file=1068928#file1068928line22> > > > > s/build.// for all? We're already in a thing called > > `build.properties`, so context is set. > > > > Ditto below. Sure, I'll update the metric names though > On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > build-support/generate-build-properties, line 24 > > <https://reviews.apache.org/r/38280/diff/2/?file=1068928#file1068928line24> > > > > I'd rather omit machine, path, user. I don't think any of those are > > terribly relevant, and could be considered sensitive. Works for me, downstreams can add them if they want. > On Sept. 11, 2015, 5:15 p.m., Bill Farner wrote: > > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java, lines > > 95-104 > > <https://reviews.apache.org/r/38280/diff/2/?file=1068931#file1068931line95> > > > > If you like the previous comment, i believe this can disappear. Done. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98714 --- On Sept. 11, 2015, 4:06 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38280/ > --- > > (Updated Sept. 11, 2015, 4:06 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1473 > https://issues.apache.org/jira/browse/AURORA-1473 > > > Repository: aurora > > > Description > --- > > Restore build properties within Scheduler vars endpoint and snapshots > > > Diffs > - > > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 670ba0850987308370e3c766048ad6ba246d9e29 > build-support/generate-build-properties PRE-CREATION > build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > PRE-CREATION > > commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java > PRE-CREATION > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 89c134315dfdb4c55447032171ec3be8ec73823d > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > d76596c7422786e58b5a8aa79f324911cfd29b25 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > cc9c066556385c073962903691c037b0c07cc94c > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 > > Diff: https://reviews.apache.org/r/38280/diff/ > > > Testing > --- > > `./gradlew build -Pq` > > > Thanks, > > Joe Smith > >
Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98516 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2015, 4:19 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38277/ > --- > > (Updated Sept. 10, 2015, 4:19 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1461 > https://issues.apache.org/jira/browse/AURORA-1461 > > > Repository: aurora > > > Description > --- > > Making /utilization and client "quota" command to account for the dedicated > resource changes. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > 49bf3c9f140210b1153e1bdba74fe9a993686e9f > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java > 36e2c93f2f389100cf9e03debf86945881087302 > src/main/python/apache/aurora/client/cli/quota.py > fe2933361be24f584f5271a51e6eb76d6c2b4d58 > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > f2facfa32563177802175aa5ee47f45dc77ef780 > src/test/python/apache/aurora/client/cli/test_quota.py > bf791804fca7cd4a4ad09a9b5c6e4a8da47246c4 > > Diff: https://reviews.apache.org/r/38277/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1473 https://issues.apache.org/jira/browse/AURORA-1473 Repository: aurora Description --- Restore build properties within Scheduler vars endpoint and snapshots Diffs - .gitignore 6c37128b5d02b0e52eb467be3652a37b10d7bc06 api/src/main/thrift/org/apache/aurora/gen/storage.thrift 670ba0850987308370e3c766048ad6ba246d9e29 build-support/generate-build-properties PRE-CREATION build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java 3959ce3d688dd50399185925d91f0014fc1c43f9 commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java d76596c7422786e58b5a8aa79f324911cfd29b25 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java cc9c066556385c073962903691c037b0c07cc94c src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 6e032a6cef86e5f408bfc0d853a52c7f898d0db8 Diff: https://reviews.apache.org/r/38280/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38210/#review98476 --- specs/rpm/SOURCES/aurora.monit (line 13) <https://reviews.apache.org/r/38210/#comment154960> Start timeout 30s specs/rpm/SOURCES/aurora.monit (line 14) <https://reviews.apache.org/r/38210/#comment154961> if failed port 8081 send "GET /health HTTP/1.0\r\nUser-Agent: monit\r\n\r\n" expect "OK\n" with timeout 2 seconds for 5 cycles then restart specs/rpm/SOURCES/thermos-observer.monit (line 1) <https://reviews.apache.org/r/38210/#comment154956> Mind adding a start timeout of 30s? specs/rpm/SOURCES/thermos-observer.monit (line 2) <https://reviews.apache.org/r/38210/#comment154958> What's the default poll interval? I saw some references to it being set in ~/.monitrc, but that seems to be off what we actually want. Can we set it to 60s? specs/rpm/SOURCES/thermos-observer.monit (line 14) <https://reviews.apache.org/r/38210/#comment154957> In practice, we've had ~good luck with: if failed port 1338 protocol http and request "/health" with timeout 2 seconds for 10 cycles then restart specs/rpm/SOURCES/thermos-observer.monit (line 15) <https://reviews.apache.org/r/38210/#comment154955> start_program = "/bin/bash -c '/bin/sleep 10 && /etc/init.d/thermos-observer start'" specs/rpm/aurora.spec (line 349) <https://reviews.apache.org/r/38210/#comment154959> This should constitute a -2, right? - Joe Smith On Sept. 8, 2015, 11:56 p.m., Steve Salevan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38210/ > ----------- > > (Updated Sept. 8, 2015, 11:56 p.m.) > > > Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1480 > https://issues.apache.org/jira/browse/AURORA-1480 > > > Repository: aurora-packaging > > > Description > --- > > As requested by AURORA-1480, this RB adds Monit as a runtime requirement for > the aurora and aurora-thermos packages alongside some basic Monit scripts to > properly supervise these processes. > > Let me know what you think and thanks! > > > Diffs > - > > specs/rpm/SOURCES/aurora.monit PRE-CREATION > specs/rpm/SOURCES/thermos-observer.monit PRE-CREATION > specs/rpm/aurora.spec cf9c2715106a27fcb71447b5453ad3b847d2235a > > Diff: https://reviews.apache.org/r/38210/diff/ > > > Testing > --- > > Tested Monit scripts against a local machine > > > Thanks, > > Steve Salevan > >
Review Request 37964: Allow for slashes in metric names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37964/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Allow for slashes in metric names Diffs - commons/src/main/java/org/apache/aurora/common/stats/Stats.java f2bd05d4739f5d0f07fae33ac6e7b32d12ce574d commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 91bbc096748952cc7dbf0cbd83a2d95456e0ce0a Diff: https://reviews.apache.org/r/37964/diff/ Testing --- ``` [tw-mbp-jsmith aurora (stats-slashes)]$ ./gradlew build -Pq # snip BUILD SUCCESSFUL ``` Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Aha, gotcha- no worries, I'll update the ticket and discard this. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Changes --- Updated with a TODO to remove, happy to update if that doesn't seem clear Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 3:02 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing (updated) --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 3:02 p.m.) Review request for Aurora and Bill Farner. Changes --- Moved the stats change to the inner class (not sure if this is ~good or not, feedback welcome). Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries, I'll update the ticket and discard this. Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:36 a.m.) Review request for Aurora and Bill Farner. Changes --- Stephan Erb's additional catch Summary (updated) - Squelch extraneous Stats logging to prevent spamming scheduler startup log. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description (updated) --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 5, 2015, 12:49 p.m., Stephan Erb wrote: The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 Bill Farner wrote: Good call - are you planning to roll that into this patch? Yep, good idea, pulled that in as well. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90412 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Normalize SLA stat names
On July 8, 2015, 10:49 a.m., Stephan Erb wrote: Joe, have you tested this change in vagrant? I decided to change direction here, so we won't be changing stats names. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review90933 --- On July 30, 2015, 10:32 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 10:32 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent spamming scheduler startup log.
On July 30, 2015, 5:22 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243 https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243 Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior. I'd happily wait for the fork and live with the log noise rather than go this direction. Joe Smith wrote: Aha, gotcha- no worries, I'll update the ticket and discard this. Joe Smith wrote: Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?) Bill Farner wrote: Yeah, it's just kind of sneaky. Even if the operator tries to configure the logging system, or we try to adjust the log level on the fly, this code undermines that. That might be okay for the logging done today, but who knows about tomorrow. Yep, gotcha- thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review93682 --- On July 30, 2015, 5:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated July 30, 2015, 5:14 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description --- Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893 src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- $ ./gradlew build -Pq Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 15, 2015, 11:08 a.m.) Review request for Aurora and Bill Farner. Changes --- Bill's fixes Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
On July 15, 2015, 9:50 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 169 https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line169 For better readability, how about `max_update_instance_failures`? Done. On July 15, 2015, 9:50 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 171 https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line171 s/scheduler datastore/storage/ Done. On July 15, 2015, 9:50 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 173 https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line173 Unfortunately, this will not work as you expect and derive from the value of `-max_tasks_per_job`. This will always capture the default value (4000) since it is evaluated before the arg is populated. In fact, this would cause a failure if `-max_tasks_per_job` was set on the command line, since args prevent setting a value after it has been read. The best way i can see to accomplish this while maintaining the relationship is to extract constants: ``` private static final int DEFAULT_MAX_TASKS_PER_JOB = 4000; private static final int DEFAULT_MAX_INSTANCE_UPDATE_EVENT_FAILURES = DEFAULT_MAX_TASKS_PER_JOB * 5; ``` There isn't a clean way to have this multiplier effect that Just Works, so i suggest you just set it to 2 and leave a comment near `MAX_TASKS_PER_JOB` suggesting that this arg be changed if the default is changed there. Aha, good to know. Thanks for catching that! Let me know if you think that comment is sufficient. On July 15, 2015, 9:50 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1123 https://reviews.apache.org/r/36436/diff/3/?file=1011900#file1011900line1123 This first part can be ommitted, since it's effectively covered by `MAX_TASKS_PER_JOB`. Done. - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91749 --- On July 14, 2015, 5:30 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 14, 2015, 5:30 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 15, 2015, 1:23 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
On July 15, 2015, 11:47 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 168-169 https://reviews.apache.org/r/36436/diff/4/?file=1012829#file1012829line168 Sorry, i made that suggestion before i added the comment to break out constants and multiply. Feel free to nuke this :-/ No worries at all! I found this comment to still be ~helpful, but I can see how the constants make this redundant and thus removable. Thanks again! :) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91790 --- On July 15, 2015, 11:08 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 15, 2015, 11:08 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
On July 14, 2015, 10:55 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 168-177 https://reviews.apache.org/r/36436/diff/2/?file=1010206#file1010206line168 Have you considered a single arg for the upper bound of instance events that are allowed for a job update? I think this would be easier for the operator to reason about, and simpler to associate directly to DB impact. Good idea, and much simpler. Let me know what you think of the implementation. Thanks! - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91645 --- On July 13, 2015, 4:10 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 13, 2015, 4:10 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 14, 2015, 5:30 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 36436: Prevent job updates from allowing unbounded instance events
On July 12, 2015, 11:38 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 169 https://reviews.apache.org/r/36436/diff/1/?file=1009204#file1009204line169 Give that this will be the only documentation of this feature, the doc string could be a bit longer and explain that this option applies to the job update feature and limits the `max_per_shard_failures` jobspec configuration. Done (I believe, thatis. Let me know if you think this is clearer!) On July 12, 2015, 11:38 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 173 https://reviews.apache.org/r/36436/diff/1/?file=1009204#file1009204line173 Same as above. It is hard to understand the implications of this option without reading the code. Done. (But let me know what you think!) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91416 --- On July 12, 2015, 11:49 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 12, 2015, 11:49 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1096 https://issues.apache.org/jira/browse/AURORA-1096 Repository: aurora Description --- Prevent job updates from allowing unbounded instance events Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dc0cd2d71d11b8157154f7b63a14f0282dee09f1 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d28baba7618ebb194a61455971786aef46abd8eb Diff: https://reviews.apache.org/r/36436/diff/ Testing --- `./gradlew build -Pq` Thanks, Joe Smith
Re: Review Request 35580: Fix symlink duplicates from MesosPathDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/#review88278 --- Ship it! +1 on test coverage too - Joe Smith On June 17, 2015, 2:17 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35580/ --- (Updated June 17, 2015, 2:17 p.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1353 https://issues.apache.org/jira/browse/AURORA-1353 Repository: aurora Description --- Fix symlink duplicates from MesosPathDetector. Also added thread ids to TaskResourceMonitor for better /threads debugging. Diffs - src/main/python/apache/aurora/executor/common/path_detector.py ba85d5c969d3f1f62d3f898bed83d930e2994bd2 src/main/python/apache/thermos/monitoring/resource.py c1d7804fe0896d8b92aa565d6dd5295fa58efd3f src/test/python/apache/aurora/executor/common/test_path_detector.py 86460bb6499596964124bec85d74ca9dba7d2c7c src/test/python/apache/thermos/monitoring/test_resource.py a7ab360d7bc0022b115b9059b16d76b8923d5e23 Diff: https://reviews.apache.org/r/35580/diff/ Testing --- Verified we realpath the paths prior to returning from path detector. Thanks, Brian Wickman
Re: Review Request 34020: Normalize SLA stat names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/ --- (Updated June 12, 2015, 4:18 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1282 https://issues.apache.org/jira/browse/AURORA-1282 Repository: aurora Description (updated) --- Normalize SLA stat names ahead of time- this will prevent spurious log messages. Stat names will be unchanged as a result of this. Diffs - src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603 src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164 Diff: https://reviews.apache.org/r/34020/diff/ Testing --- [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test BUILD SUCCESSFUL Thanks, Joe Smith
Re: Review Request 34570: Use set-literals and set-comprehensions where possible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review86872 --- Ship it! Also LGTM pending jcohen's comment - Joe Smith On May 21, 2015, 4:28 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/ --- (Updated May 21, 2015, 4:28 p.m.) Review request for Aurora, Joshua Cohen and Brian Wickman. Repository: aurora Description --- Use Python 2.7 set-literal and set-comprehension syntax where possible. There are theoretical performance gains here, for example we now often avoid the creation of an intermediate list. The main reason I did this was consistency though - as you'll see in this review there's no single agreed-upon way to do this. Diffs - 3rdparty/python/requirements.txt 439554d0980a4f3cd5b65a809547c7ac32d3cbf5 src/main/python/apache/aurora/admin/admin.py d2f7bd13ef335bdca7dc02177c031ac36574658d src/main/python/apache/aurora/admin/host_maintenance.py c31e2a6fb0348c5e7074e46d61c2d2723afaf14d src/main/python/apache/aurora/client/api/__init__.py 4b9c48e84bc203fc7b28d7efd0b2e6b8a6f18302 src/main/python/apache/aurora/client/api/instance_watcher.py 6ed815423f48301ecb3faaadcdfa1e46f50b6ca2 src/main/python/apache/aurora/client/api/job_monitor.py aa7e9760d0f4f74a5ddf97e0642bf53efc555644 src/main/python/apache/aurora/client/api/sla.py 5855685bda7188c55432dc6f1ad3c676a38309da src/main/python/apache/aurora/client/api/updater.py acbce21e991981a2e85c1a00a68e57d88c5509bb src/main/python/apache/aurora/client/cli/command_hooks.py e95b1b11e16b8e2cfc83ace8654e146be208d14e src/main/python/apache/aurora/client/cli/context.py c850223588df9d9be4a644aa51adc6419a751af0 src/main/python/apache/aurora/client/cli/jobs.py 5f608419e1235f14836865b46be05d13963deb37 src/main/python/apache/aurora/client/cli/task.py b541d03d6e34dce7f4f1e38e2d970c71c8d94e08 src/main/python/apache/aurora/config/__init__.py dd2f89014a3da730364b14e01c499ac0f2c288c1 src/main/python/apache/aurora/executor/gc_executor.py d4392faf50f8c72f08f951962913248045d7fcb5 src/main/python/apache/thermos/cli/commands/tail.py 47b52eee7cb43a46f75d62b648d293a9c603efc3 src/main/python/apache/thermos/common/planner.py da5120f8f0c2489927a03e9d78ccb4f9b6eb275f src/main/python/apache/thermos/core/helper.py 8cd32948663a5d5a1e975e1661b78de701710436 src/test/python/apache/aurora/BUILD 0701440ae47034c580b5baae40e5f6feec4bb4fd src/test/python/apache/aurora/client/api/BUILD 65b378b0b4c5fa11f9899ef04a4a10a211f37245 src/test/python/apache/aurora/client/api/test_job_monitor.py ccc8b551c15df2d726291675a90a62c30ad5ebd4 src/test/python/apache/aurora/client/api/test_sla.py 22b9f995eaa1deae9f5c5467e0939670c099f438 src/test/python/apache/aurora/client/cli/BUILD 0d85f5fba9d19ae0e9c36546f130b93664b4f6de src/test/python/apache/aurora/client/cli/test_command_hooks.py 2130f1fa71be02a004cdf8e476a270c81a7105d3 src/test/python/apache/aurora/client/cli/test_create.py 9f32ca3474ea51529217db29b88911010fa73602 src/test/python/apache/aurora/client/cli/test_plugins.py a545fece5e2b3e0017a61e1be9ac478372b1f34d src/test/python/apache/aurora/thrift_util.py PRE-CREATION Diff: https://reviews.apache.org/r/34570/diff/ Testing --- I've left most of the tests out of the scope of this review to provide more confidence; however, I've fixed them in a few places where using sets consistently broke things. Specifically I changed construction of some Thrift structs to use set-literals instead of list-literals (since their IDL type is set and not list) and this broke some tests due to a long-standing bug in Thrift. To fix them I've introduced a test dependency on [PyHamcrest](http://pyhamcrest.readthedocs.org/en/release-1.8/tutorial/) for matchers support (it's pretty much the same as Java for those who are familiar). Usage of PyHamcrest is [suggested in the mock documentation for this use case](https://docs.python.org/3/library/unittest.mock-examples.html#more-complex-argument-matching). ./pants test.pytest --no-fast src/test/python:: Thanks, Kevin Sweeney
Re: Review Request 34827: Moving checkpoint root into the executor sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/#review86121 --- Ship it! Ship It! - Joe Smith On May 29, 2015, 12:54 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/ --- (Updated May 29, 2015, 12:54 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Bugs: AURORA-1337 https://issues.apache.org/jira/browse/AURORA-1337 Repository: aurora Description --- Checkpoints are now written into the executor sandbox instead of the default global location. Diffs - examples/vagrant/aurorabuild.sh 1a76e4f8fcfe79049e331211fad5ef617ba9a6e0 src/main/python/apache/aurora/executor/bin/BUILD 6ef669d8e3d7f1f4cb00dcc11175eedccb66a689 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 3174e1f9635c47b2f3d789c39b1bc177db25a7e5 src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168e422b5d9703bbef8101333ed20581a3cd src/test/python/apache/aurora/executor/bin/BUILD b1bcfac16cb4675d66bdd0074f389f8c4978dffa src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py e89a01e4e76b0be35e0a65d7d3a06c3ba594de39 Diff: https://reviews.apache.org/r/34827/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
Re: Review Request 34484: Daemonize all deadline calls in aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/#review85482 --- Ship it! Ship It! - Joe Smith On May 26, 2015, 1:43 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/ --- (Updated May 26, 2015, 1:43 p.m.) Review request for Aurora, Joe Smith and Vinod Kone. Bugs: AURORA-698 https://issues.apache.org/jira/browse/AURORA-698 Repository: aurora Description --- Daemonize all deadline calls in aurora executor. If we do not daemonize, it's possible for the aurora executor to send TASK_KILLED and then block indefinitely on shutdown. This way the aurora executor process will at least exit, allow the cgroup to tear down all active processes. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258 Diff: https://reviews.apache.org/r/34484/diff/ Testing --- ./pants test src/test/python/apache/aurora/executor:: Thanks, Brian Wickman
Re: Review Request 34015: Improve client update json output to consistently use last_modified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/ --- (Updated May 11, 2015, 3:19 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1316 https://issues.apache.org/jira/browse/AURORA-1316 Repository: aurora Description (updated) --- Improve client update json output to consistently use last_modified Diffs - src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143 src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914 Diff: https://reviews.apache.org/r/34015/diff/ Testing --- $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all src.test.python.apache.aurora.client.api.api . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.mux . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.task_util . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.api.updater_util . SUCCESS src.test.python.apache.aurora.client.base . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.client . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.context . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Joe Smith
Re: Review Request 34015: Improve client update json output to consistently use last_modified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/ --- (Updated May 11, 2015, 3:19 p.m.) Review request for Aurora and Bill Farner. Changes --- Use snake_case Summary (updated) - Improve client update json output to consistently use last_modified Bugs: AURORA-1316 https://issues.apache.org/jira/browse/AURORA-1316 Repository: aurora Description --- Improve client update json output to consistently use lastModified Diffs (updated) - src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143 src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914 Diff: https://reviews.apache.org/r/34015/diff/ Testing --- $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all src.test.python.apache.aurora.client.api.api . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.mux . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.task_util . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.api.updater_util . SUCCESS src.test.python.apache.aurora.client.base . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.client . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.context . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Joe Smith
Review Request 34015: Improve client update json output to consistently use lastModified
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1316 https://issues.apache.org/jira/browse/AURORA-1316 Repository: aurora Description --- Improve client update json output to consistently use lastModified Diffs - src/main/python/apache/aurora/client/cli/update.py 58f0db0988911858156aa086ba9fea8ecfe99143 src/test/python/apache/aurora/client/cli/test_supdate.py 158d3305c5ce5f1de5e3f4f771f318cff9bf7914 Diff: https://reviews.apache.org/r/34015/diff/ Testing --- $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all src.test.python.apache.aurora.client.api.api . SUCCESS src.test.python.apache.aurora.client.api.instance_watcher . SUCCESS src.test.python.apache.aurora.client.api.job_monitor . SUCCESS src.test.python.apache.aurora.client.api.mux . SUCCESS src.test.python.apache.aurora.client.api.quota_check . SUCCESS src.test.python.apache.aurora.client.api.restarter . SUCCESS src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS src.test.python.apache.aurora.client.api.sla . SUCCESS src.test.python.apache.aurora.client.api.task_util . SUCCESS src.test.python.apache.aurora.client.api.updater . SUCCESS src.test.python.apache.aurora.client.api.updater_util . SUCCESS src.test.python.apache.aurora.client.base . SUCCESS src.test.python.apache.aurora.client.binding_helper . SUCCESS src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.client . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.context . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Joe Smith
Re: Review Request 33997: Improve GPG key validation for release verification script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/ --- (Updated May 8, 2015, 5:11 p.m.) Review request for Aurora and Bill Farner. Changes --- after speaking with jcohen and wfarner in IRC's #aurora Repository: aurora Description --- Improve GPG key validation for release verification script Diffs (updated) - build-support/release/verify-release-candidate f96d7c9239895e86d715ecec3c47b9ba828dbc30 Diff: https://reviews.apache.org/r/33997/diff/ Testing --- Thanks, Joe Smith
Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.
On March 20, 2015, 3:52 p.m., Joe Smith wrote:
Joe Smith wrote:
It seems like the `self.quitquitquit` is the important part (on line 340
of the runner)- doesn't decreasing the timeout not give `quitquitquit` the
time it needs?
Joe Smith wrote:
In `src/main/python/apache/aurora/executor/thermos_task_runner.py`
```
331 waited = Amount(0, Time.SECONDS)
332 while self.is_alive and waited timeout:
333 self._clock.sleep(self.POLL_INTERVAL.as_(Time.SECONDS))
334 waited += self.POLL_INTERVAL
335
336 if not self.is_alive and self.task_state() != TaskState.ACTIVE:
337 return
338
339 log.info('Thermos task did not shut down cleanly, rebinding to
kill.')
340 self.quitquitquit()
341
342 while not self._monitor.finished and waited timeout:
343 self._clock.sleep(self.POLL_INTERVAL.as_(Time.SECONDS))
344 waited += self.POLL_INTERVAL
```
Is it that we need to reset waited to Amount(0, Time.SECONDS) ?
friendly ping
- Joe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32221/#review77296
---
On March 18, 2015, 6:20 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32221/
---
(Updated March 18, 2015, 6:20 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1054
https://issues.apache.org/jira/browse/AURORA-1054
Repository: aurora
Description
---
Remove excessively low timeout in SIGTERM swallowing test.
Diffs
-
src/test/python/apache/aurora/executor/test_thermos_task_runner.py
6b24bbb2ab7ca16f97961aabeed945b61e5b5908
Diff: https://reviews.apache.org/r/32221/diff/
Testing
---
Cannot reproduce locally, but 5 seconds is an impossibly small timeout, even
if we aren't testing SIGTERM swallowing. If this fails, we will get tripped
by 60s timeout instead.
Thanks,
Brian Wickman
