Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-19 Thread Justin Pinkul
this for everyone where it may not be necessary/desirable? > > > > Alternately, I'm not super familiar w/ CNI, but is it possible to infer > > from the TaskInfo whether CNI is enabled (e.g. is NetworkInfo set > > somewhere)? > > Justin Pinkul wrote: > This is

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-19 Thread Justin Pinkul
this for everyone where it may not be necessary/desirable? > > > > Alternately, I'm not super familiar w/ CNI, but is it possible to infer > > from the TaskInfo whether CNI is enabled (e.g. is NetworkInfo set > > somewhere)? > > Justin Pinkul wrote: > This is

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
tfs for processes and the ownership of this logic can return to Mesos. - Justin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53003/#review153217 ----------

Re: Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
tests and launched a simple ping Aurora job with and without the change. Thanks, Justin Pinkul

Review Request 53003: Adding logic to copy network files when using the Mesos containierizer with a Docker image.

2016-10-18 Thread Justin Pinkul
with and without the change. Thanks, Justin Pinkul

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
/aurora/executor:: ``` Thanks, Justin Pinkul

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
:: ``` Thanks, Justin Pinkul

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-13 Thread Justin Pinkul
is set to a file that does not exist and also verified the executors complates succesfully when mesos_containerizer_path is set to the correct location. Unit tests: ``` ./pants test src/test/python/apache/thermos:: ./pants test src/test/python/apache/aurora/executor:: ``` Thanks, Justin Pinkul

Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Justin Pinkul
succesfully when mesos_containerizer_path is set to the correct location. Unit tests: ``` ./pants test src/test/python/apache/thermos:: ./pants test src/test/python/apache/aurora/executor:: ``` Thanks, Justin Pinkul

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Justin Pinkul
mesos_containerizer_path is set to the correct location. Unit tests: ``` ./pants test src/test/python/apache/thermos:: ./pants test src/test/python/apache/aurora/executor:: ``` Thanks, Justin Pinkul