Re: Review Request 31101: Native Debian packaging for Aurora

2015-06-09 Thread Dan Norris

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review87189
---

Ship it!


I was able to build and deploy debs against master after applying the patch. 
Seems shippable to me.

- Dan Norris


On May 23, 2015, 1:59 a.m., Benjamin Staffin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31101/
 ---
 
 (Updated May 23, 2015, 1:59 a.m.)
 
 
 Review request for Aurora and Jake Farrell.
 
 
 Bugs: AURORA-951
 https://issues.apache.org/jira/browse/AURORA-951
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Native Debian packaging for Aurora
 
 This uses Debian package dependencies to install gradle and thrift-compiler.  
 Gradle 2.x isn't in Debian or Ubuntu yet, but you can build your own package 
 easily enough using https://github.com/benley/gradle-packaging
 
 
 Diffs
 -
 
   build-support/embed_runner_in_executor.py PRE-CREATION 
   debian/aurora-doc.docs PRE-CREATION 
   debian/aurora-doc.examples PRE-CREATION 
   debian/aurora-executor.dirs PRE-CREATION 
   debian/aurora-executor.install PRE-CREATION 
   debian/aurora-executor.links PRE-CREATION 
   debian/aurora-executor.thermos.default PRE-CREATION 
   debian/aurora-executor.thermos.init PRE-CREATION 
   debian/aurora-executor.thermos.upstart PRE-CREATION 
   debian/aurora-scheduler.default PRE-CREATION 
   debian/aurora-scheduler.init PRE-CREATION 
   debian/aurora-scheduler.install PRE-CREATION 
   debian/aurora-scheduler.links PRE-CREATION 
   debian/aurora-scheduler.postinst PRE-CREATION 
   debian/aurora-scheduler.upstart PRE-CREATION 
   debian/aurora-tools.install PRE-CREATION 
   debian/aurora-tools.links PRE-CREATION 
   debian/changelog PRE-CREATION 
   debian/clusters.json PRE-CREATION 
   debian/compat PRE-CREATION 
   debian/control PRE-CREATION 
   debian/copyright PRE-CREATION 
   debian/pants.ini PRE-CREATION 
   debian/rules PRE-CREATION 
   debian/source/format PRE-CREATION 
   examples/vagrant/aurorabuild.sh 1a76e4f8fcfe79049e331211fad5ef617ba9a6e0 
 
 Diff: https://reviews.apache.org/r/31101/diff/
 
 
 Testing
 ---
 
 Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
 pbuilder. Have been using debs built from this branch on a testing cluster 
 for a few months now.
 
 
 Thanks,
 
 Benjamin Staffin
 




Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review78245
---

Ship it!


Master (3ab8a9e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On March 30, 2015, 7:11 p.m., Benjamin Staffin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31101/
 ---
 
 (Updated March 30, 2015, 7:11 p.m.)
 
 
 Review request for Aurora and Jake Farrell.
 
 
 Bugs: AURORA-951
 https://issues.apache.org/jira/browse/AURORA-951
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Native Debian packaging for Aurora
 
 This uses Debian package dependencies to install gradle and thrift-compiler.  
 Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
 package easily enough using https://github.com/benley/gradle-packaging
 
 
 Diffs
 -
 
   build-support/embed_runner_in_executor.py PRE-CREATION 
   debian/aurora-doc.docs PRE-CREATION 
   debian/aurora-doc.examples PRE-CREATION 
   debian/aurora-executor.dirs PRE-CREATION 
   debian/aurora-executor.install PRE-CREATION 
   debian/aurora-executor.links PRE-CREATION 
   debian/aurora-executor.thermos.default PRE-CREATION 
   debian/aurora-executor.thermos.init PRE-CREATION 
   debian/aurora-executor.thermos.upstart PRE-CREATION 
   debian/aurora-scheduler.default PRE-CREATION 
   debian/aurora-scheduler.init PRE-CREATION 
   debian/aurora-scheduler.install PRE-CREATION 
   debian/aurora-scheduler.links PRE-CREATION 
   debian/aurora-scheduler.postinst PRE-CREATION 
   debian/aurora-scheduler.upstart PRE-CREATION 
   debian/aurora-tools.install PRE-CREATION 
   debian/aurora-tools.links PRE-CREATION 
   debian/changelog PRE-CREATION 
   debian/clusters.json PRE-CREATION 
   debian/compat PRE-CREATION 
   debian/control PRE-CREATION 
   debian/copyright PRE-CREATION 
   debian/pants.ini PRE-CREATION 
   debian/rules PRE-CREATION 
   debian/source/format PRE-CREATION 
   examples/vagrant/aurorabuild.sh 7dc9777c054a8f8a98059f263c49ba2e3e6d7207 
 
 Diff: https://reviews.apache.org/r/31101/diff/
 
 
 Testing
 ---
 
 Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
 pbuilder. Have been using debs built from this branch on a testing cluster 
 for a few months now.
 
 
 Thanks,
 
 Benjamin Staffin
 




Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Benjamin Staffin


 On Feb. 19, 2015, 10:48 a.m., Bill Farner wrote:
  Drive-by piecemeal review - should we create a top-level directory to house 
  these?  (Presumably a similar dir for RPMs would not be far off.)  Perhaps 
  `distributions/`?

It's appealing from a repo cleanliness perspective, but doing so complicates 
the Debian build process, as it tends to require that the debian/ directory be 
at the top level of the sources.  If we wanted to do something like, say, have 
a gradle task that generates a Debian source package, which could then be built 
using the usual Debian tools, that could be done.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review73174
---


On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31101/
 ---
 
 (Updated Feb. 16, 2015, 4:20 p.m.)
 
 
 Review request for Aurora and Jake Farrell.
 
 
 Bugs: AURORA-951
 https://issues.apache.org/jira/browse/AURORA-951
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Native Debian packaging for Aurora
 
 This uses Debian package dependencies to install gradle and thrift-compiler.  
 Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
 package easily enough using https://github.com/benley/gradle-packaging
 
 
 Diffs
 -
 
   debian/aurora-doc.docs PRE-CREATION 
   debian/aurora-doc.examples PRE-CREATION 
   debian/aurora-executor.dirs PRE-CREATION 
   debian/aurora-executor.install PRE-CREATION 
   debian/aurora-executor.links PRE-CREATION 
   debian/aurora-executor.thermos.default PRE-CREATION 
   debian/aurora-executor.thermos.init PRE-CREATION 
   debian/aurora-executor.thermos.upstart PRE-CREATION 
   debian/aurora-scheduler.default PRE-CREATION 
   debian/aurora-scheduler.init PRE-CREATION 
   debian/aurora-scheduler.install PRE-CREATION 
   debian/aurora-scheduler.links PRE-CREATION 
   debian/aurora-scheduler.postinst PRE-CREATION 
   debian/aurora-scheduler.upstart PRE-CREATION 
   debian/aurora-tools.install PRE-CREATION 
   debian/aurora-tools.links PRE-CREATION 
   debian/changelog PRE-CREATION 
   debian/clusters.json PRE-CREATION 
   debian/compat PRE-CREATION 
   debian/control PRE-CREATION 
   debian/copyright PRE-CREATION 
   debian/embed-runner-in-executor.py PRE-CREATION 
   debian/pants.ini PRE-CREATION 
   debian/rules PRE-CREATION 
   debian/source/format PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/31101/diff/
 
 
 Testing
 ---
 
 Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
 pbuilder. Have been using debs built from this branch on a testing cluster 
 for a few months now.
 
 
 Thanks,
 
 Benjamin Staffin