Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/#review99133
---
Ship it!
Ship It!
- Bill Farner
On Sept. 15, 2015, 12:56 p.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38389/
> ---
>
> (Updated Sept. 15, 2015, 12:56 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1485
> https://issues.apache.org/jira/browse/AURORA-1485
>
>
> Repository: aurora
>
>
> Description
> ---
>
> When generating the client api library for go the default containerizer used
> as a hack for AURORA-1185 breaks and causes the client lib to not be
> generated correctly. The default value for the optional field `container = {
> "mesos": {} }` is not necessary as it is defaulted in java code on the api
> side.
>
> Tracking this down it looks like the default value was a last minute addition
> based on some review comments and is not necessary or used anywhere.
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 24a2ca8cc9a236228fdd8aa61c877319a803c9a6
>
> Diff: https://reviews.apache.org/r/38389/diff/
>
>
> Testing
> ---
>
> Passes all java/py tests in ./build-support/jenkins/build.sh
> Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/#review99005
---
Ship it!
Master (44e4726) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 15, 2015, 12:41 a.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38389/
> ---
>
> (Updated Sept. 15, 2015, 12:41 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1485
> https://issues.apache.org/jira/browse/AURORA-1485
>
>
> Repository: aurora
>
>
> Description
> ---
>
> When generating the client api library for go the default containerizer used
> as a hack for AURORA-1185 breaks and causes the client lib to not be
> generated correctly. The default value for the optional field `container = {
> "mesos": {} }` is not necessary as it is defaulted in java code on the api
> side.
>
> Tracking this down it looks like the default value was a last minute addition
> based on some review comments and is not necessary or used anywhere.
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 24a2ca8cc9a236228fdd8aa61c877319a803c9a6
> src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java
> 13cb73d0e314c043aed9ab2aacea1908c069a297
> src/test/python/apache/aurora/client/cli/test_status.py
> a75f15e99af97acb0af7e112e28c693a77f9eb24
> src/test/python/apache/aurora/client/cli/util.py
> b03148b4edaa334620a72bee1937c8c16e19f23e
> src/test/python/apache/aurora/executor/test_thermos_executor.py
> d24c61162e11bb4afef2902ebb031478fe3ed247
>
> Diff: https://reviews.apache.org/r/38389/diff/
>
>
> Testing
> ---
>
> Passes all java/py tests in ./build-support/jenkins/build.sh
> Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/#review99082
---
Ship it!
Master (44e4726) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 15, 2015, 7:56 p.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38389/
> ---
>
> (Updated Sept. 15, 2015, 7:56 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1485
> https://issues.apache.org/jira/browse/AURORA-1485
>
>
> Repository: aurora
>
>
> Description
> ---
>
> When generating the client api library for go the default containerizer used
> as a hack for AURORA-1185 breaks and causes the client lib to not be
> generated correctly. The default value for the optional field `container = {
> "mesos": {} }` is not necessary as it is defaulted in java code on the api
> side.
>
> Tracking this down it looks like the default value was a last minute addition
> based on some review comments and is not necessary or used anywhere.
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 24a2ca8cc9a236228fdd8aa61c877319a803c9a6
>
> Diff: https://reviews.apache.org/r/38389/diff/
>
>
> Testing
> ---
>
> Passes all java/py tests in ./build-support/jenkins/build.sh
> Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
> On Sept. 15, 2015, 1:24 a.m., Bill Farner wrote:
> > The default value wasn't a hack, but moving it to the end of the
> > `TaskConfig` message definition was. I think the default is useful and
> > should really remain. IIRC we concluded that the `optional` was
> > unnecessary, though.
> >
> > I'm -1 to removing the default due to what appears like a thrift bug, but
> > +1 to removing the confusing `optional` if that happens to fix things.
patch updated to remove optional and leave default value. Passes all test cases
and e2e.
- Jake
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/#review98979
---
On Sept. 15, 2015, 7:56 p.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38389/
> ---
>
> (Updated Sept. 15, 2015, 7:56 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1485
> https://issues.apache.org/jira/browse/AURORA-1485
>
>
> Repository: aurora
>
>
> Description
> ---
>
> When generating the client api library for go the default containerizer used
> as a hack for AURORA-1185 breaks and causes the client lib to not be
> generated correctly. The default value for the optional field `container = {
> "mesos": {} }` is not necessary as it is defaulted in java code on the api
> side.
>
> Tracking this down it looks like the default value was a last minute addition
> based on some review comments and is not necessary or used anywhere.
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 24a2ca8cc9a236228fdd8aa61c877319a803c9a6
>
> Diff: https://reviews.apache.org/r/38389/diff/
>
>
> Testing
> ---
>
> Passes all java/py tests in ./build-support/jenkins/build.sh
> Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 38389: AURORA-1485: TaskConfig default container value breaks client library generation for GO
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/#review98979
---
The default value wasn't a hack, but moving it to the end of the `TaskConfig`
message definition was. I think the default is useful and should really
remain. IIRC we concluded that the `optional` was unnecessary, though.
I'm -1 to removing the default due to what appears like a thrift bug, but +1 to
removing the confusing `optional` if that happens to fix things.
- Bill Farner
On Sept. 14, 2015, 5:41 p.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38389/
> ---
>
> (Updated Sept. 14, 2015, 5:41 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1485
> https://issues.apache.org/jira/browse/AURORA-1485
>
>
> Repository: aurora
>
>
> Description
> ---
>
> When generating the client api library for go the default containerizer used
> as a hack for AURORA-1185 breaks and causes the client lib to not be
> generated correctly. The default value for the optional field `container = {
> "mesos": {} }` is not necessary as it is defaulted in java code on the api
> side.
>
> Tracking this down it looks like the default value was a last minute addition
> based on some review comments and is not necessary or used anywhere.
>
>
> Diffs
> -
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> 24a2ca8cc9a236228fdd8aa61c877319a803c9a6
> src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java
> 13cb73d0e314c043aed9ab2aacea1908c069a297
> src/test/python/apache/aurora/client/cli/test_status.py
> a75f15e99af97acb0af7e112e28c693a77f9eb24
> src/test/python/apache/aurora/client/cli/util.py
> b03148b4edaa334620a72bee1937c8c16e19f23e
> src/test/python/apache/aurora/executor/test_thermos_executor.py
> d24c61162e11bb4afef2902ebb031478fe3ed247
>
> Diff: https://reviews.apache.org/r/38389/diff/
>
>
> Testing
> ---
>
> Passes all java/py tests in ./build-support/jenkins/build.sh
> Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Jake Farrell
>
>
