Re: Review Request 41725: Add component deployment diagram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- Ship it! Thanks, this is a great addition! Since i can't use `rbt` to apply this patch, i'll pull it from your branch on github instead. Can you squash that branch to a single commit? I'd like to just cherry-pick your commit to preserve authorship information. - Bill Farner On Dec. 26, 2015, 11:53 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 11:53 a.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
> On Dec. 27, 2015, 1:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to preserve authorship information. FWIW, you can use this trick if there is no associated PR: `curl -sSL https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch | git am -3` - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- On Dec. 26, 2015, 12:53 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 12:53 p.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
> On Dec. 27, 2015, 9:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to preserve authorship information. > > John Sirois wrote: > FWIW, you can use this trick if there is no associated PR: > `curl -sSL > https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch | git > am -3` > > John Sirois wrote: > ... and then `git rebase -i` to form the single commit. Just in case, I've pushed a squashed commit to https://github.com/StephanErb/aurora/tree/fmc-squashed - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- On Dec. 26, 2015, 8:53 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 8:53 p.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
> On Dec. 27, 2015, 12:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to preserve authorship information. > > John Sirois wrote: > FWIW, you can use this trick if there is no associated PR: > `curl -sSL > https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch | git > am -3` > > John Sirois wrote: > ... and then `git rebase -i` to form the single commit. > > Stephan Erb wrote: > Just in case, I've pushed a squashed commit to > https://github.com/StephanErb/aurora/tree/fmc-squashed Thanks! I dook the patch/am route to build some muscle memory. Cool trick! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- On Dec. 26, 2015, 11:53 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 11:53 a.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
> On Dec. 27, 2015, 1:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to preserve authorship information. > > John Sirois wrote: > FWIW, you can use this trick if there is no associated PR: > `curl -sSL > https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch | git > am -3` ... and then `git rebase -i` to form the single commit. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- On Dec. 26, 2015, 12:53 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 12:53 p.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
> On Dec. 26, 2015, 8:31 a.m., Aurora ReviewBot wrote: > > This patch does not apply cleanly against master (1ae77d5), do you need to > > rebase? > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > Stephan Erb wrote: > The changes are already based on the recent master. Maybe this issue is > due to the `.gitattribute` changes? It was necessary to commit png's without > git messing up the line endings. > > Any idea? `rbt` doesn't tend to fare well with binary patches. You're just seeing the bot react to `./rbt patch -c 41725` exiting non-zero: ```console $ ./rbt patch -c 41725 Patch is being applied from request 41725 with diff revision 3. error: missing binary patch data for 'docs/images/components.odg' error: binary patch does not apply to 'docs/images/components.odg' Falling back to three-way merge... error: missing binary patch data for 'docs/images/components.odg' error: binary patch does not apply to 'docs/images/components.odg' error: docs/images/components.odg: patch does not apply error: missing binary patch data for 'docs/images/components.png' error: binary patch does not apply to 'docs/images/components.png' Falling back to three-way merge... error: missing binary patch data for 'docs/images/components.png' error: binary patch does not apply to 'docs/images/components.png' error: docs/images/components.png: patch does not apply ERROR: Unable to apply the patch. The patch may be invalid, or there may be conflicts that could not be resolved. ``` Looks like the patch provided by ReviewBoard doesn't include anything for binary files. We haven't found a workaround for this, but also haven't spent much time trying to find one. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111905 --- On Dec. 26, 2015, 11:53 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 11:53 a.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 8:52 p.m.) Review request for Aurora, Jay Buffington and Bill Farner. Bugs: AURORA-852 https://issues.apache.org/jira/browse/AURORA-852 Repository: aurora Description --- FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing their communication paths and deployment. Given that this manual is targeting beginners, the diagram sacrifices completeness in order to stay simple. Diffs (updated) - .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 docs/images/components.odg PRE-CREATION docs/images/components.png PRE-CREATION docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 Diff: https://reviews.apache.org/r/41725/diff/ Testing --- Rendered page is available at https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md File Attachments (updated) Components https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png Thanks, Stephan Erb
Re: Review Request 41725: Add component deployment diagram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 8:53 p.m.) Review request for Aurora, Jay Buffington and Bill Farner. Changes --- Add connection from user to observer Bugs: AURORA-852 https://issues.apache.org/jira/browse/AURORA-852 Repository: aurora Description --- FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing their communication paths and deployment. Given that this manual is targeting beginners, the diagram sacrifices completeness in order to stay simple. Diffs (updated) - .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 docs/images/components.odg PRE-CREATION docs/images/components.png PRE-CREATION docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 Diff: https://reviews.apache.org/r/41725/diff/ Testing --- Rendered page is available at https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md File Attachments Components https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png Thanks, Stephan Erb
Re: Review Request 41725: Add component deployment diagram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 5:23 p.m.) Review request for Aurora, Jay Buffington and Bill Farner. Changes --- Upload image for easier viewing. Bugs: AURORA-852 https://issues.apache.org/jira/browse/AURORA-852 Repository: aurora Description --- FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing their communication paths and deployment. Given that this manual is targeting beginners, the diagram sacrifices completeness in order to stay simple. Diffs - .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 docs/images/components.odg PRE-CREATION docs/images/components.png PRE-CREATION docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 Diff: https://reviews.apache.org/r/41725/diff/ Testing --- Rendered page is available at https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md File Attachments (updated) Components https://reviews.apache.org/media/uploaded/files/2015/12/26/cca230da-a6c8-4957-890d-1c7b24e0604d__components.png Thanks, Stephan Erb
Re: Review Request 41725: Add component deployment diagram
> On Dec. 26, 2015, 5:31 p.m., Aurora ReviewBot wrote: > > This patch does not apply cleanly against master (1ae77d5), do you need to > > rebase? > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" The changes are already based on the recent master. Maybe this issue is due to the `.gitattribute` changes? It was necessary to commit png's without git messing up the line endings. Any idea? - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111905 --- On Dec. 26, 2015, 5:23 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 5:23 p.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/cca230da-a6c8-4957-890d-1c7b24e0604d__components.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 41725: Add component deployment diagram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111905 --- This patch does not apply cleanly against master (1ae77d5), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 26, 2015, 4:23 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41725/ > --- > > (Updated Dec. 26, 2015, 4:23 p.m.) > > > Review request for Aurora, Jay Buffington and Bill Farner. > > > Bugs: AURORA-852 > https://issues.apache.org/jira/browse/AURORA-852 > > > Repository: aurora > > > Description > --- > > FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing > their communication paths and deployment. > > Given that this manual is targeting beginners, the diagram sacrifices > completeness in order to stay simple. > > > Diffs > - > > .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 > docs/images/components.odg PRE-CREATION > docs/images/components.png PRE-CREATION > docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 > > Diff: https://reviews.apache.org/r/41725/diff/ > > > Testing > --- > > Rendered page is available at > https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md > > > File Attachments > > > Components > > https://reviews.apache.org/media/uploaded/files/2015/12/26/cca230da-a6c8-4957-890d-1c7b24e0604d__components.png > > > Thanks, > > Stephan Erb > >
