Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111932 --- Ship it! Thanks, this is a great addition! Since i can't use

Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread John Sirois
> On Dec. 27, 2015, 1:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to

Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread Stephan Erb
> On Dec. 27, 2015, 9:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to

Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread Bill Farner
> On Dec. 27, 2015, 12:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to

Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread John Sirois
> On Dec. 27, 2015, 1:32 p.m., Bill Farner wrote: > > Thanks, this is a great addition! Since i can't use `rbt` to apply this > > patch, i'll pull it from your branch on github instead. Can you squash > > that branch to a single commit? I'd like to just cherry-pick your commit > > to

Re: Review Request 41725: Add component deployment diagram

2015-12-27 Thread Bill Farner
> On Dec. 26, 2015, 8:31 a.m., Aurora ReviewBot wrote: > > This patch does not apply cleanly against master (1ae77d5), do you need to > > rebase? > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > Stephan Erb wrote: > The changes are

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 8:52 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 8:53 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/ --- (Updated Dec. 26, 2015, 5:23 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Stephan Erb
> On Dec. 26, 2015, 5:31 p.m., Aurora ReviewBot wrote: > > This patch does not apply cleanly against master (1ae77d5), do you need to > > rebase? > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" The changes are already based on the recent

Re: Review Request 41725: Add component deployment diagram

2015-12-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41725/#review111905 --- This patch does not apply cleanly against master (1ae77d5), do you