Re: Review Request 46103: Revert "Revert "Add support for storing and fetching images as properties of task configs.""

2016-04-12 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46103/
---

(Updated April 12, 2016, 5:37 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

- Add explicit instructions to make DB changes to schema.sql *and* to the 
migrations in db-migrations.md
- Add `IF NOT EXISTS` to drop table statements.
- Fix spacing in mapper xml.


Repository: aurora


Description
---

This reverts commit b5c9e1bc46a623b5d898ec4dacbe132b79903dd7 and layers the 
changes needed to support DB migrations on top as well.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
fc038d7950fb3c9379ab52d1fc32433ce9f692d1 
  config/checkstyle/suppressions.xml d9fe92a786b9f077d915a516d21217a7c0cd5027 
  docs/development/db-migration.md bddfee127c46072153a5c4c46ffdff0e507ae206 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 68573ba15ff886ca0a47f09decda3b6743b80243 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
7c1127e537133670dd6e04045c1779a3aee4f2c3 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
364026a8ef2b47cf1beafa3990691d3375516fe6 
  src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
12ca16b79a062d9ea15c206ef963fb077ad7ad98 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V001_CreateAppcImagesTable.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V002_CreateDockerImagesTable.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
eb848add00fba6d3571657bb9080be0599b2756a 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
52189677a0ad81a26ee4887d1f49cb449c32872c 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
be60c3be0cd51d06ba0ca7f56384281ee71d8c55 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 ecd48ecc87428961b879aede0005a009d82d0858 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 
c316e497a34a45c7ada2ca83a1115e826c0f572f 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
5895afad6952357afed592580d15c05fe526003f 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
08530397ff75081bde6f07f9d53317b5486e0da4 

Diff: https://reviews.apache.org/r/46103/diff/


Testing
---

./gradlew build -Pq
Ran e2e tests.


Thanks,

Joshua Cohen

Re: Review Request 46103: Revert "Revert "Add support for storing and fetching images as properties of task configs.""

2016-04-12 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46103/#review128458
---


Ship it!





docs/development/db-migration.md (lines 30 - 33)


Probably worth mentioning explicitly that schema.sql should always be kept 
up-to-date to ensure clean scheduler deploy always works.



src/main/java/org/apache/aurora/scheduler/storage/db/migration/V001_CreateAppcImagesTable.java
 (line 44)


I'd use `DROP TABLE IF EXISTS` instead as a more robust default.



src/main/java/org/apache/aurora/scheduler/storage/db/migration/V002_CreateDockerImagesTable.java
 (line 44)


same here



src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 
(line 336)


spacing seems to be off


- Maxim Khutornenko


On April 12, 2016, 4:22 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46103/
> ---
> 
> (Updated April 12, 2016, 4:22 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This reverts commit b5c9e1bc46a623b5d898ec4dacbe132b79903dd7 and layers the 
> changes needed to support DB migrations on top as well.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> fc038d7950fb3c9379ab52d1fc32433ce9f692d1 
>   config/checkstyle/suppressions.xml d9fe92a786b9f077d915a516d21217a7c0cd5027 
>   docs/development/db-migration.md bddfee127c46072153a5c4c46ffdff0e507ae206 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  68573ba15ff886ca0a47f09decda3b6743b80243 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> 7c1127e537133670dd6e04045c1779a3aee4f2c3 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 
> 364026a8ef2b47cf1beafa3990691d3375516fe6 
>   src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 
> 12ca16b79a062d9ea15c206ef963fb077ad7ad98 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V001_CreateAppcImagesTable.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V002_CreateDockerImagesTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbImage.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 
> eb848add00fba6d3571657bb9080be0599b2756a 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml
>  52189677a0ad81a26ee4887d1f49cb449c32872c 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> be60c3be0cd51d06ba0ca7f56384281ee71d8c55 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ecd48ecc87428961b879aede0005a009d82d0858 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
>  c316e497a34a45c7ada2ca83a1115e826c0f572f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 5895afad6952357afed592580d15c05fe526003f 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
> 
> Diff: https://reviews.apache.org/r/46103/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> Ran e2e tests.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>