Re: Review Request 49528: Patch thrift to compile under modern gcc.

2016-07-04 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140671
---




build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
 (line 8)


This is a bug - should be `if (!first) {`.  We don't hit this bug since we 
don't declare thrift service exceptions, but I'll circle back with a fix for 
sanity sake.


- John Sirois


On July 1, 2016, 1:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> ---
> 
> (Updated July 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
> https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch  
> | 376 ++
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  |  14 ++
>  build-support/thrift/Makefile
> |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> PRE-CREATION 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> ---
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49528: Patch thrift to compile under modern gcc.

2016-07-01 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140417
---


Ship it!




Master (b3f88bc) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 1, 2016, 7:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> ---
> 
> (Updated July 1, 2016, 7:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
> https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch  
> | 376 ++
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  |  14 ++
>  build-support/thrift/Makefile
> |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> PRE-CREATION 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> ---
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49528: Patch thrift to compile under modern gcc.

2016-07-01 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140414
---



NB: With the `Makefile.in` patch, there are new WARNINGS generated like so:
```
make[4]: Entering directory 
'/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial'
../compiler/cpp/thrift --gen html -r ../tutorial/tutorial.thrift
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/shared.thrift:25]
 No generator named 'cpp' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/shared.thrift:26]
 No generator named 'd' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/shared.thrift:28]
 No generator named 'perl' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/shared.thrift:29]
 No generator named 'php' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/tutorial.thrift:65]
 No generator named 'cpp' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/tutorial.thrift:66]
 No generator named 'd' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/tutorial.thrift:68]
 No generator named 'php' could be found!
[WARNING:/home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/tutorial/tutorial.thrift:69]
 No generator named 'perl' could be found!
```

To keep the patch simple, I'm treating these WARNINGs as acceptable noise.

- John Sirois


On July 1, 2016, 1:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> ---
> 
> (Updated July 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
> https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch  
> | 376 ++
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  |  14 ++
>  build-support/thrift/Makefile
> |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> PRE-CREATION 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> ---
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 49528: Patch thrift to compile under modern gcc.

2016-07-01 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140413
---


Ship it!




Thanks!

- Maxim Khutornenko


On July 1, 2016, 7:28 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> ---
> 
> (Updated July 1, 2016, 7:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
> https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch  
> | 376 ++
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  |  14 ++
>  build-support/thrift/Makefile
> |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> PRE-CREATION 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> ---
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>