Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109348
---


Thanks for following up! Minor change left before we can ship it.


src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 (line 71)


s/public/private

Also, please move it to the end of the file as we tend to keep private 
helpers there.


- Maxim Khutornenko


On Dec. 8, 2015, 3:46 a.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 3:46 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Tengfei Mu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/
---

(Updated Dec. 8, 2015, 8:31 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

make helper func private.


Bugs: AURORA-1547
https://issues.apache.org/jira/browse/AURORA-1547


Repository: aurora


Description
---

set TaskStatus.slave_id field in TaskReconsiler


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
c797914ded51cd123dddef188373fe58e190773a 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 1308a1c9884e7759e6139787710b367bbf9cd4e9 

Diff: https://reviews.apache.org/r/41048/diff/


Testing
---

./gradlew -Pq build


Thanks,

Tengfei Mu

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 


> On Dec. 8, 2015, 8:40 p.m., Maxim Khutornenko wrote:
> > Ship It!

Will merge once ReviewBot catches up.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109383
---


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109383
---

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109390
---

Ship it!


Master (2e23714) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 8, 2015, 8:31 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 8:31 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109181
---


Master (676ee5b) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java:155:
 error: Line is longer than 100 characters (found 101).
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 2 mins 6.427 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 7, 2015, 7:16 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 7, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Tengfei Mu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/
---

(Updated Dec. 7, 2015, 7:22 p.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

Added testing done section. Add Maxim as reviewer.


Repository: aurora


Description
---

set TaskStatus.slave_id field in TaskReconsiler


Diffs
-

  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
c797914ded51cd123dddef188373fe58e190773a 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 1308a1c9884e7759e6139787710b367bbf9cd4e9 

Diff: https://reviews.apache.org/r/41048/diff/


Testing (updated)
---

./gradlew -Pq build


Thanks,

Tengfei Mu

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Tengfei Mu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/
---

(Updated Dec. 7, 2015, 7:28 p.m.)


Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

set TaskStatus.slave_id field in TaskReconsiler


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 
  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
c797914ded51cd123dddef188373fe58e190773a 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 1308a1c9884e7759e6139787710b367bbf9cd4e9 

Diff: https://reviews.apache.org/r/41048/diff/


Testing
---

./gradlew -Pq build


Thanks,

Tengfei Mu

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109185
---

Ship it!


Master (676ee5b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 7, 2015, 7:30 p.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 7, 2015, 7:30 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> 2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Tengfei Mu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/
---

(Updated Dec. 8, 2015, 3:46 a.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
---

address maxim's comment


Bugs: AURORA-1547
https://issues.apache.org/jira/browse/AURORA-1547


Repository: aurora


Description
---

set TaskStatus.slave_id field in TaskReconsiler


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
c797914ded51cd123dddef188373fe58e190773a 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 1308a1c9884e7759e6139787710b367bbf9cd4e9 

Diff: https://reviews.apache.org/r/41048/diff/


Testing
---

./gradlew -Pq build


Thanks,

Tengfei Mu

Re: Review Request 41048: set TaskStatus.slave_id field in TaskReconsiler

2015-12-07 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41048/#review109271
---

Ship it!


Master (d7a1619) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 8, 2015, 3:46 a.m., Tengfei Mu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41048/
> ---
> 
> (Updated Dec. 8, 2015, 3:46 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1547
> https://issues.apache.org/jira/browse/AURORA-1547
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> set TaskStatus.slave_id field in TaskReconsiler
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> c797914ded51cd123dddef188373fe58e190773a 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  1308a1c9884e7759e6139787710b367bbf9cd4e9 
> 
> Diff: https://reviews.apache.org/r/41048/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Tengfei Mu
> 
>