Re: Review Request 45721: thermos local-time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/#review130023 --- Se Choi, I wanted to wake this thread and see if you intended to proceed with this review or not. - John Sirois On April 5, 2016, 1:58 p.m., se choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45721/ > --- > > (Updated April 5, 2016, 1:58 p.m.) > > > Review request for Aurora, Joshua Cohen, John Sirois, and Stephan Erb. > > > Repository: aurora > > > Description > --- > > thermos local-time > > 1. Scheduler display +09:00 (Locale timezone) > 2. Thermos Observer display on UTC (+00:00) > > > Diffs > - > > src/main/python/apache/thermos/observer/http/templates/main.tpl > b905699897254b4a3ff6a3d03a072ac24d56e929 > src/main/python/apache/thermos/observer/http/templates/process.tpl > 4ca52bac41e638bb26c17bddee0d8946df895522 > src/main/python/apache/thermos/observer/http/templates/task.tpl > f3e06985eb3c05572aa4389d97da575b1179f616 > > Diff: https://reviews.apache.org/r/45721/diff/ > > > Testing > --- > > > Thanks, > > se choi > >
Re: Review Request 45721: thermos local-time
> On April 5, 2016, 2:17 a.m., John Sirois wrote: > > Do you have any thoughts on why localtime should be the winner here? > > > > Imagine these scenarios: > > You're an operator for a cluster that lives 3 timezones away > > You're an operator for 3 clusters, each in different timezones. > > > > I'm not sure which is better, local time or UTC, but for non-trivial > > setups, UTC is at least more neutral in general. > > > > This is not a string argument one way or the other, but calling the shot on > > the choice would be a good addition to the RB (and eventual commit) > > description IMO. > > Stephan Erb wrote: > To make matters worse, we also have the cron timezone which defaults to > `GMT` :-) I'd prefer we stick with UTC over local time for the sake of consistency. If people feel strongly that local time should be an option, I'd be ok with adding a flag to configure the behavior. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/#review127008 --- On April 5, 2016, 1:32 a.m., se choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45721/ > --- > > (Updated April 5, 2016, 1:32 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > thermos local-time > > 1. Scheduler display +09:00 (Locale timezone) > 2. Thermos Observer display on UTC (+00:00) > > > Diffs > - > > src/main/python/apache/thermos/observer/http/templates/main.tpl > b905699897254b4a3ff6a3d03a072ac24d56e929 > src/main/python/apache/thermos/observer/http/templates/process.tpl > 4ca52bac41e638bb26c17bddee0d8946df895522 > src/main/python/apache/thermos/observer/http/templates/task.tpl > f3e06985eb3c05572aa4389d97da575b1179f616 > > Diff: https://reviews.apache.org/r/45721/diff/ > > > Testing > --- > > > Thanks, > > se choi > >
Re: Review Request 45721: thermos local-time
> On April 5, 2016, 4:17 a.m., John Sirois wrote: > > Do you have any thoughts on why localtime should be the winner here? > > > > Imagine these scenarios: > > You're an operator for a cluster that lives 3 timezones away > > You're an operator for 3 clusters, each in different timezones. > > > > I'm not sure which is better, local time or UTC, but for non-trivial > > setups, UTC is at least more neutral in general. > > > > This is not a string argument one way or the other, but calling the shot on > > the choice would be a good addition to the RB (and eventual commit) > > description IMO. To make matters worse, we also have the cron timezone which defaults to `GMT` :-) - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/#review127008 --- On April 5, 2016, 3:32 a.m., se choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45721/ > --- > > (Updated April 5, 2016, 3:32 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > thermos local-time > > 1. Scheduler display +09:00 (Locale timezone) > 2. Thermos Observer display on UTC (+00:00) > > > Diffs > - > > src/main/python/apache/thermos/observer/http/templates/main.tpl > b905699897254b4a3ff6a3d03a072ac24d56e929 > src/main/python/apache/thermos/observer/http/templates/process.tpl > 4ca52bac41e638bb26c17bddee0d8946df895522 > src/main/python/apache/thermos/observer/http/templates/task.tpl > f3e06985eb3c05572aa4389d97da575b1179f616 > > Diff: https://reviews.apache.org/r/45721/diff/ > > > Testing > --- > > > Thanks, > > se choi > >
Re: Review Request 45721: thermos local-time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/#review127008 --- Do you have any thoughts on why localtime should be the winner here? Imagine these scenarios: You're an operator for a cluster that lives 3 timezones away You're an operator for 3 clusters, each in different timezones. I'm not sure which is better, local time or UTC, but for non-trivial setups, UTC is at least more neutral in general. This is not a string argument one way or the other, but calling the shot on the choice would be a good addition to the RB (and eventual commit) description IMO. - John Sirois On April 4, 2016, 7:32 p.m., se choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45721/ > --- > > (Updated April 4, 2016, 7:32 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > thermos local-time > > 1. Scheduler display +09:00 (Locale timezone) > 2. Thermos Observer display on UTC (+00:00) > > > Diffs > - > > src/main/python/apache/thermos/observer/http/templates/main.tpl > b905699897254b4a3ff6a3d03a072ac24d56e929 > src/main/python/apache/thermos/observer/http/templates/process.tpl > 4ca52bac41e638bb26c17bddee0d8946df895522 > src/main/python/apache/thermos/observer/http/templates/task.tpl > f3e06985eb3c05572aa4389d97da575b1179f616 > > Diff: https://reviews.apache.org/r/45721/diff/ > > > Testing > --- > > > Thanks, > > se choi > >
Re: Review Request 45721: thermos local-time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/#review127003 --- Master (f402899) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 5, 2016, 1:32 a.m., se choi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45721/ > --- > > (Updated April 5, 2016, 1:32 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > thermos local-time > > 1. Scheduler display +09:00 (Locale timezone) > 2. Thermos Observer display on UTC (+00:00) > > > Diffs > - > > src/main/python/apache/thermos/observer/http/templates/main.tpl > b905699897254b4a3ff6a3d03a072ac24d56e929 > src/main/python/apache/thermos/observer/http/templates/process.tpl > 4ca52bac41e638bb26c17bddee0d8946df895522 > src/main/python/apache/thermos/observer/http/templates/task.tpl > f3e06985eb3c05572aa4389d97da575b1179f616 > > Diff: https://reviews.apache.org/r/45721/diff/ > > > Testing > --- > > > Thanks, > > se choi > >
Review Request 45721: thermos local-time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45721/ --- Review request for Aurora. Repository: aurora Description --- thermos local-time 1. Scheduler display +09:00 (Locale timezone) 2. Thermos Observer display on UTC (+00:00) Diffs - src/main/python/apache/thermos/observer/http/templates/main.tpl b905699897254b4a3ff6a3d03a072ac24d56e929 src/main/python/apache/thermos/observer/http/templates/process.tpl 4ca52bac41e638bb26c17bddee0d8946df895522 src/main/python/apache/thermos/observer/http/templates/task.tpl f3e06985eb3c05572aa4389d97da575b1179f616 Diff: https://reviews.apache.org/r/45721/diff/ Testing --- Thanks, se choi
