Re: Review Request 51664: Document the Mesos containerizer

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/
---

(Updated Sept. 9, 2016, 10:05 a.m.)


Review request for Aurora and Joshua Cohen.


Changes
---

Review changes


Bugs: AURORA-1640
https://issues.apache.org/jira/browse/AURORA-1640


Repository: aurora


Description
---

Included changes:

* enabled Docker support in our vagrant box
* consistent example jobs for both containerizers
* short enduser and operator  documentation
* shuffled the reference documentation so that it is clear certain limitations 
apply only to the Docker containerizer


Diffs (updated)
-

  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
  docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
  examples/jobs/docker/hello_docker.aurora 
d5611e6b78cb613c04e2fc3df54397ee4401a62e 
  examples/jobs/hello_docker_image.aurora PRE-CREATION 
  examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
  examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
7168c0ca4a81e0a1ce2320534015c6692b804b54 
  examples/vagrant/mesos_config/etc_mesos-slave/isolation 
c36223028513ace26040620b813022accaf0edf3 

Diff: https://reviews.apache.org/r/51664/diff/


Testing
---

Rendered version available at 
https://github.com/StephanErb/aurora/tree/containerizer-docs/docs


Thanks,

Stephan Erb

Re: Review Request 51664: Document the Mesos containerizer

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review148283
---


Ship it!




Master (87ae968) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review148279
---



@ReviewBot retry

- Joshua Cohen


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review148185
---


Ship it!




lgtm modulo the below.


docs/operations/configuration.md (line 32)


s/pulbic/public



docs/operations/configuration.md (line 137)


"Both the Mesos and Docker containerizers"



docs/operations/configuration.md (lines 158 - 159)


s/to pass//


- Joshua Cohen


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147914
---


Ship it!




Master (0c90c86) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147908
---




docs/features/containers.md (lines 55 - 56)


Add a sentence to indicate that:

`Otherwise, this user and its primary group has to exist in the image with 
matching uid/gip`


- Zhitao Li


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Zhitao Li]

> On Sept. 6, 2016, 8 p.m., Zhitao Li wrote:
> > docs/features/containers.md, lines 55-56
> > 
> >
> > Add a sentence to indicate that:
> > 
> > `Otherwise, this user and its primary group has to exist in the image 
> > with matching uid/gip`

Sorry for typo, should be `uid/gid.`


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147908
---


On Sept. 6, 2016, 7:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 7:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51664: Document the Mesos containerizer

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/#review147898
---




docs/operations/configuration.md (line 34)


This is unrelated to the rest of the changeset. I noticed we are missing 
this crucial option in our docs which can cause peroblems if left unspecified.



examples/vagrant/aurorabuild.sh 


This line has no effect as we are already using Java 8.


- Stephan Erb


On Sept. 6, 2016, 9:18 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51664/
> ---
> 
> (Updated Sept. 6, 2016, 9:18 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1640
> https://issues.apache.org/jira/browse/AURORA-1640
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included changes:
> 
> * enabled Docker support in our vagrant box
> * consistent example jobs for both containerizers
> * short enduser and operator  documentation
> * shuffled the reference documentation so that it is clear certain 
> limitations apply only to the Docker containerizer
> 
> 
> Diffs
> -
> 
>   docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
>   docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
>   docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
>   examples/jobs/docker/hello_docker.aurora 
> d5611e6b78cb613c04e2fc3df54397ee4401a62e 
>   examples/jobs/hello_docker_image.aurora PRE-CREATION 
>   examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
>   examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
> 7168c0ca4a81e0a1ce2320534015c6692b804b54 
>   examples/vagrant/mesos_config/etc_mesos-slave/isolation 
> c36223028513ace26040620b813022accaf0edf3 
> 
> Diff: https://reviews.apache.org/r/51664/diff/
> 
> 
> Testing
> ---
> 
> Rendered version available at 
> https://github.com/StephanErb/aurora/tree/containerizer-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 51664: Document the Mesos containerizer

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51664/
---

Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1640
https://issues.apache.org/jira/browse/AURORA-1640


Repository: aurora


Description
---

Included changes:

* enabled Docker support in our vagrant box
* consistent example jobs for both containerizers
* short enduser and operator  documentation
* shuffled the reference documentation so that it is clear certain limitations 
apply only to the Docker containerizer


Diffs
-

  docs/features/containers.md 6b9f717d672ef88be61341268f9c06923d217087 
  docs/operations/configuration.md 85787b0815e9f0cb37c21efc04923b0e0bd10bf9 
  docs/reference/configuration.md ff40262f1fb4eff780fbef17abcaecc457dc68d3 
  examples/jobs/docker/hello_docker.aurora 
d5611e6b78cb613c04e2fc3df54397ee4401a62e 
  examples/jobs/hello_docker_image.aurora PRE-CREATION 
  examples/vagrant/aurorabuild.sh 9daca067acc05c89ccc183e56bf30c787baf97dd 
  examples/vagrant/mesos_config/etc_mesos-slave/image_providers 
7168c0ca4a81e0a1ce2320534015c6692b804b54 
  examples/vagrant/mesos_config/etc_mesos-slave/isolation 
c36223028513ace26040620b813022accaf0edf3 

Diff: https://reviews.apache.org/r/51664/diff/


Testing
---

Rendered version available at 
https://github.com/StephanErb/aurora/tree/containerizer-docs/docs


Thanks,

Stephan Erb