Re: Review Request 52453: Add a patch that links client and executor change

2016-09-30 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151098
---



Master (ed72b1b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 9:52 p.m., Kai Huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52453/
> ---
> 
> (Updated Sept. 30, 2016, 9:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Add support for receiving a new HealthCheckConfig attribute 
> "min_consecutive_successes" in health checker.
> - Add an entry in release note that describes the health check driven update 
> feature.
> 
> This patch is related to https://reviews.apache.org/r/52094/, in which I 
> added a new configuration value "min_consecutive_successes" in 
> HealthCheckConfig.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8 
> 
> Diff: https://reviews.apache.org/r/52453/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>



Review Request 52453: Add a patch that links client and executor change

2016-09-30 Thread Kai Huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/
---

Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-894
https://issues.apache.org/jira/browse/AURORA-894


Repository: aurora


Description
---

- Add support for receiving a new HealthCheckConfig attribute 
"min_consecutive_successes" in health checker.
- Add an entry in release note that describes the health check driven update 
feature.

This patch is related to https://reviews.apache.org/r/52094/, in which I added 
a new configuration value "min_consecutive_successes" in HealthCheckConfig.


Diffs
-

  RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
  src/main/python/apache/aurora/executor/common/health_checker.py 
03fbffdc3862a94c2ba42c9b9e8f2be4094129b8 

Diff: https://reviews.apache.org/r/52453/diff/


Testing
---

./build-support/jenkins/build.sh

./pants test.pytest src/test/python/apache/aurora/executor::

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Kai Huang