Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-13 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52776/
---

(Updated Oct. 13, 2016, 9:50 a.m.)


Review request for Aurora and Zameer Manji.


Repository: aurora


Description (updated)
---

We are already applying a blanking of `ExecutorConfig` objects for any API call 
with a `JobConfiguration` argument. We now extend this filtering to also 
consider `JobUpdateRequest` objects. 

Example log message with blanked config.
```
I1012 08:32:59.841 [qtp713342922-40, LoggingInterceptor:78] 
startJobUpdate(JobUpdateRequest(taskConfig:TaskConfig(job:JobKey(role:www-data, 
environment:prod, name:hello), owner:Identity(user:vagrant), isService:true, 
numCpus:1.0, ramMb:128, diskMb:128, priority:0, maxTaskFailures:1, 
production:false, tier:preemptible, resources:[], constraints:[], 
requestedPorts:[], taskLinks:{}, executorConfig:ExecutorConfig(name:BLANKED, 
data:BLANKED), metadata:[], container:), 
instanceCount:1, settings:JobUpdateSettings(updateGroupSize:1, 
maxPerInstanceFailures:0, maxFailedInstances:0, 
minWaitInInstanceRunningMs:45000, rollbackOnFailure:true, 
updateOnlyTheseInstances:null, waitForBatchCompletion:false), 
metadata:[Metadata(key:org.apache.aurora.client.update_id, 
value:773ae166-bd77-4b07-8368-62473aecd67e)]), null)
```


Diffs
-

  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
e0d6c564aa9705228ec4423ffee7cdd435b86d0d 

Diff: https://reviews.apache.org/r/52776/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52776/#review152371
---


Ship it!




Ship It!

- Zameer Manji


On Oct. 12, 2016, 1:46 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52776/
> ---
> 
> (Updated Oct. 12, 2016, 1:46 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> We are already applying a blanking of `ExecutorConfig` objects for any API 
> call with a `JobConfiguration` argument. We now extend this filtering to also 
> consider `JobUpdateRequest` objects. 
> 
> Example log message with blanked conifg.
> ```
> I1012 08:32:59.841 [qtp713342922-40, LoggingInterceptor:78] 
> startJobUpdate(JobUpdateRequest(taskConfig:TaskConfig(job:JobKey(role:www-data,
>  environment:prod, name:hello), owner:Identity(user:vagrant), isService:true, 
> numCpus:1.0, ramMb:128, diskMb:128, priority:0, maxTaskFailures:1, 
> production:false, tier:preemptible, resources:[], constraints:[], 
> requestedPorts:[], taskLinks:{}, executorConfig:ExecutorConfig(name:BLANKED, 
> data:BLANKED), metadata:[], container:), 
> instanceCount:1, settings:JobUpdateSettings(updateGroupSize:1, 
> maxPerInstanceFailures:0, maxFailedInstances:0, 
> minWaitInInstanceRunningMs:45000, rollbackOnFailure:true, 
> updateOnlyTheseInstances:null, waitForBatchCompletion:false), 
> metadata:[Metadata(key:org.apache.aurora.client.update_id, 
> value:773ae166-bd77-4b07-8368-62473aecd67e)]), null)
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> e0d6c564aa9705228ec4423ffee7cdd435b86d0d 
> 
> Diff: https://reviews.apache.org/r/52776/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52776/#review152338
---


Ship it!





src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
(line 59)


Pull this out to a constant and reuse it between here and the 
`JobConfiguration` case?


- Joshua Cohen


On Oct. 12, 2016, 8:46 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52776/
> ---
> 
> (Updated Oct. 12, 2016, 8:46 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> We are already applying a blanking of `ExecutorConfig` objects for any API 
> call with a `JobConfiguration` argument. We now extend this filtering to also 
> consider `JobUpdateRequest` objects. 
> 
> Example log message with blanked conifg.
> ```
> I1012 08:32:59.841 [qtp713342922-40, LoggingInterceptor:78] 
> startJobUpdate(JobUpdateRequest(taskConfig:TaskConfig(job:JobKey(role:www-data,
>  environment:prod, name:hello), owner:Identity(user:vagrant), isService:true, 
> numCpus:1.0, ramMb:128, diskMb:128, priority:0, maxTaskFailures:1, 
> production:false, tier:preemptible, resources:[], constraints:[], 
> requestedPorts:[], taskLinks:{}, executorConfig:ExecutorConfig(name:BLANKED, 
> data:BLANKED), metadata:[], container:), 
> instanceCount:1, settings:JobUpdateSettings(updateGroupSize:1, 
> maxPerInstanceFailures:0, maxFailedInstances:0, 
> minWaitInInstanceRunningMs:45000, rollbackOnFailure:true, 
> updateOnlyTheseInstances:null, waitForBatchCompletion:false), 
> metadata:[Metadata(key:org.apache.aurora.client.update_id, 
> value:773ae166-bd77-4b07-8368-62473aecd67e)]), null)
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> e0d6c564aa9705228ec4423ffee7cdd435b86d0d 
> 
> Diff: https://reviews.apache.org/r/52776/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52776/#review152285
---



Master (e9abb22) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 12, 2016, 8:46 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52776/
> ---
> 
> (Updated Oct. 12, 2016, 8:46 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> We are already applying a blanking of `ExecutorConfig` objects for any API 
> call with a `JobConfiguration` argument. We now extend this filtering to also 
> consider `JobUpdateRequest` objects. 
> 
> Example log message with blanked conifg.
> ```
> I1012 08:32:59.841 [qtp713342922-40, LoggingInterceptor:78] 
> startJobUpdate(JobUpdateRequest(taskConfig:TaskConfig(job:JobKey(role:www-data,
>  environment:prod, name:hello), owner:Identity(user:vagrant), isService:true, 
> numCpus:1.0, ramMb:128, diskMb:128, priority:0, maxTaskFailures:1, 
> production:false, tier:preemptible, resources:[], constraints:[], 
> requestedPorts:[], taskLinks:{}, executorConfig:ExecutorConfig(name:BLANKED, 
> data:BLANKED), metadata:[], container:), 
> instanceCount:1, settings:JobUpdateSettings(updateGroupSize:1, 
> maxPerInstanceFailures:0, maxFailedInstances:0, 
> minWaitInInstanceRunningMs:45000, rollbackOnFailure:true, 
> updateOnlyTheseInstances:null, waitForBatchCompletion:false), 
> metadata:[Metadata(key:org.apache.aurora.client.update_id, 
> value:773ae166-bd77-4b07-8368-62473aecd67e)]), null)
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> e0d6c564aa9705228ec4423ffee7cdd435b86d0d 
> 
> Diff: https://reviews.apache.org/r/52776/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52776/
---

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
---

We are already applying a blanking of `ExecutorConfig` objects for any API call 
with a `JobConfiguration` argument. We now extend this filtering to also 
consider `JobUpdateRequest` objects. 

Example log message with blanked conifg.
```
I1012 08:32:59.841 [qtp713342922-40, LoggingInterceptor:78] 
startJobUpdate(JobUpdateRequest(taskConfig:TaskConfig(job:JobKey(role:www-data, 
environment:prod, name:hello), owner:Identity(user:vagrant), isService:true, 
numCpus:1.0, ramMb:128, diskMb:128, priority:0, maxTaskFailures:1, 
production:false, tier:preemptible, resources:[], constraints:[], 
requestedPorts:[], taskLinks:{}, executorConfig:ExecutorConfig(name:BLANKED, 
data:BLANKED), metadata:[], container:), 
instanceCount:1, settings:JobUpdateSettings(updateGroupSize:1, 
maxPerInstanceFailures:0, maxFailedInstances:0, 
minWaitInInstanceRunningMs:45000, rollbackOnFailure:true, 
updateOnlyTheseInstances:null, waitForBatchCompletion:false), 
metadata:[Metadata(key:org.apache.aurora.client.update_id, 
value:773ae166-bd77-4b07-8368-62473aecd67e)]), null)
```


Diffs
-

  src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
e0d6c564aa9705228ec4423ffee7cdd435b86d0d 

Diff: https://reviews.apache.org/r/52776/diff/


Testing
---

./gradlew -Pq build


Thanks,

Stephan Erb