Re: Review Request 64283: Remove redundant transaction recorder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64283/#review192643 --- Ship it! Ship It! - Stephan Erb On Dez. 3, 2017, 6:53 vorm., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64283/ > --- > > (Updated Dez. 3, 2017, 6:53 vorm.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > --- > > I missed this in https://reviews.apache.org/r/64234/. The intention of the > newly-introduced `TransactionRecorder` was to replace the code removed here. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java > a0a6b6c7270d2b7f5eae2ea218e17b929f9bbd53 > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java > 18da32daf4a86966c67fd5c6673b32497ccb8f35 > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > c5b107fe98597bb38589d654bbd619e7ad15b62b > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java > a51fd18ad00537bf244419442078548d8545a841 > src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java > cb38f107385997b091c3b65db3a13f9cca0fa42d > > > Diff: https://reviews.apache.org/r/64283/diff/1/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Re: Review Request 64283: Remove redundant transaction recorder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64283/#review192641 --- Ship it! Master (cea43db) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 2, 2017, 9:53 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64283/ > --- > > (Updated Dec. 2, 2017, 9:53 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > --- > > I missed this in https://reviews.apache.org/r/64234/. The intention of the > newly-introduced `TransactionRecorder` was to replace the code removed here. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java > a0a6b6c7270d2b7f5eae2ea218e17b929f9bbd53 > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java > 18da32daf4a86966c67fd5c6673b32497ccb8f35 > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > c5b107fe98597bb38589d654bbd619e7ad15b62b > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java > a51fd18ad00537bf244419442078548d8545a841 > src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java > cb38f107385997b091c3b65db3a13f9cca0fa42d > > > Diff: https://reviews.apache.org/r/64283/diff/1/ > > > Testing > --- > > > Thanks, > > Bill Farner > >
Review Request 64283: Remove redundant transaction recorder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64283/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description --- I missed this in https://reviews.apache.org/r/64234/. The intention of the newly-introduced `TransactionRecorder` was to replace the code removed here. Diffs - src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java a0a6b6c7270d2b7f5eae2ea218e17b929f9bbd53 src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 18da32daf4a86966c67fd5c6673b32497ccb8f35 src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java c5b107fe98597bb38589d654bbd619e7ad15b62b src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java a51fd18ad00537bf244419442078548d8545a841 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java cb38f107385997b091c3b65db3a13f9cca0fa42d Diff: https://reviews.apache.org/r/64283/diff/1/ Testing --- Thanks, Bill Farner
