Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33279/#review81512 --- Ping - Maxim, can you check my replies above? - Bill Farner On

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-24 Thread Maxim Khutornenko
On April 24, 2015, 6:35 p.m., Bill Farner wrote: Ping - Maxim, can you check my replies above? My plan is to avoid changing behavior with the task store, so i did not have any intention of removing fields. Sorry, I was under assumption your decided to address the user part. Not storing it

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-20 Thread Bill Farner
On April 20, 2015, 5:50 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 179 https://reviews.apache.org/r/33279/diff/1/?file=932067#file932067line179 What are your plans on retaining the user part of the Identity struct

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33279/#review80409 --- Ship it! Ship It! - Kevin Sweeney On April 16, 2015, 3 p.m.,

Re: Review Request 33279: Add SQL tables needed for a datbase-backed task store.

2015-04-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33279/#review80387 --- Master (b18dc44) is green with this patch.