Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81836 --- src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java https://reviews.apache.org/r/33611/#comment132321 This benchmark is nearly identical to the role summary one. Any chance they could share common definitions? - Maxim Khutornenko On April 28, 2015, 12:57 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 12:57 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs (updated) - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81855 --- Ship it! Ship It! - Maxim Khutornenko On April 28, 2015, 6:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81853 --- Ship it! Master (e9d723d) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 28, 2015, 6:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81763 --- This is as far as i went towards getting some basic performance coverage for the database-backed task store. Since it will be enabled with a toggle, i stopped here so the initial diff is only required to pass functional tests, and we can then iterate on performance. - Bill Farner On April 28, 2015, 12:57 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 12:57 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
