Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 22, 2015, 10:42 p.m.) Review request for Aurora and Bill Farner. Changes --- Adding relevant issue. Bugs: AURORA-1396 https://issues.apache.org/jira/browse/AURORA-1396 Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70faa7125eee407fc57e8a297e18a51661f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165ad34e46653dad95918e0058ebd3f2ee57f src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31 Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:50 p.m.) Review request for Aurora and Bill Farner. Changes --- @ReviewBot retry Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70faa7125eee407fc57e8a297e18a51661f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165ad34e46653dad95918e0058ebd3f2ee57f src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31 Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92193 --- Ship it! Master (4eaacf7) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 18, 2015, 11:50 p.m., Mauricio Garavaglia wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:50 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70faa7125eee407fc57e8a297e18a51661f src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165ad34e46653dad95918e0058ebd3f2ee57f src/main/python/apache/aurora/config/schema/base.py d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c src/main/python/apache/aurora/config/thrift.py 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a src/test/python/apache/aurora/config/test_thrift.py f48ac88c076c12541626b497ca4fc47e5941dd31 Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 18, 2015, 11:30 p.m.) Review request for Aurora and Bill Farner. Changes --- @ReviewBot retry Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11 examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167 examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253 rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 src/jmh/java/org/apache/aurora/benchmark/Tasks.java d3e1295db9b933b5ab60d6446dfea453c6051795 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 3413b0a480073f39bc01a60bc93b211660d9e278 src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53 src/main/java/org/apache/aurora/GuiceUtils.java 5d0af1ebdccd0d0782f0fbc53d046a338c450167 src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 9e1f35a12205065f2f0cc783a49e14384bc4d50a src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7 src/main/java/org/apache/aurora/scheduler/TaskLauncher.java cd55a6ee7424873c3e615d95422c9ecab6442f46 src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c31446c447c3385a4763b8a516827988e46cc480 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java f0dea48b3df69dedf620a55573731ed9451369c3 src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java f5a18338748da7c443b2fd2ec3a72adf75e7387f src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java cd016af5621be76190ead81921096aae837b59c0 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java c1114a411c32c25785adc93e594ee8e291025969 src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b77b0ebbf303778e528b16ff3db1aa4e76f1 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java df180a4f9dff75a04ae104462c219444ef605d9a src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 770672c85c06aaf4356b3b3580428b0323edb9d3 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java bd74f892dde65e957f125a17979ee6c582b3043f src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java ecba276f1882162d9578e0829b2139040876c7d0 src/main/java/org/apache/aurora/scheduler/http/Cron.java fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review90994 --- Only nits remaining, and one request for test coverage. One final disclaimer on the security issue this creates - IIUC, arbitrary user-specified volume mounts opens up your cluster to privilege escalation. See this discussion for some detail: https://github.com/docker/docker/issues/3124, specifically this comment: ``` thaJeztah commented on May 23 @JWGmeligMeyling files and folders created in the volume will have the same uid:gid (numeric) as the user creating them in the container. If you add a user inside the container having the same uid:gid as outside the container and run your contsiner as that user, that should be possible ``` More direct coverage of the risk: https://fosterelli.co/privilege-escalation-via-docker.html http://reventlov.com/advisories/using-the-docker-command-to-root-the-host I'm happy to be proven wrong on this suspicion, but please confirm for yourself that this is safe to do. src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java (line 66) https://reviews.apache.org/r/34337/#comment144179 Matching the terminology above, how about s/enable/allow/? src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 186) https://reviews.apache.org/r/34337/#comment144183 I believe this throws an NPE when parameters is not set. Can you confirm/deny in a unit test case? src/main/python/apache/aurora/config/schema/base.py (line 97) https://reviews.apache.org/r/34337/#comment144186 I believe this should be ``` parameters = Default(List(Parameter), []) ``` to avoid requiring the argument. src/main/python/apache/aurora/config/thrift.py (lines 133 - 137) https://reviews.apache.org/r/34337/#comment144188 Please add a test case for this in `src/test/python/apache/aurora/config/test_thrift.py` - Bill Farner On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 docs/configuration-reference.md dafd306 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165a src/main/python/apache/aurora/config/schema/base.py d1f1e4f src/main/python/apache/aurora/config/thrift.py 88dd1c7 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 10:39 p.m.) Review request for Aurora and Bill Farner. Changes --- added argument to disable arbitrary docker parameters Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b77b0ebbf303778e528b16ff3db1aa4e76f1 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312 src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45 src/main/python/apache/aurora/config/thrift.py 810febb637d168b07c4aea77984e1d1451a39af2 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:58 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 docs/configuration-reference.md dafd306 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java be79e70 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165a src/main/python/apache/aurora/config/schema/base.py d1f1e4f src/main/python/apache/aurora/config/thrift.py 88dd1c7 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c0cadfb Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated July 5, 2015, 11:32 p.m.) Review request for Aurora and Bill Farner. Changes --- rebased. @ReviewBot retry Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b api/src/main/thrift/org/apache/aurora/gen/BUILD fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift a2c230fa9b5f648c4674042411cbe46fb8bb4faa config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11 examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167 examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253 rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 src/jmh/java/org/apache/aurora/benchmark/Tasks.java d3e1295db9b933b5ab60d6446dfea453c6051795 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 3413b0a480073f39bc01a60bc93b211660d9e278 src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53 src/main/java/org/apache/aurora/GuiceUtils.java 5d0af1ebdccd0d0782f0fbc53d046a338c450167 src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 9e1f35a12205065f2f0cc783a49e14384bc4d50a src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7 src/main/java/org/apache/aurora/scheduler/TaskLauncher.java cd55a6ee7424873c3e615d95422c9ecab6442f46 src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c31446c447c3385a4763b8a516827988e46cc480 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java f0dea48b3df69dedf620a55573731ed9451369c3 src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java f5a18338748da7c443b2fd2ec3a72adf75e7387f src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java cd016af5621be76190ead81921096aae837b59c0 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java c1114a411c32c25785adc93e594ee8e291025969 src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b77b0ebbf303778e528b16ff3db1aa4e76f1 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java df180a4f9dff75a04ae104462c219444ef605d9a src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 770672c85c06aaf4356b3b3580428b0323edb9d3 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java bd74f892dde65e957f125a17979ee6c582b3043f src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java ecba276f1882162d9578e0829b2139040876c7d0 src/main/java/org/apache/aurora/scheduler/http/Cron.java fd658e1ac5e73ef0c61c82685f6373c5f0eb6640
Re: Review Request 34337: Add Docker Parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/ --- (Updated June 20, 2015, 11:42 p.m.) Review request for Aurora and Bill Farner. Changes --- fix formatting issues Repository: aurora Description --- Support Arbitrary Docker Parameters in DockerContainer Diffs (updated) - api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90e7732f42b43a79f8cf0afe705c061539c docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312 src/main/python/apache/aurora/config/schema/base.py ec9f983564516afe542ab277d987d4d391f87e45 src/main/python/apache/aurora/config/thrift.py 810febb637d168b07c4aea77984e1d1451a39af2 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 Diff: https://reviews.apache.org/r/34337/diff/ Testing --- Used Docker as the container of a Job. Included volumes and label parameters which are correctly picked up by mesos when starting the task. The docker container gets the specified label and bind mounts the volumes correctly. I've been running multiple PostgreSQL databases docker containers for several weeks deploying them as aurora jobs. Thanks, Mauricio Garavaglia
