Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 11, 2015, 10:02 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 11, 2015, 10:29 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98627 --- This patch does not apply cleanly on master (1230029), do you need

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98297 --- Ship it! Master (a5ac5b9) is green with this patch.

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Bill Farner
> On Sept. 9, 2015, 2:39 p.m., Kevin Sweeney wrote: > > commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java, > > line 63 > > > > > > Looks like Modules.combine is redundant here. Thanks,

Re: Review Request 38014: Remove StartupRegistry.

2015-09-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98274 --- Ship it!

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98080 --- Ship it! Master (2773826) is green with this patch.

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 8, 2015, 2:49 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98118 --- @ReviewBot retry - Bill Farner On Sept. 8, 2015, 4:21 p.m., Bill

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 8, 2015, 4:21 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review98137 --- Ship it! I'm not very familiar with this code but after a careful

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 3, 2015, 4:38 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97698 --- This patch does not apply cleanly on master (9c0b1b2), do you need

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97319 --- Reviewer notes

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97322 --- src/main/java/org/apache/aurora/GuavaUtils.java (lines 114 - 124)

Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora

Re: Review Request 38014: Remove StartupRegistry.

2015-09-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 1, 2015, 11:59 a.m.) Review request for Aurora, Kevin Sweeney