Re: Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/#review97342
---


Master (5a7bd34) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 1, 2015, 9:27 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38018/
> ---
> 
> (Updated Sept. 1, 2015, 9:27 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was missed when I added the instance page. The redirect in the instance 
> controller catches this, but it makes going back impossible (since you land 
> back on the instance page and immediately get redirected again).
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 
> 
> Diff: https://reviews.apache.org/r/38018/diff/
> 
> 
> Testing
> ---
> 
> Verified link goes directly to the update page.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/
---

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
---

This was missed when I added the instance page. The redirect in the instance 
controller catches this, but it makes going back impossible (since you land 
back on the instance page and immediately get redirected again).


Diffs
-

  src/main/resources/scheduler/assets/latestUpdates.html 
54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 

Diff: https://reviews.apache.org/r/38018/diff/


Testing
---

Verified link goes directly to the update page.


Thanks,

Joshua Cohen



Re: Review Request 38018: Fix link to update page for the update list.

2015-09-01 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38018/#review97340
---

Ship it!


Ship It!

- Zameer Manji


On Sept. 1, 2015, 2:27 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38018/
> ---
> 
> (Updated Sept. 1, 2015, 2:27 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was missed when I added the instance page. The redirect in the instance 
> controller catches this, but it makes going back impossible (since you land 
> back on the instance page and immediately get redirected again).
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 54bcdedf49ed852ab6eb0475250b81cb1ebc3b28 
> 
> Diff: https://reviews.apache.org/r/38018/diff/
> 
> 
> Testing
> ---
> 
> Verified link goes directly to the update page.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>