Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98515 --- This patch does not apply cleanly on master (98f692d), do you need

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98503 --- Ship it! Any plans to get rid of mutable thrift objects in mybatis

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 5:36 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 5:28 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 7:10 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98543 --- Ship it! Master (e57993b) is green with this patch.

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98345 --- Maxim - ping. - Bill Farner On Sept. 8, 2015, 4:26 p.m., Bill

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Maxim Khutornenko
> On Sept. 8, 2015, 10:04 p.m., Maxim Khutornenko wrote: > > Waiting for the aforementioned rationale write up and related risk analysis > > (e.g.: non-stable mutable->immutable->mutable loop). > > Bill Farner wrote: > Working on that now, but i'm not sure exactly what you're looking for

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98111 --- Ship it! Ship It! - Kevin Sweeney On Sept. 8, 2015, 3:47 p.m.,

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 3, 2015, 4:38 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review97695 --- Ship it! Master (9c0b1b2) is green with this patch.