Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38326/#review99252 --- Ship it! Ship It! - Zameer Manji On Sept. 11, 2015, 4:31 p.m.,

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-15 Thread Bill Farner
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-15 Thread Zameer Manji
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38326/#review99130 --- Ship it!

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-15 Thread Maxim Khutornenko
> On Sept. 11, 2015, 11:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38326/#review98708 --- How would you feel about an env var instead of command line arg?

Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38326/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1491

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
> On Sept. 11, 2015, 11:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. I don't really like relying on env variables in places where direct input is accepted. This is too

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Maxim Khutornenko
> On Sept. 11, 2015, 11:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct

Re: Review Request 38326: Adding ssh options into "aurora task" commands.

2015-09-11 Thread Bill Farner
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote: > > How would you feel about an env var instead of command line arg? This > > seems like something people might put in their bash profile. > > Maxim Khutornenko wrote: > I don't really like relying on env variables in places where direct