Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review102083 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 351)

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 5:12 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. -1 to this deprecation technique. -

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 10:12 a.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. > > David McLaughlin wrote: > -1

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 5:12 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. > > David McLaughlin wrote: > -1 to

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review102086 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2015, 1:32

Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/ --- (Updated Oct. 9, 2015, 1:32 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote: > > This change is backwards incompatible. Shouldn't we add a new field that > > provides the new type and deprecate the old field as per the deprecation > > policy? > > Maxim Khutornenko wrote: > This API/struct were created for the

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review101984 --- Ship it! Master (7408cb3) is green with this patch.

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review101985 --- This change is backwards incompatible. Shouldn't we add a new

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 12:01 a.m., David McLaughlin wrote: > > This change is backwards incompatible. Shouldn't we add a new field that > > provides the new type and deprecate the old field as per the deprecation > > policy? > > Maxim Khutornenko wrote: > This API/struct were created for the