Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread Bill Farner
> On Nov. 10, 2015, 12:18 p.m., John Sirois wrote: > > @ReviewBot retry FYI when you post a diff, the bot will pick it up. The manual intervention should only be necessary for a flaked build. - Bill --- This is an automatically genera

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105942 --- Master (3ea1b26) is red with this patch. ./build-support/jenkins/

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105940 --- @ReviewBot retry - John Sirois On Nov. 10, 2015, 1:17 p.m., John

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- (Updated Nov. 10, 2015, 1:17 p.m.) Review request for Aurora, Joe Smith, Bill F

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- (Updated Nov. 10, 2015, 1:06 p.m.) Review request for Aurora, Joe Smith, Bill F

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
> On Oct. 29, 2015, 4:57 p.m., Aurora ReviewBot wrote: > > Master (bcb4774) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [deferred-sources] > > 22:56:59 00:00 [deferred-sources]

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
> On Oct. 29, 2015, 4:57 p.m., Aurora ReviewBot wrote: > > Master (bcb4774) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [deferred-sources] > > 22:56:59 00:00 [deferred-sources]

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105753 --- Master (ec61b8b) is red with this patch. ./build-support/jenkins/

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105748 --- @ReviewBot retry - John Sirois On Nov. 9, 2015, 2:47 p.m., John

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- (Updated Nov. 9, 2015, 2:47 p.m.) Review request for Aurora, Joe Smith, Bill Fa

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105744 --- This patch does not apply cleanly on master (ec61b8b), do you need

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105743 --- @ReviewBot retry - John Sirois On Oct. 29, 2015, 4:05 p.m., John

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104743 --- Ship it! Applying your patch works for me on OS X 10.11- thanks!

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
> On Oct. 29, 2015, 4:15 p.m., Zameer Manji wrote: > > John, would you mind filing a ticket to track the followup work to use the > > built in pants checkstyle? > > Joe Smith wrote: > https://issues.apache.org/jira/browse/AURORA-1532 Thanks Joe. - John -

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote: > > Would you also mind updating the commit message to point to the pants > > changelog? Will do. > On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote: > > BUILD.tools, line 1 > >

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
> On Oct. 29, 2015, 4:26 p.m., Zameer Manji wrote: > > pants.ini, line 84 > > > > > > Follow up comment, should we bump this value to the latest setuptools > > release? > > Stephan Erb wrote: > +1 There was a s

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
> On Oct. 29, 2015, 4:57 p.m., Aurora ReviewBot wrote: > > Master (bcb4774) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [unpack-jars] > > 22:56:59 00:00 [deferred-sources] > > 22:56:59 00:00 [deferred-sources]

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-30 Thread Joe Smith
> On Oct. 29, 2015, 3:15 p.m., Zameer Manji wrote: > > John, would you mind filing a ticket to track the followup work to use the > > built in pants checkstyle? https://issues.apache.org/jira/browse/AURORA-1532 - Joe --- This is an aut

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-30 Thread Stephan Erb
> On Oct. 29, 2015, 11:26 p.m., Zameer Manji wrote: > > pants.ini, line 84 > > > > > > Follow up comment, should we bump this value to the latest setuptools > > release? +1 - Stephan

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104495 --- Master (bcb4774) is red with this patch. ./build-support/jenkins/

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104487 --- pants.ini (line 27)

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104484 --- Ship it! Would you also mind updating the commit message to point

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104483 --- John, would you mind filing a ticket to track the followup work to

Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Bugs: AURO