Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106684 --- Master (7b494f4) is red with this patch. ./build-support/jenkins/build.sh 16:51:29 00:00 [ivy-imports] 16:51:29 00:00 [unpack-jars] 16:51:29 00:00 [unpack-jars] 16:51:29 00:00 [deferred-sources] 16:51:29 00:00 [deferred-sources] 16:51:29 00:00 [gen] 16:51:29 00:00 [thrift] 16:51:29 00:00 [protoc] 16:51:29 00:00 [antlr] 16:51:30 00:01 [ragel] 16:51:30 00:01 [jaxb] 16:51:30 00:01 [wire] 16:51:30 00:01 [jvm-platform-validate] 16:51:30 00:01 [jvm-platform-validate] 16:51:30 00:01 [resolve] 16:51:30 00:01 [ivy] 16:51:30 00:01 [bootstrap-nailgun-server] 16:51:30 00:01 [resources] 16:51:30 00:01 [prepare] 16:51:30 00:01 [services] 16:51:30 00:01 [compile] 16:51:30 00:01 [compile] 16:51:30 00:01 [jvm] 16:51:30 00:01 [jvm-compilers] 16:51:30 00:01 [zinc-pre] 16:51:30 00:01 [zinc-post] 16:51:30 00:01 [jvm-dep-check] 16:51:30 00:01 [test] 16:51:30 00:01 [run_prep_command] 16:51:30 00:01 [test] 16:51:30 00:01 [pytest] 16:51:30 00:01 [run] 16:51:33 00:04 [chroot] 16:51:36 00:07 [complete][31m FAILURE[0m Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7: pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout) I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 16, 2015, 4:48 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > --- > > (Updated Nov. 16, 2015, 4:48 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > --- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD| 26 ++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini| 5 - > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > examples/vagrant/provision-dev-cluster.sh > 4474543bac16ac5af0de1f199e36e8b981d52e04 > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > --- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/ --- (Updated Nov. 16, 2015, 9:48 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes --- Improve documentation of mesos.native gymnastics. 3rdparty/python/requirements.txt | 15 +++ examples/vagrant/provision-dev-cluster.sh | 1 + 2 files changed, 16 insertions(+) Bugs: AURORA-1538 https://issues.apache.org/jira/browse/AURORA-1538 Repository: aurora Description --- This lifts `mesos.interface` and `mesos.native` out of `requirements.txt`, ties their versions together and isolates the custom repository needed by `mesos.native` to its `python_requirement`. 3rdparty/python/BUILD| 26 ++ 3rdparty/python/requirements.txt | 2 -- pants.ini| 5 - 3 files changed, 26 insertions(+), 7 deletions(-) Diffs (updated) - 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e examples/vagrant/provision-dev-cluster.sh 4474543bac16ac5af0de1f199e36e8b981d52e04 pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 Diff: https://reviews.apache.org/r/40324/diff/ Testing --- Successfully ran end-to-end with this change using a fresh vagrant image and clean repo via: ``` vagrant destroy && \ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/ --- (Updated Nov. 16, 2015, 10:42 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1538 https://issues.apache.org/jira/browse/AURORA-1538 Repository: aurora Description --- This lifts `mesos.interface` and `mesos.native` out of `requirements.txt`, ties their versions together and isolates the custom repository needed by `mesos.native` to its `python_requirement`. 3rdparty/python/BUILD| 26 ++ 3rdparty/python/requirements.txt | 2 -- pants.ini| 5 - 3 files changed, 26 insertions(+), 7 deletions(-) Diffs - 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e examples/vagrant/provision-dev-cluster.sh 4474543bac16ac5af0de1f199e36e8b981d52e04 pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 Diff: https://reviews.apache.org/r/40324/diff/ Testing --- Successfully ran end-to-end with this change using a fresh vagrant image and clean repo via: ``` vagrant destroy && \ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106693 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > --- > > (Updated Nov. 16, 2015, 5:42 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > --- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD| 26 ++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini| 5 - > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > examples/vagrant/provision-dev-cluster.sh > 4474543bac16ac5af0de1f199e36e8b981d52e04 > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > --- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106579 --- Ship it! LGTM, thanks! - Bill Farner On Nov. 14, 2015, 4:18 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > --- > > (Updated Nov. 14, 2015, 4:18 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > --- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD| 26 ++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini| 5 - > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > --- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106548 --- No functional change, I just promised a follow-up to https://reviews.apache.org/r/40299/ with another approach and this is it. This is a take-it or leave it. It certainly could be see as obscuring if folks are used to looking in pants.ini for a custom repos setup. - John Sirois On Nov. 14, 2015, 5:18 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > --- > > (Updated Nov. 14, 2015, 5:18 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > --- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD| 26 ++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini| 5 - > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > --- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1538 https://issues.apache.org/jira/browse/AURORA-1538 Repository: aurora Description --- This lifts `mesos.interface` and `mesos.native` out of `requirements.txt`, ties their versions together and isolates the custom repository needed by `mesos.native` to its `python_requirement`. 3rdparty/python/BUILD| 26 ++ 3rdparty/python/requirements.txt | 2 -- pants.ini| 5 - 3 files changed, 26 insertions(+), 7 deletions(-) Diffs - 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 Diff: https://reviews.apache.org/r/40324/diff/ Testing --- Successfully ran end-to-end with this change using a fresh vagrant image and clean repo via: ``` vagrant destroy && \ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois
Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106551 --- Ship it! Master (7b494f4) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 15, 2015, 12:18 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > --- > > (Updated Nov. 15, 2015, 12:18 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > --- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD| 26 ++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini| 5 - > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > - > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > --- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
