Re: Review Request 41786: Remove several scheduler command line arguments.

2016-01-03 Thread Bill Farner 


> On Dec. 31, 2015, 6:41 a.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java, line 51
> > 
> >
> > I've always thought those are somewhat meant to be used for backup 
> > recovery as an alternative to blocking the HTTP port? 
> > https://github.com/apache/aurora/blob/master/docs/storage-config.md#preparation.
> > 
> > Maybe someone can ask @jsmith or another SRE
> 
> Bill Farner wrote:
> That is one potential use.  However IMHO blocking (or controlling access 
> to, whether at the network level or with authentication) the HTTP port is a 
> much better hammer.
> 
> I'll be sure to update `storage-config.md`.

Oh hm, looks like HTTP-level blocking is already the documented suggestion:
```
Consider blocking external traffic on a port defined in `-http_port` for all 
schedulers to
prevent users from interacting with the scheduler during the restoration 
process. This will help
troubleshooting by reducing the scheduler log noise and prevent users from 
making changes that will
be erased after the backup snapshot is restored
```


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112392
---


On Dec. 29, 2015, 5:52 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dec. 29, 2015, 5:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112392
---



src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 


These docs are now out of date and can probably be dropped: 
https://github.com/apache/aurora/blob/master/docs/scheduler-storage.md



src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 


I've always thought those are somewhat meant to be used for backup recovery 
as an alternative to blocking the HTTP port? 
https://github.com/apache/aurora/blob/master/docs/storage-config.md#preparation.

Maybe someone can ask @jsmith or another SRE


- Stephan Erb


On Dec. 30, 2015, 2:52 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dec. 30, 2015, 2:52 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112401
---

Ship it!


Ship It!

- Stephan Erb


On Dez. 30, 2015, 2:52 vorm., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dez. 30, 2015, 2:52 vorm.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-31 Thread Stephan Erb 


> On Dez. 31, 2015, 3:41 nachm., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java,
> >  line 67
> > 
> >
> > These docs are now out of date and can probably be dropped: 
> > https://github.com/apache/aurora/blob/master/docs/scheduler-storage.md
> 
> Bill Farner wrote:
> Correct, note that this patch removes that doc.

Oh, didn't notice that.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112392
---


On Dez. 30, 2015, 2:52 vorm., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dez. 30, 2015, 2:52 vorm.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-30 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112362
---

Ship it!


Ship It!

- Zameer Manji


On Dec. 29, 2015, 5:52 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dec. 29, 2015, 5:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 41786: Remove several scheduler command line arguments.

2015-12-29 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/
---

Review request for Aurora, Joshua Cohen and Zameer Manji.


Repository: aurora


Description
---

Included some justification in `NEWS`.  I can't recall why 
`-enable_job_updates` and `-enable_job_creation` were introduced, but they seem 
unnecessary (i added them 3.5 years ago without much detail: 
https://github.com/apache/aurora/commit/91b1cb8).


Diffs
-

  NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
  docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
  src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
da6894e242c3aca2c34097971fac71c7caea4117 
  src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
548b5e7538c8d4914476b87cd123f0f22899ec2b 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
40995033472bbc404a6779fd0193f037831c212e 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
561c70b8c6b781a9ca6adc19328a691cdb2a009f 
  src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
7f29b799117b2de27f8201f62d3b199e01b36c5b 
  
src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
 2492796be8efd60df8d47510de5a7ff0d1f42656 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
216f92f98786b639575888aeea9e3c067a94370b 
  
src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 
9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
19b74159c37151d800c889b68394af159c0c3ee5 
  
src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
 0edb3151760ef5423c154628ba10f2a051b72a8b 

Diff: https://reviews.apache.org/r/41786/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41786/#review112279
---

Ship it!


Master (80ae5e8) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 30, 2015, 1:52 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41786/
> ---
> 
> (Updated Dec. 30, 2015, 1:52 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Included some justification in `NEWS`.  I can't recall why 
> `-enable_job_updates` and `-enable_job_creation` were introduced, but they 
> seem unnecessary (i added them 3.5 years ago without much detail: 
> https://github.com/apache/aurora/commit/91b1cb8).
> 
> 
> Diffs
> -
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   docs/scheduler-storage.md 1cd02f87d3062d76942cb9ec755084adc64d0aec 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> da6894e242c3aca2c34097971fac71c7caea4117 
>   src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 
> 548b5e7538c8d4914476b87cd123f0f22899ec2b 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 
> 40995033472bbc404a6779fd0193f037831c212e 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 561c70b8c6b781a9ca6adc19328a691cdb2a009f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java 
> b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> 7f29b799117b2de27f8201f62d3b199e01b36c5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
>  2492796be8efd60df8d47510de5a7ff0d1f42656 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
> 692ace0cdd0f44ee5b6a36d4ff9b4f4ede50ed5b 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> 216f92f98786b639575888aeea9e3c067a94370b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java
>  9abdbbba2eca744fc95859d5d384f91fb8dfb8ca 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java 
> 19b74159c37151d800c889b68394af159c0c3ee5 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
>  0edb3151760ef5423c154628ba10f2a051b72a8b 
> 
> Diff: https://reviews.apache.org/r/41786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>