Review Request 41893: Fixup missing commons compile dep.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41893/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --- I get compile errors when working on src/main/java/org/apache/aurora/common/zookeeper/testing. I'm not sure why CI and others do not. build.gradle | 5 + 1 file changed, 5 insertions(+) Diffs - build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75 Diff: https://reviews.apache.org/r/41893/diff/ Testing --- Not green locally due to ZK issues from https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7, but the CI script gets further on my machine with the junit dep added Thanks, John Sirois
Re: Review Request 41893: Fixup missing commons compile dep.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41893/#review112703 --- Ship it! Ship It! - Bill Farner On Jan. 4, 2016, 4:17 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41893/ > --- > > (Updated Jan. 4, 2016, 4:17 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > --- > > I get compile errors when working on > src/main/java/org/apache/aurora/common/zookeeper/testing. > I'm not sure why CI and others do not. > > build.gradle | 5 + > 1 file changed, 5 insertions(+) > > > Diffs > - > > build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75 > > Diff: https://reviews.apache.org/r/41893/diff/ > > > Testing > --- > > Not green locally due to ZK issues from > https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7, > but the CI script gets further on my machine with the junit > dep added > > > Thanks, > > John Sirois > >
Re: Review Request 41893: Fixup missing commons compile dep.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41893/#review112649 --- Showing my work: ``` $ git grep org.junit | grep src/main/java commons/src/main/java/org/apache/aurora/common/testing/TearDownTestCase.java:import org.junit.After; commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java:import org.junit.Before; commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import org.junit.Before; commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import org.junit.Rule; commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import org.junit.rules.TemporaryFolder; ``` - John Sirois On Jan. 4, 2016, 2:16 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41893/ > --- > > (Updated Jan. 4, 2016, 2:16 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > I get compile errors when working on > src/main/java/org/apache/aurora/common/zookeeper/testing. > I'm not sure why CI and others do not. > > build.gradle | 5 + > 1 file changed, 5 insertions(+) > > > Diffs > - > > build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75 > > Diff: https://reviews.apache.org/r/41893/diff/ > > > Testing > --- > > Not green locally due to ZK issues from > https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7, > but the CI script gets further on my machine with the junit > dep added > > > Thanks, > > John Sirois > >
