Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41915/#review112750 --- Ship it!

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 8:25 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 72 > > > > > > We usually put this default initialization directly into the arg list, > >

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread Maxim Khutornenko
> On Jan. 5, 2016, 3:05 a.m., John Sirois wrote: > > Another answer could be to delete this test altogether. It looks like it > > only really tests the proper converson from Time Amounts to fractional > > second waits. > > Bill Farner wrote: > I'm tempted to take this route as well.

Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41915/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 8:25 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 72 > > > > > > We usually put this default initialization directly into the arg list, > >

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 8:05 p.m., John Sirois wrote: > > Another answer could be to delete this test altogether. It looks like it > > only really tests the proper converson from Time Amounts to fractional > > second waits. > > Bill Farner wrote: > I'm tempted to take this route as well.

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41915/ --- (Updated Jan. 4, 2016, 8:02 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 8:25 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 72 > > > > > > We usually put this default initialization directly into the arg list, > >

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread Bill Farner
> On Jan. 4, 2016, 7:05 p.m., John Sirois wrote: > > Another answer could be to delete this test altogether. It looks like it > > only really tests the proper converson from Time Amounts to fractional > > second waits. I'm tempted to take this route as well. It's not clear to me what this

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41915/#review112766 --- Ship it! Master (227a3a6) is green with this patch.

Re: Review Request 41915: Fixup TaskObserverTest to respect thread memory models.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 8:05 p.m., John Sirois wrote: > > Another answer could be to delete this test altogether. It looks like it > > only really tests the proper converson from Time Amounts to fractional > > second waits. > > Bill Farner wrote: > I'm tempted to take this route as well.