Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114000 --- src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

> On Jan. 11, 2016, 3:42 p.m., Zhitao Li wrote: > > src/main/java/org/apache/aurora/scheduler/OfferAllocation.java, line 188 > > > > > > Hmm, I think I'd like to keep this for two reasons: > > > > 1. Even

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

> On Jan. 12, 2016, 6:05 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java, line 40 > > > > > > The interface should really be removed. It's not acting as an > > interface

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

> On Jan. 11, 2016, 8:25 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 201 > > > > > > Is `clearResources()` necessary here? I think it makes sense to

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113862 --- src/main/java/org/apache/aurora/scheduler/OfferAllocation.java

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- (Updated Jan. 12, 2016, 2:29 a.m.) Review request for Aurora, Maxim

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113917 --- Ship it! Master (f064dc1) is green with this patch.

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113768 --- Nice job! Most comments here are nits to align code

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113785 --- src/main/java/org/apache/aurora/scheduler/OfferAllocation.java

Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Re: Review Request 42126: New interface to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review113681 --- Ship it! Master (e4c9c73) is green with this patch.