Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-02-02 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review117482 --- Sorry for coming to this only after it's committed, but I think

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-02-02 Thread Zhitao Li
> On Feb. 2, 2016, 9:31 p.m., Zhitao Li wrote: > > Sorry for coming to this only after it's committed, but I think this might > > create trouble for operators during upgrade. > > > > Because the new executor will not understand the `--announce-enable` flag > > and crashes, the operator has to

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116334 --- Ship it! Ship It! - Stephan Erb On Jan. 25, 2016, 7:03

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116398 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2016, 10:03

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/ --- (Updated Jan. 26, 2016, 10:40 a.m.) Review request for Aurora, Maxim

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116134 --- Ship it! Master (5684c64) is green with this patch.

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Bill Farner
> On Jan. 25, 2016, 10:27 a.m., Stephan Erb wrote: > > General question: How do we want to handle corresponding updates in the > > packaging repo? In an immediate additional review request or in a general > > overhaul before the next release? Great question! So far it's been ad-hoc, with an

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116136 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 25, 2016,