Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

2016-03-10 Thread Maxim Khutornenko
> On March 10, 2016, 3:39 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 128 > > > > > > It looks like the existing usages have inexpensive message formatting, > >

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

2016-03-10 Thread Maxim Khutornenko
> On March 10, 2016, 1:40 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 174 > > > > > > no big deal, but it would be nice if the line break style

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

2016-03-10 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44493/#review122846 --- Ship it!

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

2016-03-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44493/#review122467 --- Ship it! Master (a91a759) is green with this patch.

Review Request 44493: Log and terminate scheduler on updater thread failure.

2016-03-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44493/ --- Review request for Aurora, John Sirois and Bill Farner. Bugs: AURORA-1630